From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx146.postini.com [74.125.245.146]) by kanga.kvack.org (Postfix) with SMTP id DEC996B0069 for ; Fri, 19 Oct 2012 15:44:51 -0400 (EDT) Date: Fri, 19 Oct 2012 19:44:49 +0000 From: Christoph Lameter Subject: Re: [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree In-Reply-To: <1350656442-1523-11-git-send-email-glommer@parallels.com> Message-ID: <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com> References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-11-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu@jp.fujitsu.com, David Rientjes , Pekka Enberg , devel@openvz.org, Pekka Enberg , Suleiman Souhlal On Fri, 19 Oct 2012, Glauber Costa wrote: > struct page already have this information. If we start chaining > caches, this information will always be more trustworthy than > whatever is passed into the function Yes it does but the information is not standardized between the allocators yet. Coul you unify that? Come out with a struct page overlay that is as much the same as possible. Then kfree can also be unified because the lookup is always the same. That way you can move kfree into slab_common and avoid modifying multiple allocators. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org