From: Christoph Lameter <cl@linux.com>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] SLUB: increase the range of slab sizes available to kmalloc, allowing a somewhat more effient use of memory.
Date: Mon, 15 Oct 2012 20:44:25 +0000 [thread overview]
Message-ID: <0000013a662b9db5-1ea40fb2-3337-4cbc-8eca-5a610564dd75-000000@email.amazonses.com> (raw)
In-Reply-To: <1350145885-6099-3-git-send-email-richard@rsk.demon.co.uk>
On Sat, 13 Oct 2012, Richard Kennedy wrote:
> -extern struct kmem_cache *kmalloc_caches[SLUB_PAGE_SHIFT];
>
> -/*
> - * Sorry that the following has to be that ugly but some versions of GCC
> - * have trouble with constant propagation and loops.
> +static const short __slab_sizes[] = {0, 8, 12, 16, 24, 32, 48, 64, 96,
> + 128, 192, 256, 384, 512, 768, 1024,
> + 1536, 2048, 3072, 4096, 6144, 8192};
> +
Urg. No thanks. What is the exact benefit of this patch?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-15 20:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 16:31 [PATCH 0/2] RFC SLUB: increase range of kmalloc slab sizes Richard Kennedy
2012-10-13 16:31 ` [PATCH 1/2] SLUB: remove hard coded magic numbers from resiliency_test Richard Kennedy
2012-10-13 16:31 ` [PATCH 2/2] SLUB: increase the range of slab sizes available to kmalloc, allowing a somewhat more effient use of memory Richard Kennedy
2012-10-15 20:44 ` Christoph Lameter [this message]
2012-10-15 20:41 ` [PATCH 1/2] SLUB: remove hard coded magic numbers from resiliency_test Christoph Lameter
2012-10-16 0:53 ` David Rientjes
2012-10-16 13:47 ` Christoph Lameter
2012-10-13 23:46 ` [PATCH 0/2] RFC SLUB: increase range of kmalloc slab sizes Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0000013a662b9db5-1ea40fb2-3337-4cbc-8eca-5a610564dd75-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox