Re: [PATCH mmotm] slub: zero page to fix boot crashes

[Christoph <cl@linux.com>]

Yes that fix was already sent by me.



On Sep 8, 2012, at 22:42, Hugh Dickins <hughd@google.com> wrote:

> Latest mmotm rarely boots if SLUB is enabled: earlyprintk=vga shows
> it crashing with various backtraces.  The memset has now been removed
> from kmem_cache_open(), so kmem_cache_init() needs to zero its page.
> This gets SLUB booting reliably again.
> 
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
> 
> mm/slub.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- mmotm/mm/slub.c    2012-09-07 12:39:38.136019730 -0700
> +++ fixed/mm/slub.c    2012-09-08 19:37:38.608993123 -0700
> @@ -3712,7 +3712,7 @@ void __init kmem_cache_init(void)
>    /* Allocate two kmem_caches from the page allocator */
>    kmalloc_size = ALIGN(kmem_size, cache_line_size());
>    order = get_order(2 * kmalloc_size);
> -    kmem_cache = (void *)__get_free_pages(GFP_NOWAIT, order);
> +    kmem_cache = (void *)__get_free_pages(GFP_NOWAIT | __GFP_ZERO, order);
> 
>    /*
>     * Must first have the slab cache available for the allocations of the

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>