From: Christoph Lameter <cl@linux.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Joonsoo Kim <js1304@gmail.com>,
Glauber Costa <glommer@parallels.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>
Subject: C14 [14/14] [PATCH 23/28] Move kmem_cache refcounting to common code
Date: Tue, 4 Sep 2012 23:38:33 +0000 [thread overview]
Message-ID: <0000013993a64ddd-0d791c46-537f-4b7f-811b-a8834fe02093-000000@email.amazonses.com> (raw)
In-Reply-To: <20120904230609.691088980@linux.com>
Get rid of the refcount stuff in the allocators and do that
part of kmem_cache management in the common code.
Signed-off-by: Christoph Lameter <cl@linux.com>
---
mm/slab.c | 1 -
mm/slab_common.c | 5 +++--
mm/slob.c | 2 --
mm/slub.c | 1 -
4 files changed, 3 insertions(+), 6 deletions(-)
Index: linux/mm/slab.c
===================================================================
--- linux.orig/mm/slab.c 2012-09-04 18:00:16.870082786 -0500
+++ linux/mm/slab.c 2012-09-04 18:00:16.882082975 -0500
@@ -2555,7 +2555,6 @@ __kmem_cache_create (struct kmem_cache *
*/
BUG_ON(ZERO_OR_NULL_PTR(cachep->slabp_cache));
}
- cachep->refcount = 1;
err = setup_cpu_cache(cachep, gfp);
if (err) {
Index: linux/mm/slab_common.c
===================================================================
--- linux.orig/mm/slab_common.c 2012-09-04 18:00:16.870082786 -0500
+++ linux/mm/slab_common.c 2012-09-04 18:00:16.886083040 -0500
@@ -125,11 +125,12 @@ struct kmem_cache *kmem_cache_create(con
}
err = __kmem_cache_create(s, flags);
- if (!err)
+ if (!err) {
+ s->refcount = 1;
list_add(&s->list, &slab_caches);
- else {
+ } else {
kfree(s->name);
kmem_cache_free(kmem_cache, s);
}
Index: linux/mm/slob.c
===================================================================
--- linux.orig/mm/slob.c 2012-09-04 18:00:16.870082786 -0500
+++ linux/mm/slob.c 2012-09-04 18:00:16.886083040 -0500
@@ -524,7 +524,6 @@ int __kmem_cache_create(struct kmem_cach
if (c->align < align)
c->align = align;
- c->refcount = 1;
return 0;
}
Index: linux/mm/slub.c
===================================================================
--- linux.orig/mm/slub.c 2012-09-04 18:00:16.870082786 -0500
+++ linux/mm/slub.c 2012-09-04 18:00:16.886083040 -0500
@@ -3093,7 +3093,6 @@ static int kmem_cache_open(struct kmem_c
else
s->cpu_partial = 30;
- s->refcount = 1;
#ifdef CONFIG_NUMA
s->remote_node_defrag_ratio = 1000;
#endif
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-04 23:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120904230609.691088980@linux.com>
2012-09-04 23:06 ` C14 [01/14] [PATCH 10/28] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-09-04 23:06 ` C14 [02/14] slub: Use kmem_cache for the kmem_cache structure Christoph Lameter
2012-09-04 23:18 ` C14 [13/14] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-09-04 23:18 ` C14 [09/14] Move duping of slab name to slab_common.c Christoph Lameter
2012-09-04 23:18 ` C14 [05/14] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-09-04 23:38 ` C14 [08/14] Get rid of __kmem_cache_destroy Christoph Lameter
2012-09-04 23:38 ` Christoph Lameter [this message]
2012-09-04 23:38 ` C14 [04/14] Move list_add() to slab_common.c Christoph Lameter
2012-09-05 0:18 ` C14 [07/14] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-09-05 0:18 ` C14 [11/14] Move sysfs_slab_add to common Christoph Lameter
2012-09-05 0:18 ` C14 [10/14] Do slab aliasing call from common code Christoph Lameter
2012-09-05 0:20 ` C14 [06/14] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-09-05 0:20 ` C14 [03/14] Improve error handling in kmem_cache_create Christoph Lameter
2012-09-05 0:20 ` C14 [12/14] Move kmem_cache allocations into common code Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0000013993a64ddd-0d791c46-537f-4b7f-811b-a8834fe02093-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=glommer@parallels.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox