From: Christoph Lameter <cl@linux.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Pekka Enberg <penberg@kernel.org>, Joonsoo Kim <js1304@gmail.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>
Subject: Re: C13 [05/14] Extract a common function for kmem_cache_destroy
Date: Tue, 4 Sep 2012 22:58:59 +0000 [thread overview]
Message-ID: <00000139938213ef-f5749497-9038-4275-9aaa-bb6b08f54dec-000000@email.amazonses.com> (raw)
In-Reply-To: <5044CC24.7000800@parallels.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 771 bytes --]
On Mon, 3 Sep 2012, Glauber Costa wrote:
> On 08/24/2012 08:10 PM, Christoph Lameter wrote:
> > kmem_cache_destroy does basically the same in all allocators.
> >
> > Extract common code which is easy since we already have common mutex handling.
> >
> > V1-V2:
> > - Move percpu freeing to later so that we fail cleaner if
> > objects are left in the cache [JoonSoo Kim]
> >
> > Signed-off-by: Christoph Lameter <cl@linux.com>
>
> Fails to build for the slab. Error is pretty much self-explanatory:
>
> CC mm/slab.o
> mm/slab.c: In function i? 1/2 slab_destroy_debugchecki? 1/2 :
> mm/slab.c:2157:5: error: implicit declaration of function i? 1/2 slab_errori? 1/2
> [-Werror=implicit-function-declaration]
Ok. We need to keep the slab_error function for now.
next prev parent reply other threads:[~2012-09-04 22:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120824160903.168122683@linux.com>
2012-08-24 16:10 ` Christoph Lameter
2012-09-03 14:41 ` Glauber Costa
2012-09-03 15:26 ` Glauber Costa
2012-09-04 22:58 ` Christoph Lameter [this message]
2012-08-24 16:12 ` C13 [07/14] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-09-03 14:51 ` Glauber Costa
2012-08-24 16:12 ` C13 [08/14] Get rid of __kmem_cache_destroy Christoph Lameter
2012-09-03 14:58 ` Glauber Costa
2012-09-04 22:39 ` Christoph Lameter
2012-09-05 8:25 ` Glauber Costa
2012-08-24 16:17 ` C13 [11/14] Move sysfs_slab_add to common Christoph Lameter
2012-09-03 15:09 ` Glauber Costa
2012-08-24 16:17 ` C13 [12/14] Move kmem_cache allocations into common code Christoph Lameter
2012-09-03 15:24 ` Glauber Costa
2012-08-24 16:17 ` C13 [03/14] Improve error handling in kmem_cache_create Christoph Lameter
2012-09-03 14:30 ` Glauber Costa
2012-08-24 16:17 ` C13 [10/14] Do slab aliasing call from common code Christoph Lameter
2012-08-24 16:17 ` C13 [06/14] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-08-24 16:17 ` C13 [04/14] Move list_add() to slab_common.c Christoph Lameter
2012-08-24 16:17 ` C13 [01/14] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-09-03 14:26 ` Glauber Costa
2012-08-24 16:17 ` C13 [09/14] Move duping of slab name to slab_common.c Christoph Lameter
2012-09-03 15:02 ` Glauber Costa
2012-08-24 16:17 ` C13 [13/14] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-09-03 15:33 ` Glauber Costa
2012-09-03 15:35 ` Glauber Costa
2012-09-04 22:48 ` Christoph Lameter
2012-08-24 16:17 ` C13 [02/14] slub: Use kmem_cache for the kmem_cache structure Christoph Lameter
2012-09-03 14:27 ` Glauber Costa
2012-08-24 16:17 ` C13 [14/14] Move kmem_cache refcounting to common code Christoph Lameter
2012-09-03 15:12 ` Glauber Costa
2012-09-04 19:10 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00000139938213ef-f5749497-9038-4275-9aaa-bb6b08f54dec-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=glommer@parallels.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox