From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B545C48BC4 for ; Fri, 16 Feb 2024 06:08:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2614A8D0010; Fri, 16 Feb 2024 01:08:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 211D18D0006; Fri, 16 Feb 2024 01:08:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 089FB8D0010; Fri, 16 Feb 2024 01:08:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EAE288D0006 for ; Fri, 16 Feb 2024 01:08:51 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4E7B41A0515 for ; Fri, 16 Feb 2024 06:07:30 +0000 (UTC) X-FDA: 81796635060.12.F082E33 Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by imf04.hostedemail.com (Postfix) with ESMTP id 8C14940010 for ; Fri, 16 Feb 2024 06:07:28 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of 3n_vOZQkbAAg067sittmzixxql.owwotm20mzkwv1mv1.kwu@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.197 as permitted sender) smtp.mailfrom=3n_vOZQkbAAg067sittmzixxql.owwotm20mzkwv1mv1.kwu@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708063648; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=4F2YASos/WaI9dxX5WGWFwdCo+2tbvtN26YAtxHcV9s=; b=Q1Jt2rKnRPHBBO1TOk3wf6jHg0qV1A7HcDz82h0RBlLCKy51PJkVLVXa9/4iucixWZqF+V Lq+jfLVAFldbulaCOsuvH2bGqYExSR34xUhwNtCTqx7QzARDUJobOtEhPUD9seTreftm15 gJ3KieeJOEP79yLcJMY8JknpM7dfj9Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708063648; a=rsa-sha256; cv=none; b=C6Phb+1xPc1WctMMpAoiPsT1pLTXW2+uqik0QhVgBL6jc7EqHIX6SKzw+UPSm/r8t3vgtM EtnKMWdALdyaG9h4a+7OkLUB6mjYFakaz0o67AIrOh7HUleokgd9oFz2rL6l4T38gmBb67 8xtAFwOCLhL19Y3prnHQ9H9+JSGmOX8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of 3n_vOZQkbAAg067sittmzixxql.owwotm20mzkwv1mv1.kwu@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.197 as permitted sender) smtp.mailfrom=3n_vOZQkbAAg067sittmzixxql.owwotm20mzkwv1mv1.kwu@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none) Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-363b68b9af3so12874925ab.1 for ; Thu, 15 Feb 2024 22:07:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708063648; x=1708668448; h=to:from:subject:message-id:date:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4F2YASos/WaI9dxX5WGWFwdCo+2tbvtN26YAtxHcV9s=; b=A0ZFaOStKQtb55q+fuh5+VJMODO1BYrVd+epGMkKAon4q2gX4jV8XqWxnlE4WOxxRp zNnf6dVhC2VwSsSr/O3Zg6kqA6qOLaNeDiUPc6asik49gRk71en+oSvDIItF2tcyTUUS lzGEGojGNI3yP95GBf4jYjyBfmRqsC+wDZlsjmT/IGzmBYE3wPMEV0E939DqIAOsL8bf eQe+z79Gm80IFrnAB5GCQ+JIhCC5e0XtMqUyvQTNEub5/s6RsOzGpVQR2lV9kmdVSXZu dZquqNMiRxUmSxVGv7mKQN7IAevqzEvLHeOmb46drYJAA8/alaIxp0Vs7PVJCiGkeDUn KAug== X-Forwarded-Encrypted: i=1; AJvYcCXOG/+7yGrJCJAj8dV99L4YknBDaqdz+Uejr5Mjh6yLBCYX7jPRHHixIWFttomU8rJhrcmHDg0JmJZUt3PysU7Ispg= X-Gm-Message-State: AOJu0YzMfsK/kUfa9gRPlRZNFDrVAt8X9mBpvZUZKEVbYpL+5R2SYqXI BF56Lzp1uskf10m9gsh36TwFS3mZ2dnaoX2CYmWzeKLZzIZ4eY5WfK1AaaqL4HQoozeBNsWteOw 1AQUzcbxon+6OHqFrc8f809cZdfS8DCq8GBdC325gfpB/t109ybBQKqY= X-Google-Smtp-Source: AGHT+IG0M6rkbOe11lpZQGSZExlEryIZb9CjCRq56IOJvg3Fha44Kc2qgLHGDvA0MYeWpzzardLkaha1l9WT8hXlZy4DNY66p9EK MIME-Version: 1.0 X-Received: by 2002:a92:cda8:0:b0:363:cc38:db1c with SMTP id g8-20020a92cda8000000b00363cc38db1cmr322034ild.6.1708063647882; Thu, 15 Feb 2024 22:07:27 -0800 (PST) Date: Thu, 15 Feb 2024 22:07:27 -0800 X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <000000000000fc6b2c0611798e90@google.com> Subject: [syzbot] [mm?] possible deadlock in lock_vma From: syzbot To: akpm@linux-foundation.org, axelrasmussen@google.com, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lokeshgidra@google.com, mirq-linux@rere.qmqm.pl, peterx@redhat.com, rppt@kernel.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8C14940010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fpznf31cdwiznq5yg7pus8cont3q1ph9 X-HE-Tag: 1708063648-246085 X-HE-Meta: U2FsdGVkX19XnA3QZvbtT/AdPhXkgDlsOkzyuw7dqdqI1fx1+ST3J1agpzg8kKYAc759WxUKOJ5oTQfaggrdxFSeKvUS1ueaJ3Nms099Q/RoVqFL89AAG87VBnFI5R29F6y/BZhWbgc6IKA3zYRV9hQRSw9EqAJjJoRYiwQBlMeBIKsRnnqFQXWBttSWp40MxBAaMFNCXSJ8vdFE6c55s1iICvz/DauBEyO18qGMk+ZNSkyZ6wZNElnU8DxYavjvkCCg0jFqhtygnDSSq1vx4RFJ3EHYyqRdLbORCRg7olCNgnfcmMv7me4O6cDtgP/wervqj0fQZFq01uab8uY0p56vQA+/AFrVZ9OR0dYRI+V6s21qVsNqog998iY+P0zpp+hZU89YlrMDN/lWqYAdCns+gibq2L8qP1MXsbvf7uMPdQ2TjcFG3khZE/0X94l9HP45/uLc3VD/RatWVKfGTY5eB+P+Ogb+R5amsdiEhHGhGoOVrMxKcgZw9JKKuDpX9OpLoS5Ysm+2OUcfi7Fm3xpHXiY7k2srdg0Fw28qocCw7swFm0M6/yCY2VkHEV8p/qaCg7A96RfdLa6wcDLPBzELTclFHak9DRMAH8TJ9a43LRcOWckxH8WpfvmcEzQupVC70wb3UTcJqPVZh3Z3JRLZsLaqaogbxC25eHxHPMYDF+cIjgRLuIvHH+kXAoymLaia+AMcHkzBEL6oV8yD0TMruucc9bRWOb4fN29TXQZWzu+IvXnCxCqqmSCL27WH1jcX5/X0t4mTHuKw0yogQnckNBMhwxD4ACpRAxGZl+N3P4aW6vKdNV5r6ahyT6BiELBSopSMp0gRBEDY5eNRW6RvEx2oUiYT6Ls9ZOgDfYAXkyO/Lw/tPKOLpKveFMmS8+1MuH8hIjqDwtI0jhrZfqatlUBMdmvI4e684kU+/2j39q+F/n3xA/TbX0dtrgOhy/v1Iy8hWj9poM/orLA EUbYxy1d I0RupetfeJpMExWI6ldDH/luLgsUO0kulGaTAfPggC9AeWK35z/7va2IPMIlbJo202wsv7ppcxhB6in5qlAV+FeROtcLtEio2p6OwjQVPg/5PxktLE9GO/URslhs1sl0stTaN03o/iMOdX1ufB3ueRk2mBbtxwE6Uoj51MUtVxSaVMwbtXEICCUJErKqYKEoFJz44z2w1Q/W9Z1BPoLXQ2fAaJEdXTCWwyPgSPS6SSqu/4B5zDm5EZtl/EUX6gsTWqPGCLHbRy6gZz7VMc9XG7EAOISPuwLwDUkt04rSo0lgCmWS8YuFXy6A0WqgY0sOKXMzjAc9qsVR02fyyAQPwBOBr/lF+aCrBfj4Zlr8oN3TEzRHcvio507+bb1l/azS2qG4/isQ763iiBd2dQ/GJmvYV9gNGtr28agQs2rqF7L2O82sKotP1F8LsTV6zM5ThB4pjd54CW4/NVpYdtKz2XrwX0dt24lxSi5C9wyiToCJg4P/oQJOrTyqM9IXNDM7osOofiNBAjZrlxNFbC+DWJxUMwuEa5p1A9InWmUUjbEAIuM/04bJj6N2DE7PgZLKianI+DspXw5Ry7u8Nheb9VsyGZdQyJaMVaB8o2byEbSHtG/0rPTgCTC7072bH7lZkuMiv84Gy3SqHgkKIUDTGK49M1yEE5Js7bI8+rtGQFBJ5a8+Ag2EenePKag2h26WHa0fcVRrz/ow5A6scm+Y2YUXi/ko5mhq460g2XDDXlDl3VzxpAa0glFPdmKGTZMPCeQQAz8lCbvIYERKVL1rVRypn0VNkB2PSqb0cSRHY/B/6bxWNTW9BPJmtKtuwHNLMHaDHKPL5XG+Kazm2yguUswYhAfrcTPTuM9vd3y0QuP785ifwMMcrlsiBrF+DEOAwlPhzq6j2CqaTDxOBdQCdOS60KIlqAy/HmVb9hlmEpPXVcwRh3co45oss0znydvAYm59yMEYPCvC6HdVBzT/SDpFBwMIp wraMFCF6 zGs3ucH21istHcndm/2x3T1hm3mPLPn9oz43ajbxKR7Ls9a0cGHTzP/ry2MHYn/hxI1PYSIlWXedMzksI5kMQDD9f4xpB5RFSyBiJadtLkct0BwU7P/eaXdbatrLaU5G5jXNQzUQR2wWefzQFe5fZfspBQMMY19whT7kwiDXAZUVsP8vf4aWOtkSGlAxsHEFuLyEJKGRH8bkMgyPpEpo0tFO/pBfCE6hUZE09QfqqtRqDVbCtw2MSbXiCiohg9F5ioieWFUW2kTdZDgNjxMmoFZs5CbBLU31bxB/E6Irbv3idprhNvtOXRmo3XKlZXKbs7UYQd4EvfzmyU1S6EWET13CA165Xcduy8weA1tsD/Otx2wlzJQsk0IyGFgzCPiqONQxRXP7SyM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, syzbot found the following issue on: HEAD commit: ae00c445390b Add linux-next specific files for 20240212 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=17478592180000 kernel config: https://syzkaller.appspot.com/x/.config?x=4eb3a27eddb32a14 dashboard link: https://syzkaller.appspot.com/bug?extid=27f783f9d240834c9d44 compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17406e42180000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=111cb500180000 Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/8b2a2d0b511f/disk-ae00c445.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/a668a09c9d03/vmlinux-ae00c445.xz kernel image: https://storage.googleapis.com/syzbot-assets/4ad623928692/bzImage-ae00c445.xz The issue was bisected to: commit 31d97016c80a83daa4c938014c81282810a14773 Author: Lokesh Gidra Date: Thu Feb 8 21:22:04 2024 +0000 userfaultfd: use per-vma locks in userfaultfd operations bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=129ff100180000 final oops: https://syzkaller.appspot.com/x/report.txt?x=119ff100180000 console output: https://syzkaller.appspot.com/x/log.txt?x=169ff100180000 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+27f783f9d240834c9d44@syzkaller.appspotmail.com Fixes: 31d97016c80a ("userfaultfd: use per-vma locks in userfaultfd operations") ====================================================== WARNING: possible circular locking dependency detected 6.8.0-rc4-next-20240212-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor800/5064 is trying to acquire lock: ffff888021d401a0 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:146 [inline] ffff888021d401a0 (&mm->mmap_lock){++++}-{3:3}, at: lock_vma+0xc5/0x260 mm/userfaultfd.c:73 but task is already holding lock: ffff88802b989730 (&vma->vm_lock->lock){++++}-{3:3}, at: lock_vma+0x1a1/0x260 mm/userfaultfd.c:87 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&vma->vm_lock->lock){++++}-{3:3}: lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 down_write+0x3a/0x50 kernel/locking/rwsem.c:1579 vma_start_write include/linux/mm.h:716 [inline] vma_link+0x2c6/0x550 mm/mmap.c:416 insert_vm_struct+0x1a3/0x260 mm/mmap.c:3331 __bprm_mm_init fs/exec.c:282 [inline] bprm_mm_init fs/exec.c:384 [inline] alloc_bprm+0x543/0xa00 fs/exec.c:1579 kernel_execve+0x99/0xa10 fs/exec.c:2008 try_to_run_init_process init/main.c:1361 [inline] kernel_init+0xe8/0x2b0 init/main.c:1488 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:242 -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 mmap_read_lock include/linux/mmap_lock.h:146 [inline] lock_vma+0xc5/0x260 mm/userfaultfd.c:73 find_and_lock_vmas mm/userfaultfd.c:1405 [inline] move_pages+0x18c/0xff0 mm/userfaultfd.c:1546 userfaultfd_move fs/userfaultfd.c:2008 [inline] userfaultfd_ioctl+0x5c10/0x72c0 fs/userfaultfd.c:2126 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:857 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(&vma->vm_lock->lock); lock(&mm->mmap_lock); lock(&vma->vm_lock->lock); rlock(&mm->mmap_lock); *** DEADLOCK *** 1 lock held by syz-executor800/5064: #0: ffff88802b989730 (&vma->vm_lock->lock){++++}-{3:3}, at: lock_vma+0x1a1/0x260 mm/userfaultfd.c:87 stack backtrace: CPU: 1 PID: 5064 Comm: syz-executor800 Not tainted 6.8.0-rc4-next-20240212-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 mmap_read_lock include/linux/mmap_lock.h:146 [inline] lock_vma+0xc5/0x260 mm/userfaultfd.c:73 find_and_lock_vmas mm/userfaultfd.c:1405 [inline] move_pages+0x18c/0xff0 mm/userfaultfd.c:1546 userfaultfd_move fs/userfaultfd.c:2008 [inline] userfaultfd_ioctl+0x5c10/0x72c0 fs/userfaultfd.c:2126 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:857 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 RIP: 0033:0x7f86fc35f329 Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffd53428e38 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007ffd53429008 RCX: 00007f86fc35f329 RDX: 0000000020000040 RSI: 00000000c028aa05 RDI: --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection If the report is already addressed, let syzbot know by replying with: #syz fix: exact-commit-title If you want syzbot to run the reproducer, reply with: #syz test: git://repo/address.git branch-or-commit-hash If you attach or paste a git patch, syzbot will apply it before testing. If you want to overwrite report's subsystems, reply with: #syz set subsystems: new-subsystem (See the list of subsystem names on the web dashboard) If the report is a duplicate of another one, reply with: #syz dup: exact-subject-of-another-report If you want to undo deduplication, reply with: #syz undup