From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF64BC77B61 for ; Fri, 7 Apr 2023 16:36:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF2B3900003; Fri, 7 Apr 2023 12:36:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA262900002; Fri, 7 Apr 2023 12:36:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6A81900003; Fri, 7 Apr 2023 12:36:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C8FE9900002 for ; Fri, 7 Apr 2023 12:36:52 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A47534047E for ; Fri, 7 Apr 2023 16:36:52 +0000 (UTC) X-FDA: 80655149064.05.F98C297 Received: from mail-io1-f77.google.com (mail-io1-f77.google.com [209.85.166.77]) by imf07.hostedemail.com (Postfix) with ESMTP id E2DB34001F for ; Fri, 7 Apr 2023 16:36:50 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf07.hostedemail.com: domain of 3oUYwZAkbABgGMN8y992FyDD61.4CC492IG2F0CBH2BH.0CA@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.77 as permitted sender) smtp.mailfrom=3oUYwZAkbABgGMN8y992FyDD61.4CC492IG2F0CBH2BH.0CA@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680885411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references; bh=Nplfd14bvjlVkVD4YGNhodAVpFm+bek0gQyvwM51NR0=; b=mvgZNt+AB22wx8j5iA8qaFzLEweW5okEjL7uTCMQkGgCPwemeXCeMVNCwAsRhuqXisad0t dWtOg8MoG22+ghvC6o9EBwQfWFMM5+F1UgfaMJGGpXOxGLyyxFoylyH6rqRr8OZTMVNfqs YnuRlK9FNZgssp49C+pP92sVaiahA8Q= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf07.hostedemail.com: domain of 3oUYwZAkbABgGMN8y992FyDD61.4CC492IG2F0CBH2BH.0CA@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.77 as permitted sender) smtp.mailfrom=3oUYwZAkbABgGMN8y992FyDD61.4CC492IG2F0CBH2BH.0CA@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680885411; a=rsa-sha256; cv=none; b=MEsEv2ZP/ynroDZ5adfxZInkDfRPWBF1IV2GfSU11ITUjWt2+/N4cMH2EHuK+M8GNoqf91 0ECtHgiiBAkUMk+zt9z9MZj9cl8rKz+XyY300pfQIeGdlxST3hgJ3ChkdyF/CnqnT39Lq5 gc77JFDYAwutmMpw4Jlo38pLNO/yXRA= Received: by mail-io1-f77.google.com with SMTP id z65-20020a6bc944000000b007584beb0e28so25990706iof.21 for ; Fri, 07 Apr 2023 09:36:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680885410; x=1683477410; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nplfd14bvjlVkVD4YGNhodAVpFm+bek0gQyvwM51NR0=; b=kzERedQ1yDmcJlTpbA0FUt9q8t9bTuFG9lVDj+5MuStKHSCRlDyG3SSbjBQ/NK4xk7 YSZFCEoRekmaZyX8qckTviKW/jwt5kVCOSDMQ+oQrxlqjQ7aBG0ExEgR3XHJGCWH5Z+l lCRASpAALZy7yjmKZMBXwXy+tZzxZJgzFM16zgkscEiAVbbwhiE/yZI8PkmLnTKe+x0R HJrcRmz58XOGVINqgWD09BXkOHrL772KfnN2xPhsSL8fANGUQHo1IjelB4tmWGw8REkI 4Vko0hF//bRUc+u/gOF/A8DygMyBMmJLE4SFU+qShrkGn//x0RQwsdolQIr8A4wGgU+Q N1Bw== X-Gm-Message-State: AAQBX9ejfRIZGR15PXrRFg1hlmVJec6B1YpxHVCd1uKpxOVEsB+hrSap 275V7vUIbYUe7RNzNpzNZGC/WCM9j+CKYSdyum6tK7NR/iz+ X-Google-Smtp-Source: AKy350Ypwj/ORNJEGLLCVhuTTM1jykqC3q048BwD2lOYvlDa+PTCUlHT9+a6a/qs4tbnzXfXtCHLEEOo+dBDrK9BkFUSaGqaExJz MIME-Version: 1.0 X-Received: by 2002:a02:b105:0:b0:3f6:e3c2:d4bd with SMTP id r5-20020a02b105000000b003f6e3c2d4bdmr616460jah.0.1680885409999; Fri, 07 Apr 2023 09:36:49 -0700 (PDT) Date: Fri, 07 Apr 2023 09:36:49 -0700 In-Reply-To: <000000000000c93feb05f87e24ad@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <000000000000c573b305f8c1a189@google.com> Subject: Re: [syzbot] [mm?] KASAN: slab-use-after-free Read in mas_next_entry From: syzbot To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E2DB34001F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 88e9ehauruopdskdiw9zpjmruge59mzg X-HE-Tag: 1680885410-794745 X-HE-Meta: U2FsdGVkX19Cl1FJPJlxEBt4f9tjXkXQWXPaoaSb/fAz4ydSD654aUOaIvNyNhEp0xQnO0MMA4sjagTS7m6hlaRsvNQOaKalAUQNoOfQyBbdsPQ++TncO8g/L5ZSH/byHk77VL3xwzhGJLIP/wLYqlFvg8Eegkv9bU/7MCBJSZcdpG9ZcDyGtX2/HWdnGwn8BKHFffl9+KwiTRFrFDkkRwsJFwZd7SrvVAdav1Eb4tQMAXd+o9CKf/53Xosuqi8haB81dZKDMY8qQj8x61pu9CGjCJkhzwq8We0J7NPXgkn8iiH1giR06o21nGO7lWDdDVzuNSaheajinh6AMXfltG9TTAO27U00E2rUqisINh52wficpY82kMhDyNwpEmzacMtnmTSJUJU8thtm5LQ6S4iRsGbkPT8iuWraBI1BvLfT7Y4khF5NxSrv6onCKDk09kVUHMD3ScdDIG1RICBCABMWwg53sUyFhRum6IZ781UBoYivPj7OQYQb9W2/z6ewGazxEazBIIcYeG9LqmMwqL8bMph0uuUH5OVQO7unYAWS/sm0jWUjC0td9g3k27Fsl0EBAMc5cDNzgJ6Hm2BJgYJEAE+4q7ioVoTZNzBuVt50sHFvPOgzxQomMnSlNKsk50qNwuFyOdeCjR20bNdNYsnqfRbpBY9nh4RNSCrVIqAfgo76eJ87nMgM7N0QppGa2MYpFAiKwr0ab7RzdvbTitE9aFMhZgsgPMqxpW4MFrVA+pWk9VKmikt/AU6emjzvChVyoNutUoe1O9iG6DznqY9eqOH/91fxiBs8XKAp+HxWXRKxKCJdHyB23ETRhIP+KsrG4BVZoiEehHRslL1MKhtjg75ljN4dQsGB+ImBPx+804YRQWyyvuPXqhC+wf/9jwIDpeOgeuBojv1Oy/lfHRQyo22ZGdlyFOhbeNTwzN84tM6k1KNywem+PZOuSSeeNZbx7nkI11jPhnuy95K Ya63k6Ez 1zhbupv8UhG2biNvwibcJsNkdDN19fAO7Fe0PF6og9K84l0kN96WOxdkPDm00oSRJQTgje9MaOl6FSRJ6MBN/6/CnmJgYn3TP80HzWLFEtg69lR65Im0YpvOVIRX5JBRYLMrEbgM7w51dHRP0Tj8IRcU8oji7uQ/ivxfDqbbpk5IF+afzBdO3fGAdy6SRqUUKZMNlnKTruaiTlG3yLQRX2a65Mjg8/GRZRo+MOJxPdfYZ1h0z0NBTu0qpaLyc1VcXisP3VdgSQekIVKProiIRarsKXz1ad1ALGH0gcIPnuS/RkC/Tg6dUQWBUJfuJdMRcjbTm6biCqjDMmHS2LzcL3b0z7ZsFd8/c8SMYPwJ5dr52UB3FhofkhXFAI3F52omsoNsQHe1TRqXsIjmX3ATSPVbWeeqxYJonyFw3Bqc3J5SO5WRSXvesb60vr0xjadZ7/Ew2caiwF6nGAIKTswIITbebSypZFpFh95OA6WwSxK+KAs+sz1+Vz5I7r/kOSxTNth6n2dC5Se4iEpBv93hiJjPoBOKQmwZaGgijwOUWod1g6lX1JtKUuzWoXxTZX/LyqSMO2IwrvgKOSiS8cke798azwHNZRK6Eq86vK8QD9YYpW9ZbXYIvzqpjt4Flm3j5LItps3qTS8vW5dQ0lOFvrr2r1tT5fea9Cv36PW0n9Q552Zee10wc/CMMOWxqj6XL5LBSY5TM4BB4JwKTmivanVCs9tlyIxNJ3OJCMXuMtrdxcge+AKTCl8aTDuE5biyaluLd1N7q/1JnWB7jmJJpR+O5WSl8UfLlz2SymxHVW4g98/g+zI+e9jo/pF1dVWLhP9O17nL1ZOvtD7mFzydkWDDhI8U5EEdUdle1OAaen7Uho5MK1frKrCiQ4bCPyKQ6kEcFOYB4JXb7RF2Hw1xQ0nGE9Kup2g1MBuTkBF8PM1kidOgDpL+mG6Mys0iHu1ioNJSt6ZBtf8ZCopLjV+IrHmHMEGrH dPLvISwI 2NcQXno9rS5a8jYgqyN6haLIhZA+POf52Syz55gc0qtrDQISCioKOk4MUW6/alRGdpKO7VhLwyLwlATn8bMjaxsygj8AXF4JbSbAwgW0OV8BAlhTPs8wdfH9FkNqj0yQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: syzbot has found a reproducer for the following issue on: HEAD commit: f2afccfefe7b Merge tag 'net-6.3-rc6-2' of git://git.kernel.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1642b49bc80000 kernel config: https://syzkaller.appspot.com/x/.config?x=d3500b143c204867 dashboard link: https://syzkaller.appspot.com/bug?extid=a7c1ec5b1d71ceaa5186 compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1033df79c80000 Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/4c6e0baeb7c2/disk-f2afccfe.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/82431f1611cf/vmlinux-f2afccfe.xz kernel image: https://storage.googleapis.com/syzbot-assets/82e1059905ee/bzImage-f2afccfe.xz IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+a7c1ec5b1d71ceaa5186@syzkaller.appspotmail.com ================================================================== BUG: KASAN: slab-use-after-free in mas_safe_min lib/maple_tree.c:727 [inline] BUG: KASAN: slab-use-after-free in mas_next_nentry lib/maple_tree.c:4664 [inline] BUG: KASAN: slab-use-after-free in mas_next_entry+0x12b3/0x1690 lib/maple_tree.c:4760 Read of size 8 at addr ffff8880782e0440 by task syz-executor.3/5331 CPU: 0 PID: 5331 Comm: syz-executor.3 Not tainted 6.3.0-rc5-syzkaller-00137-gf2afccfefe7b #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 print_address_description.constprop.0+0x2c/0x3c0 mm/kasan/report.c:319 print_report mm/kasan/report.c:430 [inline] kasan_report+0x11c/0x130 mm/kasan/report.c:536 mas_safe_min lib/maple_tree.c:727 [inline] mas_next_nentry lib/maple_tree.c:4664 [inline] mas_next_entry+0x12b3/0x1690 lib/maple_tree.c:4760 mas_find+0x7d/0x200 lib/maple_tree.c:6025 vma_find include/linux/mm.h:736 [inline] __do_sys_set_mempolicy_home_node+0x1ef/0x480 mm/mempolicy.c:1524 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f730dc8c169 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f730ea05168 EFLAGS: 00000246 ORIG_RAX: 00000000000001c2 RAX: ffffffffffffffda RBX: 00007f730ddabf80 RCX: 00007f730dc8c169 RDX: 0000000000000000 RSI: 0000000000003000 RDI: 0000000020ffd000 RBP: 00007f730dce7ca1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007f730decfb1f R14: 00007f730ea05300 R15: 0000000000022000 Allocated by task 5335: kasan_save_stack+0x22/0x40 mm/kasan/common.c:45 kasan_set_track+0x25/0x30 mm/kasan/common.c:52 __kasan_slab_alloc+0x7f/0x90 mm/kasan/common.c:328 kasan_slab_alloc include/linux/kasan.h:186 [inline] slab_post_alloc_hook mm/slab.h:769 [inline] kmem_cache_alloc_bulk+0x424/0x860 mm/slub.c:4034 mt_alloc_bulk lib/maple_tree.c:164 [inline] mas_alloc_nodes+0x276/0x8a0 lib/maple_tree.c:1263 mas_node_count_gfp lib/maple_tree.c:1318 [inline] mas_preallocate+0x1bb/0x360 lib/maple_tree.c:5717 vma_iter_prealloc mm/internal.h:972 [inline] __split_vma+0x1b7/0x810 mm/mmap.c:2177 do_vmi_align_munmap+0x34a/0xf60 mm/mmap.c:2320 do_vmi_munmap+0x26e/0x2c0 mm/mmap.c:2452 mmap_region+0x1ee/0x2620 mm/mmap.c:2500 do_mmap+0x831/0xf60 mm/mmap.c:1364 vm_mmap_pgoff+0x1af/0x280 mm/util.c:542 ksys_mmap_pgoff+0x41f/0x5a0 mm/mmap.c:1410 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd Freed by task 5331: kasan_save_stack+0x22/0x40 mm/kasan/common.c:45 kasan_set_track+0x25/0x30 mm/kasan/common.c:52 kasan_save_free_info+0x2e/0x40 mm/kasan/generic.c:521 ____kasan_slab_free mm/kasan/common.c:236 [inline] ____kasan_slab_free+0x160/0x1c0 mm/kasan/common.c:200 kasan_slab_free include/linux/kasan.h:162 [inline] slab_free_hook mm/slub.c:1781 [inline] slab_free_freelist_hook+0x8b/0x1c0 mm/slub.c:1807 slab_free mm/slub.c:3787 [inline] kmem_cache_free_bulk.part.0+0x20c/0x680 mm/slub.c:3905 mt_free_bulk lib/maple_tree.c:169 [inline] mas_destroy+0x3e0/0x650 lib/maple_tree.c:5771 mas_store_prealloc+0xf0/0x150 lib/maple_tree.c:5702 vma_iter_store mm/internal.h:1013 [inline] vma_complete+0xad9/0x1170 mm/mmap.c:572 __split_vma+0x523/0x810 mm/mmap.c:2214 split_vma+0xc6/0x110 mm/mmap.c:2242 mbind_range+0x4d2/0x760 mm/mempolicy.c:829 __do_sys_set_mempolicy_home_node+0x323/0x480 mm/mempolicy.c:1546 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd The buggy address belongs to the object at ffff8880782e0400 which belongs to the cache maple_node of size 256 The buggy address is located 64 bytes inside of freed 256-byte region [ffff8880782e0400, ffff8880782e0500) The buggy address belongs to the physical page: page:ffffea0001e0b800 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x782e0 head:ffffea0001e0b800 order:1 entire_mapcount:0 nr_pages_mapped:0 pincount:0 flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff) raw: 00fff00000010200 ffff8880124cd000 dead000000000122 0000000000000000 raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 1, migratetype Unmovable, gfp_mask 0x1d20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL), pid 5335, tgid 5329 (syz-executor.3), ts 114724293643, free_ts 114618496841 prep_new_page mm/page_alloc.c:2553 [inline] get_page_from_freelist+0x1190/0x2e20 mm/page_alloc.c:4326 __alloc_pages+0x1cb/0x4a0 mm/page_alloc.c:5592 alloc_pages+0x1aa/0x270 mm/mempolicy.c:2283 alloc_slab_page mm/slub.c:1851 [inline] allocate_slab+0x25f/0x390 mm/slub.c:1998 new_slab mm/slub.c:2051 [inline] ___slab_alloc+0xa91/0x1400 mm/slub.c:3193 __kmem_cache_alloc_bulk mm/slub.c:3952 [inline] kmem_cache_alloc_bulk+0x270/0x860 mm/slub.c:4027 mt_alloc_bulk lib/maple_tree.c:164 [inline] mas_alloc_nodes+0x276/0x8a0 lib/maple_tree.c:1263 mas_node_count_gfp lib/maple_tree.c:1318 [inline] mas_preallocate+0x1bb/0x360 lib/maple_tree.c:5717 vma_iter_prealloc mm/internal.h:972 [inline] __split_vma+0x1b7/0x810 mm/mmap.c:2177 do_vmi_align_munmap+0x34a/0xf60 mm/mmap.c:2320 do_vmi_munmap+0x26e/0x2c0 mm/mmap.c:2452 mmap_region+0x1ee/0x2620 mm/mmap.c:2500 do_mmap+0x831/0xf60 mm/mmap.c:1364 vm_mmap_pgoff+0x1af/0x280 mm/util.c:542 ksys_mmap_pgoff+0x41f/0x5a0 mm/mmap.c:1410 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 page last free stack trace: reset_page_owner include/linux/page_owner.h:24 [inline] free_pages_prepare mm/page_alloc.c:1454 [inline] free_pcp_prepare+0x5d5/0xa50 mm/page_alloc.c:1504 free_unref_page_prepare mm/page_alloc.c:3388 [inline] free_unref_page+0x1d/0x490 mm/page_alloc.c:3483 qlink_free mm/kasan/quarantine.c:168 [inline] qlist_free_all+0x6a/0x170 mm/kasan/quarantine.c:187 kasan_quarantine_reduce+0x192/0x220 mm/kasan/quarantine.c:294 __kasan_slab_alloc+0x63/0x90 mm/kasan/common.c:305 kasan_slab_alloc include/linux/kasan.h:186 [inline] slab_post_alloc_hook mm/slab.h:769 [inline] slab_alloc_node mm/slub.c:3452 [inline] slab_alloc mm/slub.c:3460 [inline] __kmem_cache_alloc_lru mm/slub.c:3467 [inline] kmem_cache_alloc+0x17c/0x3b0 mm/slub.c:3476 __mpol_dup+0x76/0x390 mm/mempolicy.c:2407 mpol_dup include/linux/mempolicy.h:88 [inline] vma_replace_policy mm/mempolicy.c:773 [inline] mbind_range+0x132/0x760 mm/mempolicy.c:839 __do_sys_set_mempolicy_home_node+0x323/0x480 mm/mempolicy.c:1546 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd Memory state around the buggy address: ffff8880782e0300: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff8880782e0380: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc >ffff8880782e0400: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff8880782e0480: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff8880782e0500: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ==================================================================