From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CAA0C46467 for ; Wed, 4 Jan 2023 07:45:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 196C7900002; Wed, 4 Jan 2023 02:45:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 145C68E0001; Wed, 4 Jan 2023 02:45:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01357900002; Wed, 4 Jan 2023 02:45:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E5CE38E0001 for ; Wed, 4 Jan 2023 02:45:18 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B226B16053A for ; Wed, 4 Jan 2023 07:45:18 +0000 (UTC) X-FDA: 80316331116.14.0549F18 Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by imf12.hostedemail.com (Postfix) with ESMTP id 27AB440002 for ; Wed, 4 Jan 2023 07:45:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf12.hostedemail.com: domain of 3jC61YwkbAOEVbcNDOOHUDSSLG.JRRJOHXVHUFRQWHQW.FRP@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.72 as permitted sender) smtp.mailfrom=3jC61YwkbAOEVbcNDOOHUDSSLG.JRRJOHXVHUFRQWHQW.FRP@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672818317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references; bh=rJ4W8/mmVdVrFQNvYsx/DMYr6reSTCisMPcgxKG9a3E=; b=EkRG3rhmCcEweC6RVkfYGuKoNq2P9rUh64ROHhYmA/GbLaRgcfiqp8ZXYZ5PnfmXKdO4sq CG+0G6CWXk9NQAWj3zRiyU7Lx2hYujPBDl09OU28jZ2vGJjrjG9qTcxBQgmarez5gnCJjD z1V1zv7MaT0rHry89sxJfyiem/ddd1I= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf12.hostedemail.com: domain of 3jC61YwkbAOEVbcNDOOHUDSSLG.JRRJOHXVHUFRQWHQW.FRP@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.166.72 as permitted sender) smtp.mailfrom=3jC61YwkbAOEVbcNDOOHUDSSLG.JRRJOHXVHUFRQWHQW.FRP@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672818317; a=rsa-sha256; cv=none; b=OV2eN2fvf4QviWhoGANHSAtEV8crpd7t03ynXQMqASaZuR35OTNxYFyqJpbOpkp4P7PKb9 daqHtA07hThz5xxbqutzzZ8CFZ69ZTSvzee1FlDktbAXB4fMAAeQCZcz1INqQ09Mx/qRzB 5huqad8ZwZPm3uyXs/2LTfU5hv6AIaQ= Received: by mail-io1-f72.google.com with SMTP id w18-20020a5d9cd2000000b006e32359d7fcso9331896iow.15 for ; Tue, 03 Jan 2023 23:45:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rJ4W8/mmVdVrFQNvYsx/DMYr6reSTCisMPcgxKG9a3E=; b=E1yZW/BUoqD/vZCfCTjV6af8UviGbP6Ar1O+3JSflyEJsk0LbpqW8edM3dRUe7U5Gm +CA9EtJdyD5LmD7q90zqdG5G2XhDW8ldhn97Nm7Ysg533oLTpic71VyknxRdoozF+8CB 9L+BnPS8D493GgSigNv7aRxzfXzjA7ur9KR0KaQzWJTt1d+rvDKbhpZ/0R0NGNRO7NbF 12Io9ZDlIr9fGqQtNhIEtrOIJHhxLxdDMN+rvZnuZ6ReT/kEQyN9A3nAXOy5vJ1IlrWT 8QMSVTlLvkHiluX6Gd60eXK2WqlBvCgUQpyZ9FBtstIHDnOsj2g9OOSJ5AjzRQ5/Z9Pb I1Kw== X-Gm-Message-State: AFqh2krKFMCN+dATotb5ksO7/VIN6OZgb3Uqwdaa57TpeJioClQ9+5nc l1UjCebcTv+idsKg1SqeuCJXDViTCwdvyJHUUwf6j4PwQcNi X-Google-Smtp-Source: AMrXdXvwVkZzng5C+4mgIQ68JLoEjHniOdUfoFXDLNJACOLxpO5H5li69Yq+KOnQHWVPVTeiZxT3qGrJ3R5yiNYWg4ya6Xq+pKB+ MIME-Version: 1.0 X-Received: by 2002:a02:9f97:0:b0:39d:7413:1ac1 with SMTP id a23-20020a029f97000000b0039d74131ac1mr2985730jam.75.1672818316311; Tue, 03 Jan 2023 23:45:16 -0800 (PST) Date: Tue, 03 Jan 2023 23:45:16 -0800 In-Reply-To: <20230104040132.4103-1-hdanton@sina.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <00000000000084839c05f16b5d95@google.com> Subject: Re: [syzbot] [gfs2?] INFO: task hung in freeze_super (3) From: syzbot To: agruenba@redhat.com, hdanton@sina.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, longman@redhat.com, penguin-kernel@i-love.sakura.ne.jp, rpeterso@redhat.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 27AB440002 X-Stat-Signature: c5mn1r9std8pxctjokcpjsyqnqi9b5ao X-HE-Tag: 1672818316-70906 X-HE-Meta: U2FsdGVkX19yXJ5U1m8QhdJ3phBR8S4IhnmhlpXoyr/vi1XIRdCa4of4WX0VjKnvqzu5+LtdTZORieoyx53VCeSMWsKwEntKtHyLVK2hPGlyOSKW/OLgCQvFI77G4ES1TxhrnUwxPqzwP8xtNWl6uuSDRS/RjkLaTT+aUAGaAXt0z67aH8zF5y2/vpqiL3jiQdnibhjM209oAUYqmL+bdd/q5peY1HSVVIQTVrupZ/0HnXqeFYHBB9vVBxRzxMftAF16dh1GXj35kTPjpxszEdgi8n+xfaOiKZUDxqyleYoXCxiMxhwDA79RLaMfIy6Pbm2Qn1muW1U6Wc3MXaESA4n+PzhuxTeFiGTg1IEi1dy4AEZuQFujRVf3fyxbhKvKejrRtze8OMcovSgevq3siXUNytXecmKY8EgM8ZlabWoWrzhAsLn75xG82/3K5Wz/pp4pEHnubguf9978SNjexmeHdS2ImrwpRl0v/xjWCANq2ToLo/YchqbHxisB8OSgFk20eT72PvNWON30PgXee14smZsblVCE+Lf9UFJP4GSEeaXCyplCkHplBw1DSRM8qvAq3o6m6hW+6+kY119KVm2GzVmmtQM3ngtbqOFsxO004znmu4qYbo9T9KW5Adt5PSkB2/GDQqztwbHz5XF3PIzTfoeCZLTls+c7aKUQlVYSzqS9WrzstmS2CZJQlPs0aYGbjWXgG2/hk9DqafDUCbkoKUo1Df5KTiLO9ve131unpGCGndagkVMVy+JmhgimjFIdwos5xIqd8FFxV1mNVPfAwylw0q6Ioel77Mb/RqUwyyOWPzjK4zd9/WrvziNyuNgakw6eLMkhfkt4P+vbFICv+qeEKToKT1dVFpTTY+fa8XpBqNj6yYLD2F5uqiXGG6qR4L17omoagsOkJdtJwxym2oENptuU1wIrdoLA03/JUd2hQm7umciJyN1zjPTPvOmjXqCE4awSjwN+9LP Kl0X0GbI WA9GWEnqVK50EsKGHGQT36O0pARypXguvxol3EhCB3UBb+ZRdqST3UQLh+LDgJXMubC38T3XqhtWJbbXMCXrYCV8K33GTYiH5aXjZmBKoRWN+ga5hOmujqDo2xjZ+ZoCmqROgi7XvpBgOdN0LPOcV40lY3j79Adybam9q4xzVxho9+Ffn5m/IAyIzpUv93HE79dxqgJdGGu8JlgzJ9R3cLaQeMIvCUfKGoZSwAQfYf2HC9FO6COt2+8VS/8oxzufLhzJjpgnfQ9bTE5MKGQNvXvvdb/wjEc5/RTepJ+FF4iqnUSuyLSKAUKSUl11Ph+SqVnPC9fJUyWClphw+922xdvSHsM5BCRmg3ae3foeApXwPCYQ2XvI/wAfl9XEQKRSL5+GuY6D+J6lnOki9QrMrWeC9trbuao/etXGFIVuxnMbPYjBCNOl8gvla5wcu7GPTKSxTHy376v1wzqXLK63mLmMA/l8INx/c+k2Hlqm4EpOFTfX5VGIAB7Qao3+KMkzlB3WV7pliCebvCMsoOrYTPi11IhijEf4lXSztLzsvzr5ICQ2DtAB/k62P0WFeFTzU7T98qTgdYIn2g48hnHN4bfWmxNtQvihAO7hCdRA/s+xQuUrYI5QbXLgOnX8eNjOUOCVPJbyi1itG+KoT/k1CYcm9tw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.105333, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: possible deadlock in freeze_super ====================================================== WARNING: possible circular locking dependency detected 6.2.0-rc2-syzkaller-00127-g69b41ac87e4a-dirty #0 Not tainted ------------------------------------------------------ kworker/1:1H/93 is trying to acquire lock: ffff88802666e0e0 (&type->s_umount_key#50){+.+.}-{3:3}, at: freeze_super+0x45/0x420 fs/super.c:1655 but task is already holding lock: ffffc90002587d00 ((work_completion)(&(&gl->gl_work)->work)){+.+.}-{0:0}, at: process_one_work+0x831/0xdb0 kernel/workqueue.c:2264 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 ((work_completion)(&(&gl->gl_work)->work)){+.+.}-{0:0}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 process_one_work+0x852/0xdb0 kernel/workqueue.c:2265 worker_thread+0xb14/0x1330 kernel/workqueue.c:2436 kthread+0x266/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 -> #1 ((wq_completion)glock_workqueue){+.+.}-{0:0}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __flush_workqueue+0x17c/0x16d0 kernel/workqueue.c:2809 gfs2_gl_hash_clear+0xa3/0x300 fs/gfs2/glock.c:2191 gfs2_put_super+0x862/0x8d0 fs/gfs2/super.c:627 generic_shutdown_super+0x130/0x310 fs/super.c:492 kill_block_super+0x79/0xd0 fs/super.c:1386 deactivate_locked_super+0xa7/0xf0 fs/super.c:332 cleanup_mnt+0x494/0x520 fs/namespace.c:1291 task_work_run+0x243/0x300 kernel/task_work.c:179 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0x124/0x150 kernel/entry/common.c:171 exit_to_user_mode_prepare+0xb2/0x140 kernel/entry/common.c:203 __syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline] syscall_exit_to_user_mode+0x26/0x60 kernel/entry/common.c:296 do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&type->s_umount_key#50){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_write+0x9c/0x270 kernel/locking/rwsem.c:1562 freeze_super+0x45/0x420 fs/super.c:1655 freeze_go_sync+0x178/0x340 fs/gfs2/glops.c:577 do_xmote+0x34d/0x13d0 fs/gfs2/glock.c:708 glock_work_func+0x2c2/0x450 fs/gfs2/glock.c:1056 process_one_work+0x877/0xdb0 kernel/workqueue.c:2289 worker_thread+0xb14/0x1330 kernel/workqueue.c:2436 kthread+0x266/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 other info that might help us debug this: Chain exists of: &type->s_umount_key#50 --> (wq_completion)glock_workqueue --> (work_completion)(&(&gl->gl_work)->work) Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock((work_completion)(&(&gl->gl_work)->work)); lock((wq_completion)glock_workqueue); lock((work_completion)(&(&gl->gl_work)->work)); lock(&type->s_umount_key#50); *** DEADLOCK *** 2 locks held by kworker/1:1H/93: #0: ffff888012bf7d38 ((wq_completion)glock_workqueue){+.+.}-{0:0}, at: process_one_work+0x7f2/0xdb0 #1: ffffc90002587d00 ((work_completion)(&(&gl->gl_work)->work)){+.+.}-{0:0}, at: process_one_work+0x831/0xdb0 kernel/workqueue.c:2264 stack backtrace: CPU: 1 PID: 93 Comm: kworker/1:1H Not tainted 6.2.0-rc2-syzkaller-00127-g69b41ac87e4a-dirty #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Workqueue: glock_workqueue glock_work_func Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1b1/0x290 lib/dump_stack.c:106 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_write+0x9c/0x270 kernel/locking/rwsem.c:1562 freeze_super+0x45/0x420 fs/super.c:1655 freeze_go_sync+0x178/0x340 fs/gfs2/glops.c:577 do_xmote+0x34d/0x13d0 fs/gfs2/glock.c:708 glock_work_func+0x2c2/0x450 fs/gfs2/glock.c:1056 process_one_work+0x877/0xdb0 kernel/workqueue.c:2289 worker_thread+0xb14/0x1330 kernel/workqueue.c:2436 kthread+0x266/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 Tested on: commit: 69b41ac8 Merge tag 'for-6.2-rc2-tag' of git://git.kern.. git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master console output: https://syzkaller.appspot.com/x/log.txt?x=154506dc480000 kernel config: https://syzkaller.appspot.com/x/.config?x=9babfdc3dd4772d0 dashboard link: https://syzkaller.appspot.com/bug?extid=f51cb4b9afbd87ec06f2 compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 patch: https://syzkaller.appspot.com/x/patch.diff?x=11d59a52480000