From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8DBC001E0 for ; Wed, 26 Jul 2023 08:31:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 961118D0002; Wed, 26 Jul 2023 04:31:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 912428D0001; Wed, 26 Jul 2023 04:31:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D96D8D0002; Wed, 26 Jul 2023 04:31:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6FDCA8D0001 for ; Wed, 26 Jul 2023 04:31:41 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 345C81A01E3 for ; Wed, 26 Jul 2023 08:31:41 +0000 (UTC) X-FDA: 81053094402.10.E0CB2E2 Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by imf03.hostedemail.com (Postfix) with ESMTP id 43E602001B for ; Wed, 26 Jul 2023 08:31:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf03.hostedemail.com: domain of 36tnAZAkbAM0BHI3t44xAt881w.z77z4xDBxAv76Cx6C.v75@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.167.200 as permitted sender) smtp.mailfrom=36tnAZAkbAM0BHI3t44xAt881w.z77z4xDBxAv76Cx6C.v75@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690360299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references; bh=slflnYARMxwAnq+FavnIYKl6DmQW8tiUJPb2+/rDk3A=; b=a/1OxbKjriSuLJ9j+PwCJJ5OJohYOIR7LbqEzlmoDO2gsAmGLuAIzF6SmI6CWXgkJKY3by I7OFPDc98Psn/HfVpnSiY+gOTxF+bzvmP+/NC+4ZiIP2dWGg8fmUM49QCVOY+InLr3+Ulo QZbT91Ln6kROKJ9+WdmhpgvFkHCfUG4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none); spf=pass (imf03.hostedemail.com: domain of 36tnAZAkbAM0BHI3t44xAt881w.z77z4xDBxAv76Cx6C.v75@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.167.200 as permitted sender) smtp.mailfrom=36tnAZAkbAM0BHI3t44xAt881w.z77z4xDBxAv76Cx6C.v75@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690360299; a=rsa-sha256; cv=none; b=2MmenqpRHSErvvhXJIkbCV19AUelDtJoFmqEQpWx/6cgmUzDw41g9Dv1FUDia2J8Er6R+z oYdTA0dycJgMMxfe36+yB7kAWqxbp1rEjCMmQWUpOEWW3QjJ/wRK44wZZkYVu3dsNxZx3l ToZ0HYBK+Hd+plZmCqreKKNUU0gON7c= Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-3a3c76a8accso13443581b6e.0 for ; Wed, 26 Jul 2023 01:31:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690360298; x=1690965098; h=cc:to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=slflnYARMxwAnq+FavnIYKl6DmQW8tiUJPb2+/rDk3A=; b=RyNe8cXE2b+GQVLgMUXmiW3Y7XOT7Hi9ud2WVlcRLK23SxTo+ynO0kTgtjBkSszr/Q a2wCf/jeiIu/m53nkMkTXyoCeRkTq3Lw1JHlbaKCTrvOvkNXV4bSvje6UX94tEzf1yF+ 6MmC2GoN+Lyje+sTkqcmb7oaTHqyTEXABSms/NZKQBOC6Z3Bv7CWalIp62AE97FkkRYi qmsniUOp9BhCASUbC7tQQKvxgXzRT4KN2DQo9KcFX0n5HWyElmNk3zXkITsuHb+DIaFR mHtqKUCWjeyz78uync4YdgwfO+5Zf6cIaQHIpXoxTBh00t3rSktNY6BUix1NrNFlrHBJ UPxw== X-Gm-Message-State: ABy/qLbbH8QoCXmfV1xDZTEJBsTf7R/uZY9HCnkOWPeS17GYkugwKFjm Vs7u2DUQxM3b2mE3WO/rZsUNdMSb61ifnARPwPE13Vxul/wG X-Google-Smtp-Source: APBJJlFYUBuOQF/tuNkWITjCD1yJ9cdtmXwBYAYkcPJa00a06PIjacYQ7Jtab9Img4k/etHtHTOMz3d4B9BuQjK4FAObANzpcvWg MIME-Version: 1.0 X-Received: by 2002:a05:6808:3008:b0:3a4:3bab:3d3 with SMTP id ay8-20020a056808300800b003a43bab03d3mr3383392oib.10.1690360298320; Wed, 26 Jul 2023 01:31:38 -0700 (PDT) Date: Wed, 26 Jul 2023 01:31:38 -0700 In-Reply-To: <125377.1690360290@warthog.procyon.org.uk> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <0000000000001fb79e06015fad1f@google.com> Subject: Re: [syzbot] [mm?] WARNING in try_grab_page From: syzbot To: dhowells@redhat.com Cc: akpm@linux-foundation.org, davem@davemloft.net, dhowells@redhat.com, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, svens@linux.ibm.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 43E602001B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: dud63p4hesoaqg678wtb89gmu8k5b6fz X-HE-Tag: 1690360299-588966 X-HE-Meta: U2FsdGVkX1+Hsirh6fCoC7y4ZECaJ1a3ZWTGW1RxlxuWKq5ZzoF5rtDTYC+4vrtA6etPyYzy+Eot1J/5oNJXfygxBRU9g2z2B6jgQJiOkgZg6sGsJuFeCYcQ6G36BUnCFak6G7HgssPRQDNTbwZD8SXbSTa1Nkt4pEbTXm1ZdtjFhy49QbR0pY0ogNPUrY47Ekf/fi9TZCGBbcOpyF8DAwZAjdqNfzr77G44Uf+fEPBahSFjYITxD3LIRxkqfkHLnFHRsIfh2qcvEvQ9ddAebbd8j6224+Ff1GS/Bqh7oRFBGXkNZyE6IZNnlmunlJJsC7nYpJTDjY+HbaLkhkkrbLpJhTaEFf6Gj9Zbp/QB36YeN1Qc1s1YPlkbgq3UYtoZzVImG/oG9HaPUT/UHqrJAjYuW3ovt9RHC2vanEUg4+hV4gSMx3OwkaNFcI/K9TFf8H58bxbK/6YB4ijfroqDmWVA+Go/l/fCkv+Js+N24g4hk/zWu7ZHCOG6hgby+Fl7EA23MmCFhHPctPSNdZqE1x0PZybEco5ZNxuRkQ89InT80g4z9enjKwbTVHdM8Tw0I2OlbeLSCw6Ju+NDLHH1S6FY9r3BJ6hZkOBtQxsZ7bjXzTyAfLwdjkLhUpT43q0cBIoqAvO+HZInfaKVnoQHgy4YhP9tkF0Q3bmHQgEcXlkhyP04ycUVMgg7sXBh3szjViKJUzGZjikLTWrO6kGI/QqsPrWvkzJeHxnZCBr9V/RyBvmu6fnB2cawfHvllJWFTPTi/p8d+375Htn1ss/J0VF/0mY8UqEu1HpIwVfET9xZh3DTrBo+uuAygijPSgq4bDcNGYKXXZWKF7n96iLHMdjSGFZqMRdqPtuWdyy9N5UBnPFaz5K3jmLnozcdfaaF67OET5UDwYxoFEqKEPyvcjezW9GUXBe3qIcax3gnVBc7E6wIOBJB6yroauKKjiIryttZLBCV0eyk9aE8RLX 1LDlIU79 UZ4yAlbrBHMGnRkq8/WIfCNSZao4HnLChE3pbQOFdDYOAOXft1kxSxQzzO/kIfAEeTWf0mgnkgYtkEP9FFPnVtCwPi8HDnxVyDjLBnFYvy56yMM7ce+vFix/gudi8lqJMtfjBP0CBS7JZJK92OlMWhH63/KcQiPicC6CHAAZXJGGznG0/PF0vTeBu6CwQ68nT0bMq6klWraGxS3ffdCaGHy73whJw4xdHEMzvvYjp08OpuIn9fwShK4+8QTB9LPNl4rwxeZPbex5blHNM/ESB2+70aAvr0Df9bC+zb9fm04J2zd5ZCP+KVN+CxdE8U9h0bIktvWhF+8496cMevm6CkbrYzzGjCB07hD+Gipv+IiZeJ96bhJ5Ny9+z+nQZkavBDJNKO5rxL+uLddDNe1pHuw+MJbXAvuPYHbDbqiRKqZ9I5Ixw8ZF2PBxdml1utKFKUuN0OEa/XUVzPybXbhzODUcfbCioECGCBfGv0bxsdSTvFWnFt1TjO3ZKQ4MXttUg/XRTcG+FHlxsiJfXBi4apmKPGMWmF64k1AmBx9dmABpXcZZVVBjAaHjztVF6jnmID2UMHnvOrCDg5/KsDnMtc/RxYQmZGLYRDf1ikCcaaC3vqUndgAbYltO70A2ji/7gZ9q6gJwI/ylc4xIiZDV/YKbjK0np9U7JT3AlHBzmVNBKcH/ItxcTbuW41SBcGj7fC48sV7nrN0w4JeS1Ox/a5MDaDPMHkvTXTQ9AohzwjCV/e1wmOj63PQ9IDZqV6cTJc1UQUG+AOlTLh0VotxVeW0PWB+z9qRnUemmiL9gyKlzgp6gypjwKlPHlP9zaFfsQy5V5vBtpEUCOkgHOVbaAfsq1jDNGEOeRg7F7F/6Dn6B+9ThdMCIXM6zAWsAU02jEJ709378tqX9FLNbJXHuDIHmcBlAytuy1I0yEdXZKj4Eptv3yhk3QyeJXP9fqOuiW7WQDeiJblYmCFQ6Tnj/xvinbblA/ 7JBdSLSs RVhTpbSVJu00cjwWwqLXU9Cqhu5V/rxVZ16KJcaW8zQ9Sd4J/7rvWBbCIqAiVSABH0RYZr7R8a6sKjjqeZRMgK2dOglNsDslTDYGtQKCRaKD8cCfGg7om8IpCZO2X6Sh/HnCUgsT9m8PAByo+cMT7funGC2q8R6KH5pxnFM19eMQkULbm5fRj1IyXKhGh8+6zhUi80m2TcuJdQ7wA9/POJ3P2fgwa7Pi1C6H9O/fOd1mlgWHwCAelpqA3N4bvi2QAN/q2/Y+Fx17Pr6Y+uimZRLBK/Y4NcGCSZ78k+lE9pPGBaVbO/ZeJWlarKGe9Ysm+KGHwgjDLT7d3/J1IgUS02Mm8lts/f4mALEH8DpbA+EngINi/vBfX1d+9PyLjNf2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master This crash does not have a reproducer. I cannot test it. > > lib/scatterlist: Fix error handling in extract_iter_to_sg() > > Fix the error handling in extract_iter_to_sg(). Pages need to be unpinned, > not put, and only if they actually got pinned (which is the case in > extract_user_to_sg()). > > The bug may result in a warning like the following: > > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 __lse_atomic_add arch/arm64/include/asm/atomic_lse.h:27 [inline] > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 arch_atomic_add arch/arm64/include/asm/atomic.h:28 [inline] > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 raw_atomic_add include/linux/atomic/atomic-arch-fallback.h:537 [inline] > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 atomic_add include/linux/atomic/atomic-instrumented.h:105 [inline] > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 try_grab_page+0x108/0x160 mm/gup.c:252 > ... > pc : try_grab_page+0x108/0x160 mm/gup.c:229 > lr : follow_page_pte+0x174/0x3e4 mm/gup.c:651 > ... > Call trace: > __lse_atomic_add arch/arm64/include/asm/atomic_lse.h:27 [inline] > arch_atomic_add arch/arm64/include/asm/atomic.h:28 [inline] > raw_atomic_add include/linux/atomic/atomic-arch-fallback.h:537 [inline] > atomic_add include/linux/atomic/atomic-instrumented.h:105 [inline] > try_grab_page+0x108/0x160 mm/gup.c:252 > follow_pmd_mask mm/gup.c:734 [inline] > follow_pud_mask mm/gup.c:765 [inline] > follow_p4d_mask mm/gup.c:782 [inline] > follow_page_mask+0x12c/0x2e4 mm/gup.c:839 > __get_user_pages+0x174/0x30c mm/gup.c:1217 > __get_user_pages_locked mm/gup.c:1448 [inline] > __gup_longterm_locked+0x94/0x8f4 mm/gup.c:2142 > internal_get_user_pages_fast+0x970/0xb60 mm/gup.c:3140 > pin_user_pages_fast+0x4c/0x60 mm/gup.c:3246 > iov_iter_extract_user_pages lib/iov_iter.c:1768 [inline] > iov_iter_extract_pages+0xc8/0x54c lib/iov_iter.c:1831 > extract_user_to_sg lib/scatterlist.c:1123 [inline] > extract_iter_to_sg lib/scatterlist.c:1349 [inline] > extract_iter_to_sg+0x26c/0x6fc lib/scatterlist.c:1339 > hash_sendmsg+0xc0/0x43c crypto/algif_hash.c:117 > sock_sendmsg_nosec net/socket.c:725 [inline] > sock_sendmsg+0x54/0x60 net/socket.c:748 > ____sys_sendmsg+0x270/0x2ac net/socket.c:2494 > ___sys_sendmsg+0x80/0xdc net/socket.c:2548 > __sys_sendmsg+0x68/0xc4 net/socket.c:2577 > __do_sys_sendmsg net/socket.c:2586 [inline] > __se_sys_sendmsg net/socket.c:2584 [inline] > __arm64_sys_sendmsg+0x24/0x30 net/socket.c:2584 > __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] > invoke_syscall+0x48/0x114 arch/arm64/kernel/syscall.c:52 > el0_svc_common.constprop.0+0x44/0xe4 arch/arm64/kernel/syscall.c:142 > do_el0_svc+0x38/0xa4 arch/arm64/kernel/syscall.c:191 > el0_svc+0x2c/0xb0 arch/arm64/kernel/entry-common.c:647 > el0t_64_sync_handler+0xc0/0xc4 arch/arm64/kernel/entry-common.c:665 > el0t_64_sync+0x19c/0x1a0 arch/arm64/kernel/entry.S:591 > > Fixes: 018584697533 ("netfs: Add a function to extract an iterator into a scatterlist") > Reported-by: syzbot+9b82859567f2e50c123e@syzkaller.appspotmail.com > Link: https://lore.kernel.org/linux-mm/000000000000273d0105ff97bf56@google.com/ > Signed-off-by: David Howells > cc: Sven Schnelle > cc: akpm@linux-foundation.org > cc: Herbert Xu > cc: "David S. Miller" > cc: Jeff Layton > cc: Steve French > cc: Shyam Prasad N > cc: Rohith Surabattula > cc: Jens Axboe > cc: Herbert Xu > cc: "David S. Miller" > cc: Eric Dumazet > cc: Jakub Kicinski > cc: Paolo Abeni > cc: Matthew Wilcox > cc: linux-mm@kvack.org > cc: linux-crypto@vger.kernel.org > cc: linux-cachefs@redhat.com > cc: linux-cifs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: netdev@vger.kernel.org > --- > lib/scatterlist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/scatterlist.c b/lib/scatterlist.c > index e86231a44c3d..c65566b4dc66 100644 > --- a/lib/scatterlist.c > +++ b/lib/scatterlist.c > @@ -1148,7 +1148,7 @@ static ssize_t extract_user_to_sg(struct iov_iter *iter, > > failed: > while (sgtable->nents > sgtable->orig_nents) > - put_page(sg_page(&sgtable->sgl[--sgtable->nents])); > + unpin_user_page(sg_page(&sgtable->sgl[--sgtable->nents])); > return res; > } >