From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 523CAC001DC for ; Thu, 27 Jul 2023 18:50:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D84606B0072; Thu, 27 Jul 2023 14:50:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D34C16B0074; Thu, 27 Jul 2023 14:50:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFBB66B0075; Thu, 27 Jul 2023 14:50:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AFDC86B0072 for ; Thu, 27 Jul 2023 14:50:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8B8A9405E0 for ; Thu, 27 Jul 2023 18:50:31 +0000 (UTC) X-FDA: 81058282662.06.438C5B8 Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) by imf18.hostedemail.com (Postfix) with ESMTP id B22121C001A for ; Thu, 27 Jul 2023 18:50:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of 3dLzCZAkbACUTZaLBMMFSBQQJE.HPPHMFVTFSDPOUFOU.DPN@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.160.71 as permitted sender) smtp.mailfrom=3dLzCZAkbACUTZaLBMMFSBQQJE.HPPHMFVTFSDPOUFOU.DPN@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690483829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references; bh=oSKGCew+LNfabW3yh1/xiFsSSUY3CKeeb05ZwnBCtJU=; b=qbovT3vdZ66mkt4N7X76pRSEGccrp2/x8pytft+0iYuuYRBM2+w9xZoQYpmKKm4sdNKLa7 EyR/ZsWUgpUFC8PjFRCCuQkdBRSt7I1F8Th+FATUMiszqk3cfkU/6h1jWys2ME6QclAfCP 8SYni1Q8hDHzZE6RfKA+oCUHudL/wTM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of 3dLzCZAkbACUTZaLBMMFSBQQJE.HPPHMFVTFSDPOUFOU.DPN@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com designates 209.85.160.71 as permitted sender) smtp.mailfrom=3dLzCZAkbACUTZaLBMMFSBQQJE.HPPHMFVTFSDPOUFOU.DPN@M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=appspotmail.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690483829; a=rsa-sha256; cv=none; b=OATHT2GIaD3BGMgzjNdbB1ajq5m4GEctWuVBhwtlDr03Atx2+pC8sKYL/RXEF7El5mNF00 3lfGQ9/COMLUmc9q5KRs28R+sDh3kNIcKFE1vIxfSRy8imYKct5R0Rqy2DS/ESthMbGHI9 DJQ6DqCWnFmeA84PJycri5dYKYCx46U= Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-187959a901eso2416420fac.0 for ; Thu, 27 Jul 2023 11:50:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690483829; x=1691088629; h=cc:to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oSKGCew+LNfabW3yh1/xiFsSSUY3CKeeb05ZwnBCtJU=; b=Cz1EQuz5J9NotX3H4SraFRcALdrt1aVu0gEE1H+1XZ31UuHOSnvYA3yV6f1kYHQYA4 nZJlEEz9MGbCaOmtdivkKZMkESA3BRY3htPZFDQftIul5HsgXeI8WzxeBLAHO7nt10BP T4D9TI2NsKSKUM1ehghsuzTS0Be/g+VQ/3Fz1jKAQBi9TIXLlkFrzHcXudMKXOPeU9zE H0GVdnda8/p7NAd/NqoIIzrRhTV1SeRPFZqGaFEzRf2/8DYG3NiRITDm/2smx6fjRRVV P+F7QGCl5BhF2KHK5cRvscQjsjMRzqVe+4407KKaHYBaR7UByUo85Z/aKc/Daa0gwi9R r1qA== X-Gm-Message-State: ABy/qLbb35gbVedkFjG4e1FOJ7ii+doTymRAgqNcYLh5LJdF1ucq0ZRb aauX77/eXDUBR2w/G0/ajELWV/tfzW+HsuSE8LYjQ5zelgxz X-Google-Smtp-Source: APBJJlE9iMzZ4f3wPhlPp8kdxaP2U4uEsqOvvW/15vs7hrkkBy1xr+3UP3+qyVFyGTtVIEStRTmIVEE4UL1+k0t+ubQdtfUUt03C MIME-Version: 1.0 X-Received: by 2002:a05:6870:5b16:b0:1bb:470c:901c with SMTP id ds22-20020a0568705b1600b001bb470c901cmr296245oab.7.1690483828929; Thu, 27 Jul 2023 11:50:28 -0700 (PDT) Date: Thu, 27 Jul 2023 11:50:28 -0700 In-Reply-To: X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <0000000000001f3ae506017c704b@google.com> Subject: Re: [syzbot] [mm?] WARNING: suspicious RCU usage in mas_walk (2) From: syzbot To: willy@infradead.org Cc: akpm@linux-foundation.org, liam.howlett@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, willy@infradead.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B22121C001A X-Rspam-User: X-Stat-Signature: cnh6rikxzithx5dn594gr46ygmm8xb4r X-Rspamd-Server: rspam01 X-HE-Tag: 1690483829-679432 X-HE-Meta: U2FsdGVkX19xD5u3EOc6dKzcLHxpjnHEjhFZTAEA/Tc0t8+xqFhAUZUND5NQGDTdIV2D4LixhxA+TXJmcjoM61UReAZ9Fm3ZIkpGDSkHNAcwMD8dBedYqhfO1c01EMRvgrbVrbTl0rlQDTaiDxAbdXKjqda9dbONwLNDpSQsyXUpeu9JKFZm06fwL+ZWj4n76zqMXTBDZICV2roJaBFNu5N07JVGfn6O0Q0DKuYpM3lAyzcOEu3p7u7ATlT6xg1e094kndMp1m3OY+CvIHgdq3WaMd5D5m5OYZ40/38Q84xIP6xo+DDOZNJSap8iwi1qGZEmDDxwWU4tmltegGDluIHCLI2DJeNF3+gcZemqm6ZJA4IVlVoHSf+gc0L9g/xQjktAPGDJ2aGwuNMFop1TDV4NTrknij931VWDSbWcQjRIOm9rv/Bfr4gXzXM9SaqAniqSVThtdxGCR821cHsyeB8zZgfH+uKIort8XhKqhpKggKuq6zpa69YKuAkp7zhv/H7/aJNwUHpcrnZaFA+gyFbgVwBqewn3j/k6lxHOypHfL/L+JQS5UPeFXbP5bpAwhCB27crkR1uvGvfcg/PHlJFb0UAdDmt89eUypRYHiYiQWgu2LSnLkR5z/np93OZHqavVuPbdiXOp693ahz9ozYZRfvKxlk6F8DaeHYZ9dMSN0GsZC0cFV8MllGjuHGf8lyrWfU9uIWWxexYdQHINqtQMZ9JRUx84GAYFTmpTH8C0fkKoEOf2QxqxJAQ7UqAfvQI5QDBuJFZEpKvGuchEMNiSkNaU6jj7myqyT4EuHqjm7cX1X9nGW+ZpcFcD7FmOwKzfcyKaQNPE/JTErBdS3ZE4MpM/4xVrx/ctZpCfO+xSgEREzjfdmS5Doe7xzsFEbZx4KBt4PVb7b/3NYRma+IL1LuolRKNwTbpD+PJfMT4tQfIdwp3xwE6pYBj0CPjmMn26Yg+qE6pJ7GnpLbl 0MpI7wwD mPqlyKdlqcViMI1Gn/No3nMyiGztfN5fL1AbPVj3fxWxm5Q3vAobpmhRIkr3AmCiw8Z2TFCxftHoA7jD4kpqPUx/IpdxwV6cEcFkDAa+zinCVMBwAj5/ZlzGwUKyaXZdblLqVmnrhLauEVlZUmef+kbqxMoGIsh1lOp3Bbvp1YQCrn43YBk36SGkw6EhIaZ7wwMTMocOOQW+RSAsrv6uj8bCpmsJnBUsHJmpSmQE8y0uEPTlvvjttlz9+dRKDfxseDfGVQZAP+17YkhAMQpU+t5wgcauYHQQl2rR2CVFdhonS8fYC2JdA7p206p48LVwLfhG/5l6oNxZkcrYsmmivMdYcC4B/QrSIOfpxBdzA15yXM5vrVmPdz8d7EoNFf6l6J9kKhz5cfqN4zTXZcFPdWvcsXKV3gcZYNIEMIXx69mydmo3RzGneUdGSSdaAXTwzptp23GkhX9WJx3AumQh4iAzLbwkgtGUJN2aLGfeJ6hJ3HULtA68qAxrEADpPgJMnOXE8JrSsPBDPAo+nHXUv/eGZSepgTG1oub85832wYZDNmHElm0LRhG+atD4C9x0xX6sVi8FXhR32ofFuYIlWqCI3IMsBxYilnYkj4H5DQezZ7VC66pgeYGQLKJ9ULFuNBH8rWALQoTsJJx1mXxOlzBU6JuVB5BU1KD39Tq2CMF7AfMAofzVNbZ3UzoeljxjLVOF+N5ZBhVZES3M8/ddCkk6TpCujQ4tN9wHaWxQapLJVRyATplAxwTJiMaSKbOgXY5hu1I87ce3VCHKapdZ18TBc0eD3fY81Y3B2rYSfNnv2DermUt8zqrh5qfDmgJPhPNiMl6TvDyR3L8N+Yq+2bmCTAHkQ+AQ5GlxtO/FIaMBgcfbfeRygE/wA7P20ddpTijj35SGRjFMczSbVZozW56t5O+9ZKDvSY87PFJlDyfC8YBLO0Ky1rIzskRSlTKV0hyQjbMD8vlSJFmtn/Ej7Nf//82t2 Atmn8SkK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Tue, Jul 25, 2023 at 11:57:22PM -0700, syzbot wrote: >> syzbot has bisected this issue to: > > FWIW, this is unrelated to the previous issue. It's the caller of > mas_walk() that has violated the locking constraints, and mas_walk() is > simply reporting the issue. Is there a way to get syzbot to understand > that it needs to unwind the call-stack further to decide who to blame? > >> commit a52f58b34afe095ebc5823684eb264404dad6f7b >> Author: Matthew Wilcox (Oracle) >> Date: Mon Jul 24 18:54:10 2023 +0000 >> >> mm: handle faults that merely update the accessed bit under the VMA lock >> >> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1783585ea80000 >> start commit: [unknown] >> git tree: linux-next >> final oops: https://syzkaller.appspot.com/x/report.txt?x=1443585ea80000 >> console output: https://syzkaller.appspot.com/x/log.txt?x=1043585ea80000 >> kernel config: https://syzkaller.appspot.com/x/.config?x=f481ab36ce878b84 >> dashboard link: https://syzkaller.appspot.com/bug?extid=8645fe63c4d22c8d27b8 >> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1697cec9a80000 >> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1566986ea80000 > > #syz test want 2 args (repo, branch), got 4 > > diff --git a/mm/memory.c b/mm/memory.c > index 20a2e9ed4aeb..57b271108bdc 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3567,6 +3567,12 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) > return 0; > } > copy: > + if ((vmf->flags & FAULT_FLAG_VMA_LOCK) && !vma->anon_vma) { > + pte_unmap_unlock(vmf->pte, vmf->ptl); > + vma_end_read(vmf->vma); > + return VM_FAULT_RETRY; > + } > + > /* > * Ok, we need to copy. Oh, well.. > */