linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: <linux-kernel@vger.kernel.org>, Peter Xu <peterx@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>,
	Christoph Hellwig <hch@lst.de>, Hugh Dickins <hughd@google.com>,
	Jan Kara <jack@suse.cz>, Jann Horn <jannh@google.com>,
	John Hubbard <jhubbard@nvidia.com>,
	Kirill Shutemov <kirill@shutemov.name>,
	Kirill Tkhai <ktkhai@virtuozzo.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	Linux-MM <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.com>,
	Oleg Nesterov <oleg@redhat.com>
Subject: [PATCH 0/2] Add a 'seqcount' between gup_fast and copy_page_range
Date: Fri, 23 Oct 2020 21:19:18 -0300	[thread overview]
Message-ID: <0-v1-281e425c752f+2df-gup_fork_jgg@nvidia.com> (raw)

As discussed and suggested by Linus use a seqcount like thing to close the
small race between gup_fast and copy_page_range.

Unfortunately the good suggestion to just use write_seqcount_begin() blows
up lockdep immediately due to the (new?) requirement that the write side
of seqcount be in a preempt disabled region. For this application it does
not seem like a good idea, nor is it necessary as we don't spin on retry.

So I open coded a similar construct. Don't like it, will redo this in some
other way if there is a better idea. Since seqcount seems to have this
property now, it also feels wrong to be the only place to use the raw_
functions specifically to avoid the lockdep checks and other parts of
seqcount on the read side.

This can go after the merge window. I was table to test it using two
threads, one forking and the other using ibv_reg_mr() to trigger GUP
fast. Modifying copy_page_range() to sleep made the window large enough to
reliably hit to test the logic.

Jason Gunthorpe (2):
  mm: reorganize internal_get_user_pages_fast()
  mm: prevent gup_fast from racing with COW during fork

 include/linux/mm_types.h |   6 +++
 kernel/fork.c            |   1 +
 mm/gup.c                 | 107 ++++++++++++++++++++++++---------------
 mm/memory.c              |  16 +++++-
 4 files changed, 87 insertions(+), 43 deletions(-)

-- 
2.28.0



             reply	other threads:[~2020-10-24  0:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-24  0:19 Jason Gunthorpe [this message]
2020-10-24  0:19 ` [PATCH 1/2] mm: reorganize internal_get_user_pages_fast() Jason Gunthorpe
2020-10-24  4:44   ` John Hubbard
2020-10-26 23:59     ` Jason Gunthorpe
2020-10-27  9:33     ` Jan Kara
2020-10-27  9:55       ` Christoph Hellwig
2020-10-28  6:00         ` John Hubbard
2020-10-27 13:15       ` Jason Gunthorpe
2020-10-28  6:00         ` John Hubbard
2020-10-28  6:05           ` John Hubbard
2020-10-24  0:19 ` [PATCH 2/2] mm: prevent gup_fast from racing with COW during fork Jason Gunthorpe
2020-10-24  5:19   ` John Hubbard
2020-10-24  5:31     ` John Hubbard
2020-10-26 23:49       ` Jason Gunthorpe
2020-10-27  0:14         ` Linus Torvalds
2020-10-27 11:32           ` Jason Gunthorpe
2020-10-27  0:35         ` John Hubbard
2020-10-27  7:32   ` John Hubbard
2020-11-02  3:25   ` [mm] e498078ae9: will-it-scale.per_thread_ops -1.4% regression kernel test robot
2020-10-24  5:14 ` [PATCH 0/2] Add a 'seqcount' between gup_fast and copy_page_range John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0-v1-281e425c752f+2df-gup_fork_jgg@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=hughd@google.com \
    --cc=jack@suse.cz \
    --cc=jannh@google.com \
    --cc=jhubbard@nvidia.com \
    --cc=kirill@shutemov.name \
    --cc=ktkhai@virtuozzo.com \
    --cc=leonro@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=oleg@redhat.com \
    --cc=peterx@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox