From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 8A68740A for ; Mon, 20 Jul 2015 12:35:45 +0000 (UTC) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D0F97176 for ; Mon, 20 Jul 2015 12:35:44 +0000 (UTC) Date: Mon, 20 Jul 2015 14:35:41 +0200 Message-ID: From: Takashi Iwai To: David Woodhouse In-Reply-To: <1437200277.11033.2.camel@infradead.org> References: <20150716094720.2bf9f5ac@gandalf.local.home> <55A7C7FE.6000604@sonymobile.com> <20150716094125.16cdda73@lwn.net> <1437063875.18768.59.camel@HansenPartnership.com> <20150717101151.5d5bc86d@lwn.net> <20150717133712.42c82add@gandalf.local.home> <20150717190223.GB1499@cloud> <20150717154326.6f129bc4@gandalf.local.home> <20150717202412.GA1856@cloud> <20150717163903.67747d86@gandalf.local.home> <20150717204856.GA2048@cloud> <1437200277.11033.2.camel@infradead.org> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Jason Cooper , "ksummit-discuss@lists.linuxfoundation.org" , James Bottomley , Dan Carpenter Subject: Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 18 Jul 2015 08:17:57 +0200, David Woodhouse wrote: > > On Fri, 2015-07-17 at 13:48 -0700, josh@joshtriplett.org wrote: > > On Fri, Jul 17, 2015 at 04:39:03PM -0400, Steven Rostedt wrote: > > > On Fri, 17 Jul 2015 13:24:12 -0700 josh@joshtriplett.org wrote: > > > > If your biggest hangup as a maintainer is that people send you patches > > > > that don't have variables sorted in some particular order, perhaps you > > > > should get out of kernel development and get into bike shed colorimetry > > > > consulting. We have enough problems getting quality patches by the > > > > metrics that *actually* correlate to quality. And as others have > > > > pointed out in this thread, many people produce patches across numerous > > > > subsystems. > > > > > > I personally don't have any issue with my own idiosyncrasies not being > > > met. They are usually minor, and I'll fix up the patch (and document it > > > in the change log). These minor idiosyncrasies make maintaining code > > > easier. > > > > That's perfectly reasonable. If you want to take the time making the > > code in your area conform to additional requirements above and beyond > > those of the kernel as a whole, go for it. I appreciate that you don't > > ask others to do it for you. > > I tend to do the same. I'll fairly consistently fix up (C) to ©, u to > µ, and found myself bitching at David Howells for using 'sec' instead > of § the other day. This far into the 21st century, there really isn't > any excuse for people not doing that, but I don't reject patches > because of it. A further off-topic note: these letters may still cause troubles even in the 21th century because of their width definition: East Asian Ambiguous. It can be rendered as a wide character depending on the system. So, if the comment text is written with the assumption of fixed width glyph, the alignment may be broken. Takashi