Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

[Takashi Iwai <tiwai@suse.de>]

On Sat, 18 Jul 2015 08:17:57 +0200,
David Woodhouse wrote:
> 
> On Fri, 2015-07-17 at 13:48 -0700, josh@joshtriplett.org wrote:
> > On Fri, Jul 17, 2015 at 04:39:03PM -0400, Steven Rostedt wrote:
> > > On Fri, 17 Jul 2015 13:24:12 -0700 josh@joshtriplett.org wrote:
> > > > If your biggest hangup as a maintainer is that people send you patches
> > > > that don't have variables sorted in some particular order, perhaps you
> > > > should get out of kernel development and get into bike shed colorimetry
> > > > consulting.  We have enough problems getting quality patches by the
> > > > metrics that *actually* correlate to quality.  And as others have
> > > > pointed out in this thread, many people produce patches across numerous
> > > > subsystems.
> > > 
> > > I personally don't have any issue with my own idiosyncrasies not being
> > > met. They are usually minor, and I'll fix up the patch (and document it
> > > in the change log). These minor idiosyncrasies make maintaining code
> > > easier.
> > 
> > That's perfectly reasonable.  If you want to take the time making the
> > code in your area conform to additional requirements above and beyond
> > those of the kernel as a whole, go for it.  I appreciate that you don't
> > ask others to do it for you.
> 
> I tend to do the same. I'll fairly consistently fix up (C) to ©, u to
> µ, and found myself bitching at David Howells for using 'sec' instead
> of § the other day. This far into the 21st century, there really isn't
> any excuse for people not doing that, but I don't reject patches
> because of it.

A further off-topic note: these letters may still cause troubles even
in the 21th century because of their width definition: East Asian
Ambiguous.  It can be rendered as a wide character depending on the
system.  So, if the comment text is written with the assumption of
fixed width glyph, the alignment may be broken.


Takashi