ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: jason@lakedaemon.net, ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [TOPIC] Metadata addendum to git commit
Date: Mon, 19 May 2014 15:29:55 +0200	[thread overview]
Message-ID: <s5hfvk5dhgs.wl%tiwai@suse.de> (raw)
In-Reply-To: <20140518.212315.1001026942354195075.chriscool@tuxfamily.org>

At Sun, 18 May 2014 21:23:15 +0200 (CEST),
Christian Couder wrote:
> 
> From: Takashi Iwai <tiwai@suse.de>
> >
> > At Thu, 15 May 2014 23:07:08 -0400,
> > Jason Cooper wrote:
> >> 
> >> Takashi,
> >> 
> >> On Tue, May 13, 2014 at 03:25:57PM +0200, Takashi Iwai wrote:
> >> > I think this has been already raised a few times, but I'm still
> >> > dreaming one thing in our git management: having some metadata
> >> > collection / link for each commit.
> >> > 
> >> > I don't mean for a thing like post-commit sign-off, but rather for
> >> > tracking the information that has been revealed after commit, e.g. a
> >> > regression the commit causes, the later fix commit, 
> >> 
> >> For the stuff flying by me, I've been adding the:
> >> 
> >> Fixes: <12-char hash>: ('Offending patch subject')
> >> 
> >> On patches fixing a regression.  It helps the stable team (when Cc
> >> stable is also added) and in your scenario, you could grep the commits
> >> for the result of your bisect.
> > 
> > Yeah, that was suggested in the last year's KS, and helps some cases.
> > 
> > However, the problem is that people(*1) often notice this too late
> > after the tree has been already published.  Also, some information
> > (e.g. bug reports) can come only after commits.
> 
> It is possible to use "git notes" or even "git replace" to add
> information to existing commits.

Yes, I know of git-notes, as already mentioned in the first post.  But
the problem is that publishing and importing git-notes changes isn't
well established for kernel git tree management.  And, IIRC, Linus
didn't like its usage somehow.  Not sure whether it's because of
git-notes technical design or its concept...

> > (*1) statistics taken from one person :)
> > 
> > And, for bisection, we need some reverse mapping for efficiency.
> > It'd take time to look all commit logs from each revlist, especially
> > if the bisection is done for the early history.
> > 
> > I tried a hackish way once ago: keeping simple text files named with
> > $SHAID in a separate branch, and refers to it at git log or bisect
> > time.  There must be much elegant way, I suppose, though.
> 
> Yeah, using "git replace" is more elegant. And there will be hopefully
> soon the --edit option that will make it very easy to use git replace.

We don't want to change the history at all.  A preferred option is
just addendum on top of the existing commits, and the way to easily
share the change (at best with the normal git pull).  If git-replace
provides such a good integration, I'd love to see it in our use case.


thanks,

Takashi

  parent reply	other threads:[~2014-05-19 13:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 13:25 Takashi Iwai
2014-05-13 23:23 ` NeilBrown
2014-05-13 23:29   ` Jiri Kosina
2014-05-13 23:49     ` NeilBrown
2014-05-14  1:40 ` Li Zefan
2014-05-16  3:07 ` Jason Cooper
2014-05-16  5:12   ` Christian Couder
2014-05-16  9:24   ` Li Zefan
2014-05-16  9:33   ` Takashi Iwai
2014-05-18 19:23     ` Christian Couder
2014-05-18 22:12       ` Jason Cooper
2014-05-19  6:34         ` Christian Couder
2014-05-19 13:29       ` Takashi Iwai [this message]
2014-05-20  6:37         ` Christian Couder
2014-05-20  7:06           ` Takashi Iwai
2014-05-21  5:36             ` Christian Couder
2014-05-22  4:49     ` Christian Couder
2014-05-22  5:58       ` Takashi Iwai
2014-05-22  6:28         ` Johan Herland
2014-05-22  6:52           ` Christian Couder
2014-05-22  7:29             ` Johan Herland
2014-05-22  7:45           ` Takashi Iwai
2014-05-22  7:49             ` Geert Uytterhoeven
2014-05-22  8:03               ` Takashi Iwai
2014-05-22 15:51       ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfvk5dhgs.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=chriscool@tuxfamily.org \
    --cc=jason@lakedaemon.net \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox