ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jason Cooper <jason@lakedaemon.net>
Cc: ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [TOPIC] Metadata addendum to git commit
Date: Fri, 16 May 2014 11:33:52 +0200	[thread overview]
Message-ID: <s5h1tvuf4ov.wl%tiwai@suse.de> (raw)
In-Reply-To: <20140516030708.GV27822@titan.lakedaemon.net>

At Thu, 15 May 2014 23:07:08 -0400,
Jason Cooper wrote:
> 
> Takashi,
> 
> On Tue, May 13, 2014 at 03:25:57PM +0200, Takashi Iwai wrote:
> > I think this has been already raised a few times, but I'm still
> > dreaming one thing in our git management: having some metadata
> > collection / link for each commit.
> > 
> > I don't mean for a thing like post-commit sign-off, but rather for
> > tracking the information that has been revealed after commit, e.g. a
> > regression the commit causes, the later fix commit, 
> 
> For the stuff flying by me, I've been adding the:
> 
> Fixes: <12-char hash>: ('Offending patch subject')
> 
> On patches fixing a regression.  It helps the stable team (when Cc
> stable is also added) and in your scenario, you could grep the commits
> for the result of your bisect.

Yeah, that was suggested in the last year's KS, and helps some cases.

However, the problem is that people(*1) often notice this too late
after the tree has been already published.  Also, some information
(e.g. bug reports) can come only after commits.

(*1) statistics taken from one person :)

And, for bisection, we need some reverse mapping for efficiency.
It'd take time to look all commit logs from each revlist, especially
if the bisection is done for the early history.

I tried a hackish way once ago: keeping simple text files named with
$SHAID in a separate branch, and refers to it at git log or bisect
time.  There must be much elegant way, I suppose, though.

> > or a bugzilla or
> 
> Sorry, I don't use it.
> 
> > ML link for the further discussion or debugging session.
> 
> We've also been autogenerating a tag:
> 
> Link: https://lkml.kernel.org/r/<Message-Id>
> 
> For all patches that points to the email the patch came from.  Not
> exactly what you were looking for, but nothing prevents someone from
> replying to that thread a year later with a regression report.
> 
> I've also been contemplating adding
> 
> Coverletter: https://lkml.kernel.org/r/<First Reference Msg-Id>
> 
> for large series where the patch submitter has done a thorough writeup
> in the coverletter.

Yes, this kind of information is helpful for checking patches at later
point, indeed.


thanks,

Takashi

  parent reply	other threads:[~2014-05-16  9:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 13:25 Takashi Iwai
2014-05-13 23:23 ` NeilBrown
2014-05-13 23:29   ` Jiri Kosina
2014-05-13 23:49     ` NeilBrown
2014-05-14  1:40 ` Li Zefan
2014-05-16  3:07 ` Jason Cooper
2014-05-16  5:12   ` Christian Couder
2014-05-16  9:24   ` Li Zefan
2014-05-16  9:33   ` Takashi Iwai [this message]
2014-05-18 19:23     ` Christian Couder
2014-05-18 22:12       ` Jason Cooper
2014-05-19  6:34         ` Christian Couder
2014-05-19 13:29       ` Takashi Iwai
2014-05-20  6:37         ` Christian Couder
2014-05-20  7:06           ` Takashi Iwai
2014-05-21  5:36             ` Christian Couder
2014-05-22  4:49     ` Christian Couder
2014-05-22  5:58       ` Takashi Iwai
2014-05-22  6:28         ` Johan Herland
2014-05-22  6:52           ` Christian Couder
2014-05-22  7:29             ` Johan Herland
2014-05-22  7:45           ` Takashi Iwai
2014-05-22  7:49             ` Geert Uytterhoeven
2014-05-22  8:03               ` Takashi Iwai
2014-05-22 15:51       ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h1tvuf4ov.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=jason@lakedaemon.net \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox