ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <clm@meta.com>
To: Kees Cook <kees@kernel.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
	ksummit@lists.linux.dev, Dan Carpenter <dan.carpenter@linaro.org>,
	Alexei Starovoitov <ast@kernel.org>
Subject: Re: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools
Date: Wed, 8 Oct 2025 21:37:57 -0400	[thread overview]
Message-ID: <fbea6c1d-8598-405c-a3e8-cc1253384308@meta.com> (raw)
In-Reply-To: <202510081355.99CCDF8A8C@keescook>

On 10/8/25 5:08 PM, Kees Cook wrote:
> On Wed, Oct 08, 2025 at 02:04:26PM -0400, Chris Mason wrote:
>> Claude really needs aggressive use of checklists to get it to stay
>> focused, other AIs may need other tricks.
> 
> So very very true. "I did the high priority stuff; I'm finished now".
> 
> Your prompts are very detailed! Have you been able to use a feedback loop
> at all to have it update its own prompts to help you clarify its results?

Yeah, I started with a very basic prompt and ran it through ~300 Fixes:
tagged patches with known bugs.  So I had the buggy patch and the fix,
and I'd have AI review the bad patch and then ask it to compare the
review against the known regression.

If the review failed, I'd ask it to fix the prompt in a generic way to
find the bug.  The prompts would grow and grow and then I'd ask AI to
streamline them.  I did those iterations a few times and fixed things up
as it went.

The false positive detection was more manual, that was mostly me asking
claude which part of the prompt made it flag something, and then either
fixing that part of the prompt or adding onto the false positive guide.

> I've found that pretty helpful for development-oriented prompting. i.e.
> "Compare the foo.md file to what you now know about the foo process
> and update it to reflect anything that needs to be added, removed,
> or changed."
> 
> Additionally, have you been able to build any patterns from existing
> bugs? The "Pattern ID" stuff feels like you built this from specific
> instances?
> 
> I'm really curious if the "CONTEXT MANAGEMENT" section actually works? I
> never considered tell it to discard specific context like you have,
> "Discard non-essential details after each phase to manage token limits"
> I'm going to try that immediately -- I just have to figure out how to
> give it, uh, context about the context I want dropped.
I don't actually know...I asked claude if it helped and it said yes, but
claude blows a lot of sunshine about how smart your prompts are.

> 
> And the semcode MCP sounds very interesting! I look forward to finding
> out more about that. :)
> 
> Awesome!
Glad it looks useful, please let me know what bugs you find!

-chris

  reply	other threads:[~2025-10-09  1:38 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 17:04 Chris Mason
2025-10-08 17:20 ` Konstantin Ryabitsev
2025-10-08 18:11   ` Sasha Levin
2025-10-08 18:35   ` Chris Mason
2025-10-08 17:57 ` Bart Van Assche
2025-10-08 18:04   ` Chris Mason
2025-10-08 18:14     ` Bart Van Assche
2025-10-08 18:42       ` Chris Mason
2025-10-08 21:08     ` Kees Cook
2025-10-09  1:37       ` Chris Mason [this message]
2025-10-08 18:33 ` Sasha Levin
2025-10-09  1:43   ` Chris Mason
2025-10-09 14:49     ` Paul E. McKenney
2025-10-08 19:08 ` Andrew Lunn
2025-10-08 19:28   ` Arnaldo Carvalho de Melo
2025-10-08 19:33     ` Laurent Pinchart
2025-10-08 19:39       ` Arnaldo Carvalho de Melo
2025-10-08 20:29         ` Andrew Lunn
2025-10-08 20:53           ` Mark Brown
2025-10-09  9:37         ` Laurent Pinchart
2025-10-09 12:48           ` Arnaldo Carvalho de Melo
2025-10-08 19:29   ` Laurent Pinchart
2025-10-08 19:50     ` Bird, Tim
2025-10-08 20:30       ` Sasha Levin
2025-10-09 12:32         ` Arnaldo Carvalho de Melo
2025-10-08 20:30       ` James Bottomley
2025-10-08 20:38         ` Bird, Tim
2025-10-08 22:21           ` Jiri Kosina
2025-10-09  9:14           ` Laurent Pinchart
2025-10-09 10:03             ` Chris Mason
2025-10-10  7:54               ` Laurent Pinchart
2025-10-10 11:40                 ` James Bottomley
2025-10-10 11:53                   ` Laurent Pinchart
2025-10-10 14:21                     ` Steven Rostedt
2025-10-10 14:35                   ` Bird, Tim
2025-10-09 14:30             ` Steven Rostedt
2025-10-09 14:51               ` Andrew Lunn
2025-10-09 15:05                 ` Steven Rostedt
2025-10-10  7:59                 ` Laurent Pinchart
2025-10-10 14:15                   ` Bird, Tim
2025-10-10 15:07                     ` Joe Perches
2025-10-10 16:01                       ` checkpatch encouragement improvements (was RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools) Bird, Tim
2025-10-10 17:11                         ` Rob Herring
2025-10-10 17:33                           ` Arnaldo Carvalho de Melo
2025-10-10 19:21                           ` Joe Perches
2025-10-10 16:11                       ` [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Steven Rostedt
2025-10-10 16:47                         ` Joe Perches
2025-10-10 17:42                           ` Steven Rostedt
2025-10-11 10:28                         ` Mark Brown
2025-10-09 16:31               ` Chris Mason
2025-10-09 17:19                 ` Arnaldo Carvalho de Melo
2025-10-09 17:24                   ` Arnaldo Carvalho de Melo
2025-10-09 17:31                     ` Alexei Starovoitov
2025-10-09 17:47                       ` Arnaldo Carvalho de Melo
2025-10-09 18:42                     ` Chris Mason
2025-10-09 18:56                       ` Linus Torvalds
2025-10-10 15:52                         ` Mauro Carvalho Chehab
2025-10-09 14:47             ` Bird, Tim
2025-10-09 15:11               ` Andrew Lunn
2025-10-09 17:58               ` Mark Brown
2025-10-09  1:15         ` Chris Mason
2025-10-08 20:37     ` Andrew Lunn
2025-10-09 12:40       ` Arnaldo Carvalho de Melo
2025-10-09 14:52 ` Paul E. McKenney
2025-10-10  3:08 ` Krzysztof Kozlowski
2025-10-10 14:12   ` Chris Mason
2025-10-31 16:51   ` Stephen Hemminger
2025-10-14  7:16 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbea6c1d-8598-405c-a3e8-cc1253384308@meta.com \
    --to=clm@meta.com \
    --cc=ast@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=dan.carpenter@linaro.org \
    --cc=kees@kernel.org \
    --cc=ksummit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox