From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BED3C4CECB for ; Thu, 12 Sep 2019 11:36:26 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FECF20693 for ; Thu, 12 Sep 2019 11:36:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FECF20693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ksummit-discuss-bounces@lists.linuxfoundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A15DDD94; Thu, 12 Sep 2019 11:36:25 +0000 (UTC) Received: from smtp2.linuxfoundation.org (smtp2.linux-foundation.org [172.17.192.36]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E7F52D91 for ; Thu, 12 Sep 2019 11:36:24 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by smtp2.linuxfoundation.org (Postfix) with ESMTPS id 644601DAA7 for ; Thu, 12 Sep 2019 11:36:24 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave02.hostedemail.com (Postfix) with ESMTP id 926D218012B52 for ; Thu, 12 Sep 2019 10:18:10 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id D459A18225E0D; Thu, 12 Sep 2019 10:18:07 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: body44_46c106f754330 X-Filterd-Recvd-Size: 2921 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Thu, 12 Sep 2019 10:18:06 +0000 (UTC) Message-ID: From: Joe Perches To: Miguel Ojeda , Dan Williams Date: Thu, 12 Sep 2019 03:18:04 -0700 In-Reply-To: References: <156821692280.2951081.18036584954940423225.stgit@dwillia2-desk3.amr.corp.intel.com> <156821693963.2951081.11214256396118531359.stgit@dwillia2-desk3.amr.corp.intel.com> <20190911184332.GL20699@kadam> <9132e214-9b57-07dc-7ee2-f6bc52e960c5@kernel.dk> User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Cc: Dave Jiang , ksummit , linux-nvdimm , Vishal Verma , Linux Kernel Mailing List , bpf@vger.kernel.org, Dan Carpenter Subject: Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile X-BeenThere: ksummit-discuss@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ksummit-discuss-bounces@lists.linuxfoundation.org Errors-To: ksummit-discuss-bounces@lists.linuxfoundation.org On Thu, 2019-09-12 at 10:24 +0200, Miguel Ojeda wrote: > On Thu, Sep 12, 2019 at 9:43 AM Dan Williams wrote: > > Now I come to find that CodingStyle has settled on clang-format (in > > the last 15 months) as the new standard which is a much better answer > > to me than a manually specified style open to interpretation. I'll > > take a look at getting libnvdimm converted over. > > Note that clang-format cannot do everything as we want within the > kernel just yet, but it is a close enough approximation -- it is near > the point where we could simply agree to use it and stop worrying > about styling issues. However, that would mean everyone needs to have > a recent clang-format available, which I think is the biggest obstacle > at the moment. I don't think that's close to true yet for clang-format. For instance: clang-format does not do anything with missing braces, or coalescing multi-part strings, or any number of other nominal coding style defects like all the for_each macros, aligning or not aligning columnar contents appropriately, etc... clang-format as yet has no taste. I believe it'll take a lot of work to improve it to a point where its formatting is acceptable and appropriate. An AI rather than a table based system like clang-format is more likely to be a real solution, but training that AI isn't a thing that I want to do. _______________________________________________ Ksummit-discuss mailing list Ksummit-discuss@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss