Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Keeping reviews meaningful

[Randy Dunlap <rdunlap@infradead.org>]

On 7/16/19 3:27 PM, Thomas Gleixner wrote:
> On Tue, 16 Jul 2019, Olof Johansson wrote:
>> On Tue, Jul 16, 2019 at 2:16 PM Wolfram Sang <wsa@the-dreams.de> wrote:
>>>
>>>
>>>> Even if we agree on a set of new tags the usage will still be based on
>>>> individual interpretation, which brings us back to square one.
>>>
>>> I agree. New tags won't help us much.
>>>
>>>> So no, let's just accept that these things are subjective and apply common
>>>> sense to make the best use of them.
>>>
>>> I meanwhile do think, though, that for "best use" it will be helpful to
>>> add my Rev-by to my SoB when I really did a full review (and not just
>>> trusted other reviewers). To properly document the process of a patch.
>>
>> I don't see how this is bringing much value. You picked up the patch,
>> and if you did so without looking closely at it, the end result is the
>> same: You're likely to be on the line for dealing with issues.
>>
>> The only thing a "S-o-b" without "R-b" would bring is "It's not my
>> fault that stuff broke" -- but it still is since your name is on it,
>> and that's not something that adds value for the project as a whole.
> 
> Right, if you commit it then you are responsible for it. It does not matter
> whether you reviewed it yourself or relied on someone else review.

It's a bit amazing (and scary) that this is even being discussed (as though
it's unknown) after these many years.

-- 
~Randy