From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chris Mason <clm@meta.com>,
ksummit@lists.linux.dev, Dan Carpenter <dan.carpenter@linaro.org>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools
Date: Fri, 10 Oct 2025 05:08:47 +0200 [thread overview]
Message-ID: <be5094b9-fb20-462e-ad2f-2b58e520b949@kernel.org> (raw)
In-Reply-To: <fc05f97b-1257-4dee-966f-ba66fff8aef1@meta.com>
On 08/10/2025 19:04, Chris Mason wrote:
> Hi everyone,
>
> Depending on how you look at things, this is potentially a topic for
> either MS or KS.
>
> One way to lower the load on maintainers is to make it easier for
> contributors to send higher quality patches, and to catch errors before
> they land in various git trees.
>
> Along those lines, when the AI code submission thread started over the
> summer, I decided to see if it was possible to get reasonable code
> reviews out of AI.
>
> There are certainly false positives, but Alexei and the BPF developers
> wired up my prompts into the BPF CI, and you can find the results in
> their github CI. Everything in red is a bug the AI review found:
>
> https://github.com/kernel-patches/bpf/actions/workflows/ai-code-review.yml
>
> My goal for KS/MS is to discuss how to enable maintainers to use review
> automation tools to lower their workload. I don't want to build new CI
> here, so the goal would be enabling integration with existing CI.
>
> My question for everyone is what would it take to make all of this
> useful? I'm working on funding for API access, so hopefully that part
> won't be a problem.
>
> There's definitely overlap between the bugs I'm finding and the bugs Dan
> Carpenter finds, so I'm hoping he and I can team up as well.
>
> In terms of actual review details, the reviews have two parts:
>
> 1) The review prompts. These are stand alone and can just work on any
> kernel tree. This is what BPF CI is currently using:
>
> https://github.com/masoncl/review-prompts/
>
> These prompts can also debug oopsen or syzbot reports (with varying
> success).
In general, I like this entire idea a lot, because I believe it could
drop many style or trivial review points, including obsolete/older code
patterns.
Qualcomm is trying to do something similar internally and they published
their code as well:
https://github.com/qualcomm/PatchWise/tree/main/patchwise/patch_review/ai_review
Different AI engines can be plugged, which solves some of the concerns
in this thread that some are expected to use employer's AI.
They run that instance of bot internally on all patches BEFORE posting
upstream, however that bot does not have yet AI-review enabled, maybe
because of too many false positives?
I also think this might be very useful tool for beginners to get
accustomed to kernel style of commit msgs and how the patch is supposed
to look like.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-10 3:08 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 17:04 Chris Mason
2025-10-08 17:20 ` Konstantin Ryabitsev
2025-10-08 18:11 ` Sasha Levin
2025-10-08 18:35 ` Chris Mason
2025-10-08 17:57 ` Bart Van Assche
2025-10-08 18:04 ` Chris Mason
2025-10-08 18:14 ` Bart Van Assche
2025-10-08 18:42 ` Chris Mason
2025-10-08 21:08 ` Kees Cook
2025-10-09 1:37 ` Chris Mason
2025-10-08 18:33 ` Sasha Levin
2025-10-09 1:43 ` Chris Mason
2025-10-09 14:49 ` Paul E. McKenney
2025-10-08 19:08 ` Andrew Lunn
2025-10-08 19:28 ` Arnaldo Carvalho de Melo
2025-10-08 19:33 ` Laurent Pinchart
2025-10-08 19:39 ` Arnaldo Carvalho de Melo
2025-10-08 20:29 ` Andrew Lunn
2025-10-08 20:53 ` Mark Brown
2025-10-09 9:37 ` Laurent Pinchart
2025-10-09 12:48 ` Arnaldo Carvalho de Melo
2025-10-08 19:29 ` Laurent Pinchart
2025-10-08 19:50 ` Bird, Tim
2025-10-08 20:30 ` Sasha Levin
2025-10-09 12:32 ` Arnaldo Carvalho de Melo
2025-10-08 20:30 ` James Bottomley
2025-10-08 20:38 ` Bird, Tim
2025-10-08 22:21 ` Jiri Kosina
2025-10-09 9:14 ` Laurent Pinchart
2025-10-09 10:03 ` Chris Mason
2025-10-10 7:54 ` Laurent Pinchart
2025-10-10 11:40 ` James Bottomley
2025-10-10 11:53 ` Laurent Pinchart
2025-10-10 14:21 ` Steven Rostedt
2025-10-10 14:35 ` Bird, Tim
2025-10-09 14:30 ` Steven Rostedt
2025-10-09 14:51 ` Andrew Lunn
2025-10-09 15:05 ` Steven Rostedt
2025-10-10 7:59 ` Laurent Pinchart
2025-10-10 14:15 ` Bird, Tim
2025-10-10 15:07 ` Joe Perches
2025-10-10 16:01 ` checkpatch encouragement improvements (was RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools) Bird, Tim
2025-10-10 17:11 ` Rob Herring
2025-10-10 17:33 ` Arnaldo Carvalho de Melo
2025-10-10 19:21 ` Joe Perches
2025-10-10 16:11 ` [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Steven Rostedt
2025-10-10 16:47 ` Joe Perches
2025-10-10 17:42 ` Steven Rostedt
2025-10-11 10:28 ` Mark Brown
2025-10-09 16:31 ` Chris Mason
2025-10-09 17:19 ` Arnaldo Carvalho de Melo
2025-10-09 17:24 ` Arnaldo Carvalho de Melo
2025-10-09 17:31 ` Alexei Starovoitov
2025-10-09 17:47 ` Arnaldo Carvalho de Melo
2025-10-09 18:42 ` Chris Mason
2025-10-09 18:56 ` Linus Torvalds
2025-10-10 15:52 ` Mauro Carvalho Chehab
2025-10-09 14:47 ` Bird, Tim
2025-10-09 15:11 ` Andrew Lunn
2025-10-09 17:58 ` Mark Brown
2025-10-09 1:15 ` Chris Mason
2025-10-08 20:37 ` Andrew Lunn
2025-10-09 12:40 ` Arnaldo Carvalho de Melo
2025-10-09 14:52 ` Paul E. McKenney
2025-10-10 3:08 ` Krzysztof Kozlowski [this message]
2025-10-10 14:12 ` Chris Mason
2025-10-31 16:51 ` Stephen Hemminger
2025-10-14 7:16 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be5094b9-fb20-462e-ad2f-2b58e520b949@kernel.org \
--to=krzk@kernel.org \
--cc=ast@kernel.org \
--cc=clm@meta.com \
--cc=dan.carpenter@linaro.org \
--cc=ksummit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox