ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: ksummit-discuss@lists.linux-foundation.org
Cc: Joe Perches <joe@perches.com>
Subject: [Ksummit-discuss] [CORE TOPIC] checkpatch/Codingstyle and trivial patch spam
Date: Tue, 13 Sep 2016 20:58:49 +0200	[thread overview]
Message-ID: <b72e9a2e-64d4-12af-1af3-adf963151466@de.ibm.com> (raw)

A very late proposal, maybe related to Joe Perches thread about checkpatch and
previous discussions about getting new people.

There are a decent amount of patches just dealing with checkpatch warnings or
Codingtyle things and sometimes the quality of these patches is not the best.

1. What is the general opinion about this patch class? It seems to be trade of
between attracting new developers vs. letting people create a huge amount of
patches for no good reason. The acceptance of these patches seems to differ from
maintainer to maintainer. Are there ideas how to improve things for newbies
without inviting patch bombers?

 2. Some patches are created due to the CodingStyle document, e.g. just
changing the name of labels for gotos. Does it make sense to make CodingStyle
less specific again to avoid these change? Or maybe add some rules in
SubmittingPatches to always think twice before sending patches to existing code.
Any better ideas?

3. CodingStyle seems to get changes which have no ACK or Reviewed-by that seem
to be controversial.  e.g.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51
suggested to indent labels with a space, and was then immediately followed by
patches. Is there a process in place to verify and challenge such changes?

4.  Does it make sense to make checkpatch less agressive on files than on
patches to avoid a big chunk of changes on existing code?

Christian

             reply	other threads:[~2016-09-13 18:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 18:58 Christian Borntraeger [this message]
2016-09-13 19:18 ` Joe Perches
2016-09-13 19:45 ` Josh Triplett
2016-09-13 20:03   ` Jonathan Corbet
2016-09-13 22:14     ` Joe Perches
2016-09-14  5:29       ` Julia Lawall
2016-09-13 23:49     ` Rafael J. Wysocki
2016-09-14  2:03       ` Josh Triplett
2016-09-14  2:24         ` Joe Perches
2016-09-14  5:57           ` Julia Lawall
2016-09-14  6:27             ` Joe Perches
2016-09-14  6:35               ` Julia Lawall
2016-09-14  6:43                 ` Joe Perches
2016-09-14 17:11               ` Alexandre Belloni
2016-09-15 16:33                 ` Jonathan Cameron
2016-09-14 11:54           ` Greg KH
2016-09-14 14:23             ` Joe Perches
2016-09-14 14:32               ` Greg KH
2016-09-14 14:35                 ` Julia Lawall
2016-09-14 14:39                   ` Theodore Ts'o
2016-09-14 19:26                     ` Julia Lawall
2016-09-14 14:51                   ` Joe Perches
2016-09-14 19:30                     ` Julia Lawall
2016-09-14 14:51                 ` Joe Perches
2016-09-14 14:45               ` Guenter Roeck
2016-09-14 15:13                 ` Joe Perches
2016-09-14 19:46                   ` Guenter Roeck
2016-09-14 18:04       ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b72e9a2e-64d4-12af-1af3-adf963151466@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=joe@perches.com \
    --cc=ksummit-discuss@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox