Re: [Ksummit-discuss] [TOPIC] Encouraging more reviewers

["Lukáš Czerner" <lczerner@redhat.com>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2623 bytes --]

On Wed, 28 May 2014, Wolfram Sang wrote:

> Date: Wed, 28 May 2014 07:37:49 +0200
> From: Wolfram Sang <wsa@the-dreams.de>
> To: Lukáš Czerner <lczerner@redhat.com>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
>     ksummit-discuss@lists.linuxfoundation.org
> Subject: Re: [Ksummit-discuss] [TOPIC] Encouraging more reviewers
> 
> 
> > > The thing I'd like to see way more in the Linux ecosystem:
> > > 
> > > Paid reviewers/maintainers (selected people, no hiring offers). The
> > > number of developers increases faster than the number of quality
> > > keepers. So, the latter should be given the chance to focus on it, if
> > > they want to.
> > 
> > That does not make much sense to me. In order to review the code you
> > need to understand it and if you already understand the code, you
> > can write it as well.
> 
> Huh, have you ever maintained something? I couldn't write most of the
> drivers I get for I2C, because I simply don't have access to the
> hardware.

But the lack of HW was the one thing stopping you right ? Not the
lack of skills or knowledge. I am just saying that it's quite likely
that there are even less people with the skills who are willing to be
dedicated to review than developers who are willing to review
patches from time to time.

> Also, I it is one thing to get the driver working (dealing
> with HW bugs and documentation flaws) and another to get the driver
> proper (use proper kernal interfaces, coding style...).
> 
> > I do not think that having dedicated reviewers is realistic in the
> > long run.
> 
> Then, think more of dedicated maintainers: I don't know one maintainer
> who is not interested in hacking as well. Which is needed, of course.
> There are reviews which make flaws in the subsystem core obvious.
> Usually, the original patch comitter is only interested in this reviewed
> patch and does not want to deal with the core. So, this kind of work is
> up to the maintainer. If maintainers are backed off, more of this work
> could be done IMO.

Are you suggesting that existing maintainers should either stop
hacking, or give up maintainership in favour of those who does not
want to write code ? :) Sorry for exaggerating, but I do not think
that having people dedicated solely to review is realistic.

We should rather focus on encouraging developers to review more.

> 
> > However encouraging reviewers by treating reviewed-by tag with equal
> > "respect" as signed-off-by seems like the better way.
> 
> In general, yes. As I said before, "Reviewed-by" tags need to be trusted
> what also takes some time and effort in the beginning.
> 
>