From: Julia Lawall <julia.lawall@lip6.fr>
To: Jan Kara <jack@suse.cz>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
ksummit <ksummit-discuss@lists.linuxfoundation.org>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Keeping reviews meaningful
Date: Mon, 19 Aug 2019 09:06:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1908190905110.3257@hadrien> (raw)
In-Reply-To: <20190819065710.GC20455@quack2.suse.cz>
On Mon, 19 Aug 2019, Jan Kara wrote:
> On Sat 17-08-19 21:35:29, Paul Walmsley wrote:
> > On Mon, 15 Jul 2019, Theodore Y. Ts'o wrote:
> >
> > > I'd suggest changing the text to read:
> > >
> > > - Acked-by: indicates an agreement by the maintainer or
> > > reviewer of the the relevant code that the patch is
> > > appropriate for inclusion into the kernel.
> >
> > This would be a positive step forward. I would be in favor of this.
> >
> > It would also be good to state here, if it isn't stated already, that
> > "reviewer" means "someone who is listed in an R: line in MAINTAINERS".
>
> I don't think that 'R:' entry in MAINTAINERS should be really asked for.
> IMO that is unnecessary bureaucracy and discourages review from people
> that are not core developers. Sure the quality of the review may be lower
> than from core developer but still there's some value in it. So I'd really
> leave it at the discretion of the maintainer whether he accepts or just
> ignores Reviewed-by tag.
Is there some other tag for "I'm interested in and reasonably
knowledgeable about this change and it looks good to me"?
Note that there is a double "the" in the above text.
julia
>
> Honza
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
> _______________________________________________
> Ksummit-discuss mailing list
> Ksummit-discuss@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
>
next prev parent reply other threads:[~2019-08-19 7:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 14:27 Wolfram Sang
2019-07-06 16:52 ` Leon Romanovsky
2019-07-06 17:17 ` Wolfram Sang
2019-07-08 10:47 ` Jan Kara
2019-07-08 11:47 ` Wolfram Sang
2019-07-15 16:11 ` Mauro Carvalho Chehab
2019-07-08 11:21 ` Geert Uytterhoeven
2019-07-08 11:59 ` Wolfram Sang
2019-07-15 15:58 ` Mauro Carvalho Chehab
2019-07-15 17:00 ` Theodore Y. Ts'o
2019-07-15 17:11 ` Mauro Carvalho Chehab
2019-07-16 21:26 ` Wolfram Sang
2019-08-17 21:35 ` Paul Walmsley
2019-08-19 6:57 ` Jan Kara
2019-08-19 7:06 ` Jiri Kosina
2019-08-19 7:06 ` Julia Lawall [this message]
2019-08-19 8:04 ` Jan Kara
2019-08-19 8:13 ` Julia Lawall
2019-08-20 10:22 ` James Bottomley
2019-08-19 8:26 ` Thomas Gleixner
2019-08-19 16:16 ` Christian Brauner
2019-08-19 19:04 ` Thomas Gleixner
2019-08-19 21:03 ` Christian Brauner
2019-07-08 14:57 ` Mark Brown
2019-07-14 9:35 ` Jonathan Cameron
2019-07-14 10:13 ` Thomas Gleixner
2019-07-15 9:10 ` Rafael J. Wysocki
2019-07-16 21:16 ` Wolfram Sang
2019-07-16 21:57 ` Olof Johansson
2019-07-16 22:27 ` Thomas Gleixner
2019-07-17 3:59 ` Randy Dunlap
2019-07-17 7:31 ` Wolfram Sang
2019-07-17 16:05 ` Linus Walleij
2019-07-17 16:40 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908190905110.3257@hadrien \
--to=julia.lawall@lip6.fr \
--cc=jack@suse.cz \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=mchehab+samsung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox