From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id ED779516 for ; Sat, 17 Nov 2018 17:03:50 +0000 (UTC) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A1CDD6FB for ; Sat, 17 Nov 2018 17:03:49 +0000 (UTC) Date: Sat, 17 Nov 2018 09:03:46 -0800 (PST) From: Julia Lawall To: Rob Herring In-Reply-To: Message-ID: References: <154225759358.2499188.15268218778137905050.stgit@dwillia2-desk3.amr.corp.intel.com> <154225760492.2499188.14152986544451112930.stgit@dwillia2-desk3.amr.corp.intel.com> <878t1tgpk8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: ksummit-discuss@lists.linuxfoundation.org, linux-nvdimm , vishal.l.verma@intel.com, "linux-kernel@vger.kernel.org" , stfrench@microsoft.com, Greg Kroah-Hartman , Mauro Carvalho Chehab , Dmitry Vyukov , "Tobin C. Harding" Subject: Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 17 Nov 2018, Rob Herring wrote: > On Fri, Nov 16, 2018 at 11:57 AM Joe Perches wrote: > > > > On Fri, 2018-11-16 at 14:44 +0200, Jani Nikula wrote: > > > I quickly cooked up this script to produce the top-5 commit prefixes for > > > the given files over the arbitrary last 200 commits. It'll give you a > > > pretty good idea if you're even close. > > > > > > --- > > > #!/bin/sh > > > # usage: subject-prefix FILE [...] > > > # show top 5 subject prefixes for FILEs > > > > > > git log --format=%s -n 200 -- "$@" |\ > > > grep -v "^Merge " |\ > > --no-merges in git log can replace this line. > > > > sed 's/\(.*\):.*/\1/' |\ > > > sort | uniq -c | sort -nr | sed 's/ *[0-9]\+ //' |\ > > > head -n 5 > > > --- > > > > > > Someone who knows perl could turn that into a checkpatch check: See if > > > the patch subject prefix is one of the top-5 for all files changed by > > > the patch, and ask the user to double check if it isn't. Or some > > > heuristics thereof. > > > > This won't work when a patch contains multiple files > > from different paths, or even multiple files from a > > single driver. > > Different paths is often, but not always a sign that patches may need > to be split up. Maybe that is something checkpatch should point out. Between v4.0 and v4.19, 18% of commits touch multiple .c files. 35% of commits touch multiple files in general. julia > > > Perhaps it's better to use a generic mechanism like > > > > basename $(dirname $filename): > > > > with some exceptions and add an override patch subject > > grammar to appropriate various sections of MAINTAINERS. > > Perhaps just use the script as a starting point to populate > MAINTAINERS as it may never be that accurate. > > > I also think it's better to use a separate script like > > scripts/spdxcheck.py and tie any necessary checkpatch > > use to that script. > > Yes, checkpatch is getting pretty unwieldy. > > Rob >