From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTP id 3F94B910 for ; Wed, 28 May 2014 21:32:21 +0000 (UTC) Received: from Galois.linutronix.de (www.linutronix.de [62.245.132.108]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id CD4942039B for ; Wed, 28 May 2014 21:32:20 +0000 (UTC) Date: Wed, 28 May 2014 23:32:11 +0200 (CEST) From: Thomas Gleixner To: Mark Brown In-Reply-To: <20140528183825.GA21477@sirena.org.uk> Message-ID: References: <20140524111927.GA3455@katana> <4700397.FLxRVChBLf@vostro.rjw.lan> <20140528143246.GV15585@mwanda> <20140528163902.GA5099@sirena.org.uk> <1401295862.13546.109.camel@dhcp-9-2-203-236.watson.ibm.com> <20140528173553.GE5099@sirena.org.uk> <3908561D78D1C84285E8C5FCA982C28F328205B1@ORSMSX114.amr.corp.intel.com> <20140528183825.GA21477@sirena.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: James Bottomley , "ksummit-discuss@lists.linuxfoundation.org" , Dan Carpenter Subject: Re: [Ksummit-discuss] [TOPIC] Encouraging more reviewers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 28 May 2014, Mark Brown wrote: > On Wed, May 28, 2014 at 05:44:41PM +0000, Luck, Tony wrote: > > > > There's a world of difference between thanking people for review and a > > > detailed account of all the changes made in every single iteration of > > > the review. > > > This is already covered in Documentation/SubmittingPatches. Quoting > > lines 585-592 (see last sentence): > > Right, but Daniel is proposing lifting that above the --- and including > it in git. What you really want is: Link: https://lkml.kernel.org/r/MESSAGE_ID_OF_PATCH It's way more useful than any of the v1-n writeups, which are most of the time just a completely waste of electrons. Even if written well, without the actual review context they are pretty pointless. Thanks, tglx