ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: "Bird, Tim" <Tim.Bird@sony.com>
Cc: "laurent.pinchart@ideasonboard.com"
	<laurent.pinchart@ideasonboard.com>, Andrew Lunn <andrew@lunn.ch>,
	Chris Mason <clm@meta.com>,
	"ksummit@lists.linux.dev" <ksummit@lists.linux.dev>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools
Date: Wed, 8 Oct 2025 16:30:32 -0400	[thread overview]
Message-ID: <aObJ6GPU9aKeI_CZ@laps> (raw)
In-Reply-To: <MW5PR13MB5632D8B5B656E1552B21159FFDE1A@MW5PR13MB5632.namprd13.prod.outlook.com>

On Wed, Oct 08, 2025 at 07:50:32PM +0000, Bird, Tim wrote:
>
>
>> -----Original Message-----
>> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> On Wed, Oct 08, 2025 at 09:08:33PM +0200, Andrew Lunn wrote:
>> > > My goal for KS/MS is to discuss how to enable maintainers to use review
>> > > automation tools to lower their workload.
>> >
>> > Maintainers will want to use these tools, if they prove to be
>> > useful. But ideally, we want the developers to use these tools and fix
>> > the issues before they post code for review. That reduces the
>> > maintainers workload even more. So Maintainers just need to run the
>> > tools to prove that the developers have run the tools and have already
>> > fixed the problems.
>> >
>> > So i'm not sure your goal is the correct long term goal. It should be
>> > a tool for everybody, not just maintainers.
>>
>> This raises the interesting and important question of how to get patch
>> submitters to follow a recommended workflow. We routinely get patches
>> that produce checkpatch errors that are clearly not false positives.
>> Rob Herring implemented a bot to run checks on device tree bindings and
>> device tree sources because lots of patches fail those checks. I'm sure
>> there are lots of other examples that have led maintainers to automate
>> checks on the receiver's side, through various types of standard CIs or
>> hand-made solutions. Submitters should run more tests, how to get them
>> to do so is a broader question.
>
>Maybe it would be worthwhile to annotate patch submissions with tags
>indicating what tools have been run on them.  I know we're trying to avoid
>overuse of commit tags, but maybe we could automate this a bit, and/or'
>reuse the 'Reviewed-by:' tag in the commit message.  I could envision, in some
>future workflow utopia, where a missing 'Reviewed-by: checkpatch.pl AND claude AI review'
>would be grounds for requesting these before human review.

This is similar to what was proposed in the last round[1] of discussions around
disclosing (AI) tool usage.

 From the cover letter:

	Assisted-by: Claude-claude-3-opus-20240229 checkpatch

At which point maintainers can set their own policies for their subsystem and
automate workflows based on those policies.



[1] https://lore.kernel.org/all/20250809234008.1540324-1-sashal@kernel.org/

-- 
Thanks,
Sasha

  reply	other threads:[~2025-10-08 20:30 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 17:04 Chris Mason
2025-10-08 17:20 ` Konstantin Ryabitsev
2025-10-08 18:11   ` Sasha Levin
2025-10-08 18:35   ` Chris Mason
2025-10-08 17:57 ` Bart Van Assche
2025-10-08 18:04   ` Chris Mason
2025-10-08 18:14     ` Bart Van Assche
2025-10-08 18:42       ` Chris Mason
2025-10-08 21:08     ` Kees Cook
2025-10-09  1:37       ` Chris Mason
2025-10-08 18:33 ` Sasha Levin
2025-10-09  1:43   ` Chris Mason
2025-10-09 14:49     ` Paul E. McKenney
2025-10-08 19:08 ` Andrew Lunn
2025-10-08 19:28   ` Arnaldo Carvalho de Melo
2025-10-08 19:33     ` Laurent Pinchart
2025-10-08 19:39       ` Arnaldo Carvalho de Melo
2025-10-08 20:29         ` Andrew Lunn
2025-10-08 20:53           ` Mark Brown
2025-10-09  9:37         ` Laurent Pinchart
2025-10-09 12:48           ` Arnaldo Carvalho de Melo
2025-10-08 19:29   ` Laurent Pinchart
2025-10-08 19:50     ` Bird, Tim
2025-10-08 20:30       ` Sasha Levin [this message]
2025-10-09 12:32         ` Arnaldo Carvalho de Melo
2025-10-08 20:30       ` James Bottomley
2025-10-08 20:38         ` Bird, Tim
2025-10-08 22:21           ` Jiri Kosina
2025-10-09  9:14           ` Laurent Pinchart
2025-10-09 10:03             ` Chris Mason
2025-10-10  7:54               ` Laurent Pinchart
2025-10-10 11:40                 ` James Bottomley
2025-10-10 11:53                   ` Laurent Pinchart
2025-10-10 14:21                     ` Steven Rostedt
2025-10-10 14:35                   ` Bird, Tim
2025-10-09 14:30             ` Steven Rostedt
2025-10-09 14:51               ` Andrew Lunn
2025-10-09 15:05                 ` Steven Rostedt
2025-10-10  7:59                 ` Laurent Pinchart
2025-10-10 14:15                   ` Bird, Tim
2025-10-10 15:07                     ` Joe Perches
2025-10-10 16:01                       ` checkpatch encouragement improvements (was RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools) Bird, Tim
2025-10-10 17:11                         ` Rob Herring
2025-10-10 17:33                           ` Arnaldo Carvalho de Melo
2025-10-10 19:21                           ` Joe Perches
2025-10-10 16:11                       ` [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Steven Rostedt
2025-10-10 16:47                         ` Joe Perches
2025-10-10 17:42                           ` Steven Rostedt
2025-10-11 10:28                         ` Mark Brown
2025-10-09 16:31               ` Chris Mason
2025-10-09 17:19                 ` Arnaldo Carvalho de Melo
2025-10-09 17:24                   ` Arnaldo Carvalho de Melo
2025-10-09 17:31                     ` Alexei Starovoitov
2025-10-09 17:47                       ` Arnaldo Carvalho de Melo
2025-10-09 18:42                     ` Chris Mason
2025-10-09 18:56                       ` Linus Torvalds
2025-10-10 15:52                         ` Mauro Carvalho Chehab
2025-10-09 14:47             ` Bird, Tim
2025-10-09 15:11               ` Andrew Lunn
2025-10-09 17:58               ` Mark Brown
2025-10-09  1:15         ` Chris Mason
2025-10-08 20:37     ` Andrew Lunn
2025-10-09 12:40       ` Arnaldo Carvalho de Melo
2025-10-09 14:52 ` Paul E. McKenney
2025-10-10  3:08 ` Krzysztof Kozlowski
2025-10-10 14:12   ` Chris Mason
2025-10-31 16:51   ` Stephen Hemminger
2025-10-14  7:16 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aObJ6GPU9aKeI_CZ@laps \
    --to=sashal@kernel.org \
    --cc=Tim.Bird@sony.com \
    --cc=andrew@lunn.ch \
    --cc=ast@kernel.org \
    --cc=clm@meta.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ksummit@lists.linux.dev \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox