From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
Sasha Levin <sashal@kernel.org>,
ksummit@lists.linux.dev, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: Proposal: Enhancing Commit Tagging for Stable Kernel Branches
Date: Tue, 16 Jul 2024 14:38:48 -0500 [thread overview]
Message-ID: <a97d832e-2848-4c8a-a4f7-00497a4f906e@suswa.mountain> (raw)
In-Reply-To: <20240716145123.GA2254116@nvidia.com>
On Tue, Jul 16, 2024 at 11:51:23AM -0300, Jason Gunthorpe wrote:
> On Sun, Jul 14, 2024 at 03:20:48PM -0400, James Bottomley wrote:
>
> > Here you seem to be assuming that every commit with a Fixes tag for a
> > prior release should be in stable ... I don't think that's true at all.
>
> I think that is the main issue here. Having talked to enough people in
> the server/enterprise space there are a lot of different ideas about
> what should be backported into the various kernel forks out there.
>
> Just looking at the patch meta data there is a spectrum of:
> No-Fixes -> Fixes -> Fixes&Stable
(I've been looking at stable kernels for Linaro).
There are a few reasons to apply patches without Fixes tags.
1) Quite a few patches that should have Fixes tags don't. For example
syzbot stuff should always get a Fixes tag.
2) Sometimes we don't realize it's a fix until later.
3) Adding PCI IDs.
4) Other fixes depend on cleanups before they can be backported.
For example, this patch:
https://lore.kernel.org/all/20240429133832.9547-1-kabel@kernel.org/
It's a one line fix. But it's easier to apply if we apply it if we
apply a couple other patches first.
https://lore.kernel.org/all/20180319100523.24498-2-u.kleine-koenig@pengutronix.de/
https://lore.kernel.org/all/20191105001301.27966-3-andrew@lunn.ch/
The second patch doesn't do anything, but now the fix can be applied
cleanly.
regards,
dan carpenter
next prev parent reply other threads:[~2024-07-16 19:38 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 12:31 Sasha Levin
2024-07-14 13:35 ` James Bottomley
2024-07-14 15:35 ` Andrew Lunn
2024-07-14 16:34 ` James Bottomley
2024-07-14 18:38 ` Sasha Levin
2024-07-14 19:20 ` James Bottomley
2024-07-14 20:18 ` Sasha Levin
2024-07-15 18:00 ` Theodore Ts'o
2024-07-15 18:07 ` Mark Brown
2024-07-15 19:06 ` Dan Carpenter
2024-07-15 19:23 ` Steven Rostedt
2024-07-15 19:24 ` James Bottomley
2024-07-15 19:28 ` Steven Rostedt
2024-07-15 19:30 ` James Bottomley
2024-07-15 19:39 ` Dan Carpenter
2024-07-16 6:30 ` Greg KH
2024-07-15 20:25 ` Mauro Carvalho Chehab
2024-07-15 20:47 ` Dmitry Torokhov
2024-07-16 6:28 ` Greg KH
2024-07-16 12:20 ` Takashi Iwai
2024-07-17 22:05 ` Dan Carpenter
2024-07-18 7:34 ` Takashi Iwai
2024-07-18 14:48 ` Dan Carpenter
2024-07-18 14:56 ` James Bottomley
2024-07-18 16:36 ` Dan Carpenter
2024-07-19 0:49 ` NeilBrown
2024-07-19 1:35 ` Dan Carpenter
2024-07-19 11:55 ` Vegard Nossum
2024-07-23 14:14 ` Jiri Kosina
2024-07-16 14:51 ` Jason Gunthorpe
2024-07-16 19:38 ` Dan Carpenter [this message]
2024-07-15 6:15 ` Mauro Carvalho Chehab
2024-07-14 17:07 ` Linus Torvalds
2024-07-14 18:47 ` Sasha Levin
2024-07-14 19:27 ` Linus Torvalds
2024-07-14 20:27 ` Sasha Levin
2024-07-14 23:05 ` James Bottomley
2024-07-14 23:09 ` Linus Torvalds
2024-07-15 8:02 ` Greg KH
2024-07-15 8:53 ` Mauro Carvalho Chehab
2024-07-15 12:48 ` Mimi Zohar
2024-07-15 12:52 ` Mimi Zohar
2024-07-15 14:34 ` Alexandre Belloni
2024-07-15 14:40 ` Greg KH
2024-07-15 15:00 ` Jonathan Corbet
2024-07-15 15:07 ` James Bottomley
2024-07-15 15:19 ` Sasha Levin
2024-07-15 15:31 ` James Bottomley
2024-07-15 15:42 ` Dan Carpenter
2024-07-15 15:10 ` Greg KH
2024-07-15 17:45 ` Mauro Carvalho Chehab
2024-07-15 18:04 ` Mark Brown
2024-07-15 20:51 ` Dmitry Torokhov
2024-07-16 6:25 ` Greg KH
2024-07-16 15:00 ` Mark Brown
2024-07-14 23:29 ` NeilBrown
2024-07-14 23:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a97d832e-2848-4c8a-a4f7-00497a4f906e@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=ksummit@lists.linux.dev \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox