From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Bird, Tim" <Tim.Bird@sony.com>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>, Andrew Lunn <andrew@lunn.ch>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Chris Mason <clm@meta.com>,
"ksummit@lists.linux.dev" <ksummit@lists.linux.dev>,
Dan Carpenter <dan.carpenter@linaro.org>,
Alexei Starovoitov <ast@kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools
Date: Fri, 10 Oct 2025 09:47:23 -0700 [thread overview]
Message-ID: <a79e5d12fa755dcd342b8f841cb87b52ffc0f6e7.camel@perches.com> (raw)
In-Reply-To: <20251010121127.05381ba8@gandalf.local.home>
On Fri, 2025-10-10 at 12:11 -0400, Steven Rostedt wrote:
> On Fri, 10 Oct 2025 08:07:39 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > On Fri, 2025-10-10 at 14:15 +0000, Bird, Tim wrote:
> > > I have ideas to address the false positive rate, based on features that checkpatch.pl
> > > already has, as well as ideas for handling some of the concerns that running
> > > checkpatch.pl (or an equivalent) at build time would raise. Some of these might
> > > apply to AI review as well. Let me know if you want me to elaborate, or if we
> > > should just discuss in Tokyo.
> >
> > Please elaborate.
>
> Note, checkpatch.pl fails on pretty much anything in include/trace, as
> those files contain complex macros that are basically their own language.
> Anything that tries to make them follow kernel conventions simply makes
> the output uglier and harder to read.
I recall suggesting something about that once.
Basically, ignore the files.
https://lore.kernel.org/lkml/a587dac9e02cfde669743fd54ab41a3c6014c5e9.camel@perches.com/
next prev parent reply other threads:[~2025-10-10 16:47 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 17:04 Chris Mason
2025-10-08 17:20 ` Konstantin Ryabitsev
2025-10-08 18:11 ` Sasha Levin
2025-10-08 18:35 ` Chris Mason
2025-10-08 17:57 ` Bart Van Assche
2025-10-08 18:04 ` Chris Mason
2025-10-08 18:14 ` Bart Van Assche
2025-10-08 18:42 ` Chris Mason
2025-10-08 21:08 ` Kees Cook
2025-10-09 1:37 ` Chris Mason
2025-10-08 18:33 ` Sasha Levin
2025-10-09 1:43 ` Chris Mason
2025-10-09 14:49 ` Paul E. McKenney
2025-10-08 19:08 ` Andrew Lunn
2025-10-08 19:28 ` Arnaldo Carvalho de Melo
2025-10-08 19:33 ` Laurent Pinchart
2025-10-08 19:39 ` Arnaldo Carvalho de Melo
2025-10-08 20:29 ` Andrew Lunn
2025-10-08 20:53 ` Mark Brown
2025-10-09 9:37 ` Laurent Pinchart
2025-10-09 12:48 ` Arnaldo Carvalho de Melo
2025-10-08 19:29 ` Laurent Pinchart
2025-10-08 19:50 ` Bird, Tim
2025-10-08 20:30 ` Sasha Levin
2025-10-09 12:32 ` Arnaldo Carvalho de Melo
2025-10-08 20:30 ` James Bottomley
2025-10-08 20:38 ` Bird, Tim
2025-10-08 22:21 ` Jiri Kosina
2025-10-09 9:14 ` Laurent Pinchart
2025-10-09 10:03 ` Chris Mason
2025-10-10 7:54 ` Laurent Pinchart
2025-10-10 11:40 ` James Bottomley
2025-10-10 11:53 ` Laurent Pinchart
2025-10-10 14:21 ` Steven Rostedt
2025-10-10 14:35 ` Bird, Tim
2025-10-09 14:30 ` Steven Rostedt
2025-10-09 14:51 ` Andrew Lunn
2025-10-09 15:05 ` Steven Rostedt
2025-10-10 7:59 ` Laurent Pinchart
2025-10-10 14:15 ` Bird, Tim
2025-10-10 15:07 ` Joe Perches
2025-10-10 16:01 ` checkpatch encouragement improvements (was RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools) Bird, Tim
2025-10-10 17:11 ` Rob Herring
2025-10-10 17:33 ` Arnaldo Carvalho de Melo
2025-10-10 19:21 ` Joe Perches
2025-10-10 16:11 ` [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Steven Rostedt
2025-10-10 16:47 ` Joe Perches [this message]
2025-10-10 17:42 ` Steven Rostedt
2025-10-11 10:28 ` Mark Brown
2025-10-09 16:31 ` Chris Mason
2025-10-09 17:19 ` Arnaldo Carvalho de Melo
2025-10-09 17:24 ` Arnaldo Carvalho de Melo
2025-10-09 17:31 ` Alexei Starovoitov
2025-10-09 17:47 ` Arnaldo Carvalho de Melo
2025-10-09 18:42 ` Chris Mason
2025-10-09 18:56 ` Linus Torvalds
2025-10-10 15:52 ` Mauro Carvalho Chehab
2025-10-09 14:47 ` Bird, Tim
2025-10-09 15:11 ` Andrew Lunn
2025-10-09 17:58 ` Mark Brown
2025-10-09 1:15 ` Chris Mason
2025-10-08 20:37 ` Andrew Lunn
2025-10-09 12:40 ` Arnaldo Carvalho de Melo
2025-10-09 14:52 ` Paul E. McKenney
2025-10-10 3:08 ` Krzysztof Kozlowski
2025-10-10 14:12 ` Chris Mason
2025-10-31 16:51 ` Stephen Hemminger
2025-10-14 7:16 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a79e5d12fa755dcd342b8f841cb87b52ffc0f6e7.camel@perches.com \
--to=joe@perches.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Tim.Bird@sony.com \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=clm@meta.com \
--cc=dan.carpenter@linaro.org \
--cc=ksummit@lists.linux.dev \
--cc=laurent.pinchart@ideasonboard.com \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox