From: Sasha Levin <sashal@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kees Cook <kees@kernel.org>,
torvalds@linux-foundation.org, ksummit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: linus-next: improving functional testing for to-be-merged pull requests
Date: Tue, 22 Oct 2024 06:52:51 -0400 [thread overview]
Message-ID: <ZxeEA6i_xfBMxJm4@sashalap> (raw)
In-Reply-To: <ZxdKwtTd7LvpieLK@infradead.org>
On Mon, Oct 21, 2024 at 11:48:34PM -0700, Christoph Hellwig wrote:
>On Mon, Oct 21, 2024 at 09:54:53PM -0700, Kees Cook wrote:
>> For example, for a given PR, the bot can report:
>>
>> - Were the patches CCed to a mailing list?
>> - A histogram of how long the patches were in next (to show bake times)
>> - Are any patches associated with test failures? (0day and many other
>> CIs are already running tests against -next; parse those reports)
>>
>> We could have a real pre-submit checker! :)
>
>That would be very useful. Items 1 and 2 should be trivial, 3 would
>require a bit of work but would still be very useful.
So I've ended up writing something hacky that does (1) and (2) above, and
ran it on the existing (already merged) PRs on the mailing list to give
it a spin.
The script tripped on the very first PR it looked at:
https://lore.kernel.org/all/20241021171728.274997-1-pbonzini@redhat.com/
And in particular, this commit: afa9b48f327c ("KVM: arm64: Shave a few
bytes from the EL2 idmap code")
(sorry, not trying to pick on anyone/anything, just an example...)
The commit can't be found on lore.kernel.org, it was never in -next, and
yet Linus pulled it promptly without questioning anything.
So yes, we could argue that a bot sending out this information would
have informed Linus of this issue, but somehow I suspect that Linus is
not an idiot and he has enough scripts in place already to alert him of
these issues, which he chooses to ignore in some cases.
--
Thanks,
Sasha
next prev parent reply other threads:[~2024-10-22 10:52 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 16:07 Sasha Levin
2024-10-21 17:18 ` Matthieu Baerts
2024-10-21 17:36 ` Sasha Levin
2024-10-22 9:11 ` Matthieu Baerts
2024-10-21 17:24 ` Bart Van Assche
2024-10-21 17:30 ` Sasha Levin
2024-10-21 18:10 ` Luis Chamberlain
2024-10-21 18:36 ` Liam R. Howlett
2024-10-21 19:44 ` Sasha Levin
2024-10-21 22:56 ` Linus Torvalds
2024-10-21 21:41 ` Mark Brown
2024-10-22 9:10 ` Thorsten Leemhuis
2024-10-22 13:19 ` Mark Brown
2024-10-31 19:22 ` Shuah Khan
2024-10-21 23:39 ` Paul E. McKenney
2024-10-22 12:06 ` Jiri Kosina
2024-10-22 14:22 ` Paul E. McKenney
2024-10-22 14:36 ` Sasha Levin
2024-10-22 14:46 ` Paul E. McKenney
2024-10-22 4:54 ` Kees Cook
2024-10-22 6:48 ` Christoph Hellwig
2024-10-22 8:12 ` Steven Rostedt
2024-10-22 9:55 ` Vlastimil Babka
2024-10-22 11:51 ` James Bottomley
2024-10-22 12:47 ` Mark Brown
2024-10-22 19:33 ` Kees Cook
2024-10-23 2:24 ` Guenter Roeck
2024-10-23 5:47 ` Christoph Hellwig
2024-10-23 8:20 ` Steven Rostedt
2024-10-23 8:36 ` Geert Uytterhoeven
2024-10-23 9:19 ` Steven Rostedt
2024-10-23 9:23 ` Geert Uytterhoeven
2024-10-23 10:11 ` Dan Carpenter
2024-10-23 17:51 ` Paul E. McKenney
2024-10-24 3:59 ` Michael Ellerman
2024-10-24 5:01 ` Steven Rostedt
2024-10-24 5:16 ` Guenter Roeck
2024-10-24 6:49 ` Steven Rostedt
2024-10-24 7:01 ` Geert Uytterhoeven
2024-10-24 9:21 ` Steven Rostedt
2024-10-24 9:24 ` Christoph Hellwig
2024-10-24 9:49 ` Steven Rostedt
2024-10-24 11:08 ` Mark Brown
2024-10-24 11:14 ` Christoph Hellwig
2024-10-25 21:04 ` Jiri Kosina
2024-10-24 14:39 ` Guenter Roeck
2024-10-25 1:11 ` Steven Rostedt
2024-10-25 3:52 ` Guenter Roeck
2024-10-25 11:18 ` Mark Brown
2024-10-25 17:23 ` Paul E. McKenney
2024-10-24 17:53 ` Luis Chamberlain
2024-10-25 1:17 ` Steven Rostedt
2024-10-25 2:07 ` Luis Chamberlain
2024-10-31 19:08 ` Shuah Khan
2024-10-31 19:19 ` Steven Rostedt
2024-10-23 9:32 ` Vlastimil Babka
2024-10-23 10:18 ` Thorsten Leemhuis
2024-10-23 11:41 ` James Bottomley
2024-10-22 9:37 ` Sasha Levin
2024-10-23 5:50 ` Christoph Hellwig
2024-10-23 17:47 ` Paul E. McKenney
2024-10-23 18:05 ` Guenter Roeck
2024-10-23 18:09 ` Linus Torvalds
2024-10-23 18:50 ` Geert Uytterhoeven
2024-10-23 18:06 ` Linus Torvalds
2024-10-23 18:37 ` Paul E. McKenney
2024-10-23 19:24 ` Linus Torvalds
2024-10-23 20:22 ` Paul E. McKenney
2024-10-23 21:20 ` Theodore Ts'o
2024-10-23 21:24 ` Mark Brown
2024-10-24 2:51 ` Paul E. McKenney
2024-10-22 10:52 ` Sasha Levin [this message]
2024-10-22 11:50 ` Mark Brown
2024-10-22 14:47 ` Sasha Levin
2024-10-22 15:25 ` Mark Brown
2024-10-28 22:46 ` Sasha Levin
2024-10-29 8:10 ` Thorsten Leemhuis
2024-10-29 11:30 ` Sasha Levin
2024-10-29 12:46 ` Thorsten Leemhuis
2024-10-29 15:07 ` Sasha Levin
2024-10-30 6:46 ` Thorsten Leemhuis
2024-10-30 14:10 ` Sasha Levin
2024-10-31 8:13 ` Thorsten Leemhuis
2024-10-29 8:20 ` Geert Uytterhoeven
2024-10-30 17:08 ` Paul E. McKenney
2024-10-30 17:15 ` Sasha Levin
2024-10-30 17:32 ` Paul E. McKenney
2024-11-04 8:49 ` Joel Granados
2024-11-04 11:01 ` Sasha Levin
2024-11-25 20:05 ` Joel Granados
2024-10-22 7:02 ` Geert Uytterhoeven
2024-10-22 8:41 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxeEA6i_xfBMxJm4@sashalap \
--to=sashal@kernel.org \
--cc=hch@infradead.org \
--cc=kees@kernel.org \
--cc=ksummit@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox