From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 776751DFFD for ; Mon, 15 Jul 2024 15:19:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721056776; cv=none; b=kbSJpNWfpNfz3q0ps5wR0prWGsI5scWtZagus4Jqww8ONE28n6T+iFqL2ezwG7/cfrGjaiZeaWoZQEqeAXX5eCrNMW+z8EhB9RQBxIkcxxibHiZQiUbnM00Oq55iysb8AzJqCB2khg5sJQj9j5XJWQcSVCfuQVi7oghIgpL6n/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721056776; c=relaxed/simple; bh=Y7oOxfVlPwdpx1VRZmChMbyYi5zgn2j5cYC8K/9iUDs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gTzSm721y0E0Mp6jBzWGJy9PoJYjxprFYvRTARwNqG3g0ixhV2IkvxhMhrH/UcIoWDF5A7h0oeOmvMcNfihPb8hQmW3OhlY7QkR+ON+Z0WfAtlhwqNwpDjND/kAqaJmfSzc0ltzFBAD1WXIU9zYUp1dhsrW/2Xnt9CjlYxdmL+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FhEpFoAv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FhEpFoAv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1581C32782; Mon, 15 Jul 2024 15:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721056775; bh=Y7oOxfVlPwdpx1VRZmChMbyYi5zgn2j5cYC8K/9iUDs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FhEpFoAvPM9EaNUiuWJO2yTguUCfF1Yx1Kfelt1CjLwKaRkxGbbIeXtsIVDEv4wPk G0fyWgi1zfYQSzRzCPzKF8Sc454RJS0wH6masTroDwE2YXEFzcH1SsCXTdMK0KbswD 6lZlPov6DSrS/OdiMFrRpGVyHagUFz+NyKrUcObOyFGnhoAOjUS+MzWb1PYcXZSNHv jaG23fAZlMwCW6qE0PqVjWqeDBnacAxA9fv3BPYMwY475c3viwG83w/NnGqLWxL023 0OmgYFSlxYS9GO4uriRY+mvPvgM6JBSazyOcOVWmb5Yt2n51qLCC8Dk+57c5Kt2ioy grz4M7ZufH5kw== Date: Mon, 15 Jul 2024 11:19:31 -0400 From: Sasha Levin To: James Bottomley Cc: Jonathan Corbet , Greg KH , Alexandre Belloni , Mimi Zohar , Linus Torvalds , ksummit@lists.linux.dev Subject: Re: Proposal: Enhancing Commit Tagging for Stable Kernel Branches Message-ID: References: <0e6c7c8ed259dcb50631c6fdc3d86d3080bdc6f3.camel@HansenPartnership.com> <2024071528-cahoots-reacquire-9eab@gregkh> <3a357a63f67f3e6aff5e6d020d40b51fa24e0280.camel@linux.ibm.com> <202407151434198c3715e9@mail.local> <2024071515-zestfully-womankind-1901@gregkh> <87h6cqya32.fsf@trenco.lwn.net> Precedence: bulk X-Mailing-List: ksummit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Mon, Jul 15, 2024 at 11:07:30AM -0400, James Bottomley wrote: >On Mon, 2024-07-15 at 09:00 -0600, Jonathan Corbet wrote: >> Are developers and maintainers expected to put in stable tags the way >> they are expected to add Signed-off-by, or is it a fully optional >> practice? In the latter case, I'm not sure how much good messing with >> the tags will do. > >So what's documented is > >Fixes: is generally useful outside of stable (for bug tracing and the >like) and is thus not optional. It simply means something about the >target was updated by the patch, but this could be spelling in comments >or white space and thus may not be a stable candidate. But then look at how folks interpert the Fixes tag: On Sun, Jul 14, 2024 at 12:27:55PM -0700, Linus Torvalds wrote: >I would hope that *all* commits improve on something. And if it's an >actual fix to a previous commit, it should say so. > >If it's just a random improvement, it shouldn't refer to a previous >commit at all. Linus (and others) see the Fixes tag differently than how you (and others) see it. Which, I guess, is the issue I'm trying to resolve. -- Thanks, Sasha