From: Sasha Levin <sashal@kernel.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Greg KH <gregkh@linuxfoundation.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Mimi Zohar <zohar@linux.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
ksummit@lists.linux.dev
Subject: Re: Proposal: Enhancing Commit Tagging for Stable Kernel Branches
Date: Mon, 15 Jul 2024 11:19:31 -0400 [thread overview]
Message-ID: <ZpU-A9avLDktkFT_@sashalap> (raw)
In-Reply-To: <b71b6745ae79ae40196d82c0c306acdc174c0994.camel@HansenPartnership.com>
On Mon, Jul 15, 2024 at 11:07:30AM -0400, James Bottomley wrote:
>On Mon, 2024-07-15 at 09:00 -0600, Jonathan Corbet wrote:
>> Are developers and maintainers expected to put in stable tags the way
>> they are expected to add Signed-off-by, or is it a fully optional
>> practice? In the latter case, I'm not sure how much good messing with
>> the tags will do.
>
>So what's documented is
>
>Fixes: is generally useful outside of stable (for bug tracing and the
>like) and is thus not optional. It simply means something about the
>target was updated by the patch, but this could be spelling in comments
>or white space and thus may not be a stable candidate.
But then look at how folks interpert the Fixes tag:
On Sun, Jul 14, 2024 at 12:27:55PM -0700, Linus Torvalds wrote:
>I would hope that *all* commits improve on something. And if it's an
>actual fix to a previous commit, it should say so.
>
>If it's just a random improvement, it shouldn't refer to a previous
>commit at all.
Linus (and others) see the Fixes tag differently than how you (and
others) see it.
Which, I guess, is the issue I'm trying to resolve.
--
Thanks,
Sasha
next prev parent reply other threads:[~2024-07-15 15:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 12:31 Sasha Levin
2024-07-14 13:35 ` James Bottomley
2024-07-14 15:35 ` Andrew Lunn
2024-07-14 16:34 ` James Bottomley
2024-07-14 18:38 ` Sasha Levin
2024-07-14 19:20 ` James Bottomley
2024-07-14 20:18 ` Sasha Levin
2024-07-15 18:00 ` Theodore Ts'o
2024-07-15 18:07 ` Mark Brown
2024-07-15 19:06 ` Dan Carpenter
2024-07-15 19:23 ` Steven Rostedt
2024-07-15 19:24 ` James Bottomley
2024-07-15 19:28 ` Steven Rostedt
2024-07-15 19:30 ` James Bottomley
2024-07-15 19:39 ` Dan Carpenter
2024-07-16 6:30 ` Greg KH
2024-07-15 20:25 ` Mauro Carvalho Chehab
2024-07-15 20:47 ` Dmitry Torokhov
2024-07-16 6:28 ` Greg KH
2024-07-16 12:20 ` Takashi Iwai
2024-07-17 22:05 ` Dan Carpenter
2024-07-18 7:34 ` Takashi Iwai
2024-07-18 14:48 ` Dan Carpenter
2024-07-18 14:56 ` James Bottomley
2024-07-18 16:36 ` Dan Carpenter
2024-07-19 0:49 ` NeilBrown
2024-07-19 1:35 ` Dan Carpenter
2024-07-19 11:55 ` Vegard Nossum
2024-07-23 14:14 ` Jiri Kosina
2024-07-16 14:51 ` Jason Gunthorpe
2024-07-16 19:38 ` Dan Carpenter
2024-07-15 6:15 ` Mauro Carvalho Chehab
2024-07-14 17:07 ` Linus Torvalds
2024-07-14 18:47 ` Sasha Levin
2024-07-14 19:27 ` Linus Torvalds
2024-07-14 20:27 ` Sasha Levin
2024-07-14 23:05 ` James Bottomley
2024-07-14 23:09 ` Linus Torvalds
2024-07-15 8:02 ` Greg KH
2024-07-15 8:53 ` Mauro Carvalho Chehab
2024-07-15 12:48 ` Mimi Zohar
2024-07-15 12:52 ` Mimi Zohar
2024-07-15 14:34 ` Alexandre Belloni
2024-07-15 14:40 ` Greg KH
2024-07-15 15:00 ` Jonathan Corbet
2024-07-15 15:07 ` James Bottomley
2024-07-15 15:19 ` Sasha Levin [this message]
2024-07-15 15:31 ` James Bottomley
2024-07-15 15:42 ` Dan Carpenter
2024-07-15 15:10 ` Greg KH
2024-07-15 17:45 ` Mauro Carvalho Chehab
2024-07-15 18:04 ` Mark Brown
2024-07-15 20:51 ` Dmitry Torokhov
2024-07-16 6:25 ` Greg KH
2024-07-16 15:00 ` Mark Brown
2024-07-14 23:29 ` NeilBrown
2024-07-14 23:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpU-A9avLDktkFT_@sashalap \
--to=sashal@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alexandre.belloni@bootlin.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=ksummit@lists.linux.dev \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox