From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6D951BEF74 for ; Tue, 18 Feb 2025 21:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739913750; cv=none; b=forU2T/oLV9KGFrN5nS1CDSVZI/xaSRFSOkTEmzQcN+exLQhIs7v2nS6bSST/pxcC2wLtW4unQpD7Wewwboow8MZfh8W5bSeOfajOY+aBUtNsQW2sS9pi8sj1pb6TSdaWeCFiJTORT7XlfcPUOCadzrAT4FaGlUrscHfiS11MPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739913750; c=relaxed/simple; bh=PhCJS9wXLp3599FRMT13jinVFW++LjWM4UggqGQB7xU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fQa2czdhYJXCvx2md1MMW0/zSV/tX5sQg7VlP9yDjAzjB9hPpWLw1tI7GuBydWr/BhbZJ6zqEG6IdGKi0hcLjAXGFigt+Gp5jAltCtBm8BUXo2QhucoSK+YXf4060uZYdxKHkwUArS/KiMafvdQR7OdG+JX15mIQuwWC3k6uQbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ApDdFoLg; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ApDdFoLg" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-471f16f4b73so22947071cf.1 for ; Tue, 18 Feb 2025 13:22:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739913748; x=1740518548; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:from:to:cc:subject:date:message-id:reply-to; bh=mdXHnWlzCq6Ivvzkf4eBGgZZDJKGn23knokILDm8o3c=; b=ApDdFoLg6+/Md0I3OqH6BbuEuMyViREc6bWLpWfKAscdUIE/1op6TZmSQNhvb0n6x+ a4Dip3ptl2Nz3qJ2VrmaC65hSuLtz4FXVE0jQiND5/CZJKm+KQdJFoA9AHCiTygb50qU cKu55mQ7UPKkD/BRlyJfdNnYkCiVtx5AHNgWOUdR10vkHJU53brFthS32wOSKkfbE6kP G1xjLpoaF63RPPNYpb6c9P/M7RPLxjyxcjbCRn0VXACLM6r3vJUG+b4Z0h1EXAprxDqS n6P1KGTDIx4OL6G6zZE6pBQSGvmj43Twp9HOT1K0v2fVjOpiC7ns9/kW5jCAGzUxlSYt AgHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739913748; x=1740518548; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mdXHnWlzCq6Ivvzkf4eBGgZZDJKGn23knokILDm8o3c=; b=TuTIx4O0jyt66Y+oCYSzg9AhOUS2FR7e36R5WZRaJ/gRAogfa/fb5o28mOpw3vu7Jk onBFRqb7ec+Q9bBJH+R+t4ymJiDlKTE04rVU5S0Vjr07L8VoZwm3lk7MxbvXKqC/1KZZ 34laFxa0+CDy41WlwMqNrS8sqyUYvuak6ITYFB9Q+3S30RHCm+XBRB493m83jSQWzqTV XCmnygum6k/IjZkmdMoGi9BwB1k3aG7yCPzFljrX0OU0oTb+NOcAMI7gQzA9nadmJqkJ 7xRPwpEpCbYkCbqxYBZLNVTA6cyx73lc2Ul3h/dX4Ncbjn/8vrLZLxhV2kaYXrnehCzK qczw== X-Forwarded-Encrypted: i=1; AJvYcCW5D2MFxE+D2yEZCehtivd8Hq9LjYzOtfatCTVBjadLxdflwLsbfn552q8q5Ch16DsbY8/bhJJV@lists.linux.dev X-Gm-Message-State: AOJu0Yy16W225Wjf2MWzkGj2+oHUCWbNqrzvRsCwYmJMRIoS7m1jCrPV /0GaH/VDRZPOPWknNeld3ouzU4fhShqUnHxR50qCXrpjkoNFFwyL X-Gm-Gg: ASbGnctgkp0JEUHk0G2Ovi9b609lt9Y3hxDVvXipmh//MMSHS8qgQgisldPhTm0Z4oH BThgGTWf/+CjwSaHKeb1GQesnJrBqHxe7kVNX1L0Lgwt08RSlZtUvXB21KwTCbj/jrV4ky16bDw oSQ3z1NBF/vV5iV7HM0+kXqSnDK0m5CwuUFf8Sbkw4jAdGa/XQXp+Lsac+ESI9O2KuGWxjia0qY k1s3N+sU+f8XWXDMBLQiauXguV1AhKGiJP9c//lJeYM7S7QjT83TOoq7VT/FJwrBKPw5ye0MG4U JlDK90KzM6qxDOVUEScb80nrVY/eFUjowLnXPZjSMRL53Vb/0ny4ihA1/noS6+wkyU7fdKIyqk9 5GSqH+A== X-Google-Smtp-Source: AGHT+IG/CZ2zc9Q8yIVFvW5ZA3NO2BzO7cnxuhf1PWn/NSNNhTEdZqGlP/nCHUYXswX/Hk4Xcwl+ew== X-Received: by 2002:a05:622a:1106:b0:471:cd16:8c73 with SMTP id d75a77b69052e-4720824fcb5mr20118221cf.22.1739913747526; Tue, 18 Feb 2025 13:22:27 -0800 (PST) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-471ef0a5943sm27817941cf.51.2025.02.18.13.22.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 13:22:27 -0800 (PST) Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfauth.phl.internal (Postfix) with ESMTP id A64CF1200079; Tue, 18 Feb 2025 16:22:26 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Tue, 18 Feb 2025 16:22:26 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeivdefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddt udenucfhrhhomhepuehoqhhunhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrih hlrdgtohhmqeenucggtffrrghtthgvrhhnpeelteekfeeuteduueeukefhtdetffefueef heejueegvdegueduudefveekueevudenucffohhmrghinheprhhushhtqdhfohhrqdhlih hnuhigrdgtohhmpdhkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpegsohhquhhnodhmvghsmhhtphgruhhthhhpvghrsh honhgrlhhithihqdeiledvgeehtdeigedqudejjeekheehhedvqdgsohhquhhnrdhfvghn gheppehgmhgrihhlrdgtohhmsehfihigmhgvrdhnrghmvgdpnhgspghrtghpthhtohepud dtpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjrghrkhhkoheskhgvrhhnvghl rdhorhhgpdhrtghpthhtohephhgthhesihhnfhhrrgguvggrugdrohhrghdprhgtphhtth hopehmihhguhgvlhdrohhjvggurgdrshgrnhguohhnihhssehgmhgrihhlrdgtohhmpdhr tghpthhtoheprhhushhtqdhfohhrqdhlihhnuhigsehvghgvrhdrkhgvrhhnvghlrdhorh hgpdhrtghpthhtohepthhorhhvrghlughssehlihhnuhigqdhfohhunhgurghtihhonhdr ohhrghdprhgtphhtthhopehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdroh hrghdprhgtphhtthhopegrihhrlhhivggusehgmhgrihhlrdgtohhmpdhrtghpthhtohep lhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoh epkhhsuhhmmhhitheslhhishhtshdrlhhinhhugidruggvvh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Feb 2025 16:22:26 -0500 (EST) Date: Tue, 18 Feb 2025 13:22:05 -0800 From: Boqun Feng To: Jarkko Sakkinen Cc: Christoph Hellwig , Miguel Ojeda , rust-for-linux , Linus Torvalds , Greg KH , David Airlie , linux-kernel@vger.kernel.org, ksummit@lists.linux.dev Subject: Re: Rust kernel policy Message-ID: References: <36783d51be7576fcdbf8facc3c94193d78240816.camel@kernel.org> <4cbd3baf81ca3ff5e8c967b16fc13673d84139e8.camel@kernel.org> Precedence: bulk X-Mailing-List: ksummit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Feb 18, 2025 at 08:08:42PM +0200, Jarkko Sakkinen wrote: > On Tue, 2025-02-18 at 18:39 +0200, Jarkko Sakkinen wrote: > > On Tue, 2025-02-18 at 18:35 +0200, Jarkko Sakkinen wrote: > > > On Tue, 2025-02-18 at 08:08 -0800, Christoph Hellwig wrote: > > > > On Sun, Feb 09, 2025 at 09:56:35PM +0100, Miguel Ojeda wrote: > > > > > Hi all, > > > > > > > > > > Given the discussions in the last days, I decided to publish > > > > > this > > > > > page > > > > > with what our understanding is: > > > > > > > > > >     https://rust-for-linux.com/rust-kernel-policy > > > > > > > > > > I hope it helps to clarify things. I intend to keep it updated > > > > > as > > > > > needed. > > > > > > > > I don't think having a web page in any form is useful.  If you > > > > want > > > > it > > > > to be valid it has to be in the kernel tree and widely agreed on. > > > > > > I'd emphasize here that MUST be in the kernel tree. Otherwise, it > > > by > > > the > > > process can be safely ignored without a second thought. > > > > > > Doing random pointless annoucements is LF thing, not korg thing ;-) > > > > ... underlining that it would be also welcome take. But like that > > the policy plain sucks tbh. > > One take: Documentation/SubmittingRustPatches with things to take into > consideration when submitting Rust patches. > Hmm... anything particular makes Rust patches different that you want to add in that document? > "policy" is something is more appropriate word of choice to something > like how to behave (e.g. CoC). > > Here some pratical recipes on how to deal with Rust patches would bring > the maximum amount of value. > > E.g. here's one observation from DMA patches: there was no test payload. > AFAIK that alone should lead into an automatic and non-opionated NAK. I > know this because I thought "I'll help instead of debating and at least > test the patches" only to realize that there is total zero callers. > FWIW, usually Rust code has doc tests allowing you to run it with kunit, see: https://docs.kernel.org/rust/testing.html , I took a look at the DMA patches, there is one doc test, but unfortunately it's only a function definition, i.e. it won't run these DMA bindings. I agree that test payload should be provided, there must be something mentioning this in Documentation/process/submitting-patches.rst already? Regards, Boqun > Neither I could find a document which would explain to me why this is > fine. > > BR, Jarkko >