Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

[Dan Williams <dan.j.williams@intel.com>]

On Fri, Jul 10, 2015 at 1:54 PM,  <josh@joshtriplett.org> wrote:
> On Fri, Jul 10, 2015 at 03:51:44PM -0400, Steven Rostedt wrote:
>> On Thu, 9 Jul 2015 19:07:06 -0700
>> Darren Hart <dvhart@infradead.org> wrote:
>> > As far as recruitment goes, I think we're talking about barriers to first-timers
>> > and such - and git-send-email is one of those things. Eventually, a developer
>>
>> +1000
>>
>> I still don't use git-send-email, as I afraid that I'll blow it and end
>> up sending a thousand patches to every developer that ever touched the
>> kernel ;-)
>
> I don't use git-send-email either.  I use git-format-patch
> --cover-letter --thread, and then mutt -H to individually send each
> mail.  (I originally added the --thread and --in-reply-to options to
> git-format-patch, so that you don't need to use git-send-email for
> that.)
>
> The one thing I *do* find annoying is that the combination of
> format-patch and get_maintainers.pl can't easily say "I want to send all
> the patches and the cover letter to the same set of people, based on
> every patch".  (Or, at the very least, the cover letter to everyone.)
> Otherwise, maintainers get one patch out of the series, which may be
> confusing without context, and the cover letter doesn't go to anyone.
> Unfortunately, fixing that then tends to hit LKML's limit on number of
> recipients.
>

I carry this patch on top of StGit for exactly this purpose.

commit 562aca51a303e841a76defc3148db5c69b688994
Author: Dan Williams <dan.j.williams@intel.com>
Date:   Thu Feb 27 11:54:32 2014 -0800

    mail: auto cc cover letter to union of all attribution tags in a series

    If a receiver is only copied on the a single patch out of a larger
series she
    may not have the necessary context to judge the patch.  Auto cc her on the
    cover letter.

    Signed-off-by: Dan Williams <dan.j.williams@intel.com>

diff --git a/stgit/commands/mail.py b/stgit/commands/mail.py
index e641634981d6..d986b805dbc4 100644
--- a/stgit/commands/mail.py
+++ b/stgit/commands/mail.py
@@ -534,8 +534,18 @@ def __build_cover(tmpl, msg_id, options, patches):
     except Exception, ex:
         raise CmdException, 'template parsing error: %s' % str(ex)

+    extra_cc = []
+    if options.auto:
+        for patch in patches:
+            p = crt_series.get_patch(patch)
+            if p.get_description():
+                descr = p.get_description().strip()
+                extra_cc.extend(__get_signers_list(descr))
+        extra_cc = list(set(extra_cc))
+
+
     if not options.git:
-        __build_address_headers(msg, options)
+        __build_address_headers(msg, options, extra_cc)
     __build_extra_headers(msg, msg_id, options.in_reply_to)
     __encode_message(msg)