From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C9325FCD for ; Fri, 23 Aug 2019 15:31:50 +0000 (UTC) Received: from mail-yw1-f65.google.com (mail-yw1-f65.google.com [209.85.161.65]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id BEC338A0 for ; Fri, 23 Aug 2019 15:31:48 +0000 (UTC) Received: by mail-yw1-f65.google.com with SMTP id e65so3985023ywh.0 for ; Fri, 23 Aug 2019 08:31:48 -0700 (PDT) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id r35sm619389ywa.75.2019.08.23.08.31.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2019 08:31:46 -0700 (PDT) Received: by mail-yb1-f174.google.com with SMTP id s142so4134404ybc.6 for ; Fri, 23 Aug 2019 08:31:44 -0700 (PDT) MIME-Version: 1.0 References: <20190823013619.GA8130@mit.edu> <20190823151843.GH8130@mit.edu> In-Reply-To: <20190823151843.GH8130@mit.edu> From: Sean Paul Date: Fri, 23 Aug 2019 11:31:00 -0400 Message-ID: To: "Theodore Y. Ts'o" Content-Type: text/plain; charset="UTF-8" Cc: Joel Fernandes , Barret Rhoden , Dmitry Torokhov , ksummit , Greg Kroah-Hartman , Jonathan Nieder , Tomasz Figa , Han-Wen Nienhuys , Theodore Tso , David Rientjes , Dmitry Vyukov Subject: Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Aug 23, 2019 at 11:18 AM Theodore Y. Ts'o wrote: > > On Fri, Aug 23, 2019 at 09:15:30AM -0400, Sean Paul wrote: > > Only if you've uploaded the patch somewhere before sending it to the > > mailing list. I think this would satisfy the Gerrit crowd, since > > they're presumably uploading the patch to Gerrit, getting some review > > on it and then sending it upstream. They will have a link. If you're > > just interested in being archival tool friendly, you probably just > > want to add some uuid cookie to the patch and post it directly to the > > mailing list. > > And this is why I think something like one of the two: > > Link: https://linux-review.googlesource.com/c/1158 > Link: https://linux-review.googlesource.com/q/I3268f9036512c4378cde1da37e0612b43ed4d384 > > ... is a better choice. > Agreed. If you have a url for the patch this makes sense. I don't upload my patches to Gerrit, but I am interested in enabling patchwork (or equivalent tool) to do a better job of tracking revision changes. Currently I just link to all past revisions in the latest one (see [1]) so folks can see the prior discussion. It'd be nice if there was an easier way of achieving this. Sean [1]- https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1452c25b0e60278820f3d2155c65f1bfcce5ee79 > The Link tag, unlike the Change-Id: hidden amongst the diffstat, > allows any patch review comments which are made via Gerrit to be > accessible to the public. The main reason why I suggested the first > as opposed to the second initially is that one of the pushbacks > against the "Change-Id: " header was that the > "I3268f9036512c4378cde1da37e0612b43ed4d384" portion was ugly. > > Yes, that's purely an aesthetics argument, but in terms of human > emotional acceptance, that's important. The first is arguably better > than: > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=200847 > > ... which people are already willing to accept. > > There are some advantages to the second, in that we don't have to > contact Gerrit to assign the small integer number. Either way, > though, it should easy to teach Gerrit how to interpret either instead > of the "Change-Id:" tag, and for publically accessible Gerrit > instances, the Link: tag is strictly superior. It allows you to know > which Gerrit server to contact to find the review history, and it > becomes obvious whether that Gerrit server is publicaly accessible, or > if it is hidden behind a corporate firewall. > > Cheers, > > - Ted