From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id A3085FC2 for ; Fri, 5 Jul 2019 08:24:45 +0000 (UTC) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8F34B87B for ; Fri, 5 Jul 2019 08:24:44 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id r21so3586850otq.6 for ; Fri, 05 Jul 2019 01:24:44 -0700 (PDT) MIME-Version: 1.0 References: <7b73e1b7-cc34-982d-2a9c-acf62b88da16@linuxfoundation.org> <20190628205102.GA3131@agluck-desk2.amr.corp.intel.com> <87y31eov1l.fsf@concordia.ellerman.id.au> <87wogx17a5.fsf@concordia.ellerman.id.au> <87r27515qi.fsf@concordia.ellerman.id.au> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 5 Jul 2019 10:24:31 +0200 Message-ID: To: Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Cc: ksummit Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Thomas, On Fri, Jul 5, 2019 at 8:28 AM Thomas Gleixner wrote: > On Fri, 5 Jul 2019, Michael Ellerman wrote: > > Michael Ellerman writes: > > > Thomas Gleixner writes: > > >> On Thu, 4 Jul 2019, Geert Uytterhoeven wrote: > > >>> On Thu, Jul 4, 2019 at 2:22 PM Michael Ellerman wrote: > > >>> > If you've got the link back to the mailing list archive, do you also > > >>> > need Cc: tags in the change log? > > >> > > >> Probably not. > > >> > > >>> > It's always seemed to me they don't really add any value, they just tell > > >>> > you that lots of people were Cc'ed on the patch and probably didn't have > > >>> > time to review it :) > > >>> > > >>> +1 > > >>> > > >>> Especially if the CC list was generated by blindly copying the output > > >>> from scripts/get_maintainer.pl, without passing through a common sense > > >>> filter. > > >> > > >> And the maintainer then blindly picks it up :) > > > > > > Sorry to pick on you but I figure you can handle it :D > > I didn't feel offended :) > > > > This is the kind of thing we should really have a script to check for, > > > so that maintainers don't have to think about it when committing. > > > > Actually it looks like it's the tip bot adding these tags explicitly. > > Compare the original submission: > > > > https://lore.kernel.org/lkml/20190425094803.816485461@linutronix.de/ > > > > vs the tip-bot reply: > > > > https://lore.kernel.org/lkml/tip-3599fe12a125fa7118da2bcc5033d7741fb5f3a1@git.kernel.org/ > > No, it's my mbox to quilt script which does that for hysterical > raisins. Trivial to fix though. > > IIRC git-am does the same, but I might be wrong as usual. I'm happy to prove your last point ;-) At least the version of git-am I'm using does not add Cc: tags based on Cc: headers. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds