From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 878369C for ; Sun, 4 Sep 2016 17:45:07 +0000 (UTC) Received: from mail-it0-f66.google.com (mail-it0-f66.google.com [209.85.214.66]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 209AE125 for ; Sun, 4 Sep 2016 17:45:05 +0000 (UTC) Received: by mail-it0-f66.google.com with SMTP id e124so6962545ith.1 for ; Sun, 04 Sep 2016 10:45:05 -0700 (PDT) MIME-Version: 1.0 Sender: geert.uytterhoeven@gmail.com In-Reply-To: References: <27648120.ey0ZEtExVa@wuerfel> <20160731175753.GQ9681@localhost> <3132432.DrxSMjl1Vi@wuerfel> <20160902104619.GD9355@localhost> From: Geert Uytterhoeven Date: Sun, 4 Sep 2016 19:45:03 +0200 Message-ID: To: Linus Torvalds Content-Type: text/plain; charset=UTF-8 Cc: Dave Airlie , "Nikula, Jani" , "ksummit-discuss@lists.linuxfoundation.org" , Grant Likely Subject: Re: [Ksummit-discuss] [CORE TOPIC] (group) maintainership models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Linus, On Fri, Sep 2, 2016 at 7:25 PM, Linus Torvalds wrote: > On Fri, Sep 2, 2016 at 3:46 AM, Vinod Koul wrote: >> >> Arm seems to define NO_IRQ. This is not available in other arch and one >> driver (moxart-dma) is using it. I don't see why this should be arm specific. > > NO_IRQ is broken. We long long since agreed that 0 is "no irq", and > that the right way to test for it is just > > if (!irq) ... > > which is what all the generic drivers use. [...] > Some people have said "..but but but I have a real irq that has the > value 0", but that's irrelevant - the kernel "irq" value isn't > necessarily the same as the value that an interrupt _controller_ sees, > since the interrupt controller can be hiding behind various other > nested controllers etc. So an architecture might need to translate > "irq" into the actual hw interrupt controller value. Let's bite ;-) What about the legacy timer interrupt? $ git grep 'setup_irq(0,' arch/alpha/kernel/sys_ruffian.c: setup_irq(0, &timer_irqaction); arch/avr32/kernel/time.c: ret = setup_irq(0, &timer_irqaction); arch/mips/kernel/i8253.c: setup_irq(0, &irq0); arch/x86/kernel/time.c: setup_irq(0, &irq0); $ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds