From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54EEE4C8E for ; Mon, 23 Oct 2023 05:19:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gwmail.gwu.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gwmail.gwu.edu header.i=@gwmail.gwu.edu header.b="YcUJ1O3p" Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-457ee0df54eso1173488137.0 for ; Sun, 22 Oct 2023 22:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; t=1698038354; x=1698643154; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DPKNsYw47vEU08LvLMgxXuyAW0YiYMmyg4gd050CiD0=; b=YcUJ1O3p4Ea3F6PGcms3o9atEnXBiyixet3tcSIlASKeN6raf3sRWOLHRbcaASJre3 FboKBHhtY26s4fECQUvWOvn3jx4hc6nDb/4XRsP+dZe5z6fDWtDUscLAkcFmWylxu8fx CZjB0fh3gczpRZ7AQ9lEKNEzRNe1ULyXy/Mouzi4jmkf2PAnvv5OndkxvUvR7WACYwik 0Lx5g9msFUCJBambDp8uXA+xDWEZIyzUeHLlmyl9pKRAv4g/FkF1UUJCreadDGPAmy4X lmJgiHugDaYc+ORI7tHcD/rl6/SO6hf3Z+q90iCsuDOLRTHVzjEAa4m1VF6+2MOLXuHD fFUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698038354; x=1698643154; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DPKNsYw47vEU08LvLMgxXuyAW0YiYMmyg4gd050CiD0=; b=W4r9Kb8gu5HG87ntLQ7ZpXb+h0FAv9qMVXb9ygx1xxVkL/NpJ5XivuZNjqNNSDBuKk n/nPFjkwzRRDczseTe+91DL6PvM2ysnVpkobux3k+Ta5IybzHixy0ThpJjbXge4Iq981 6pyG0WThqR/6HswyfaY2KE+4y8mDqga2o8Bq/xJbmYmBimN1g/803En8Ph1APdpCjG3G PJoTGUQzG4Bzp5TgMJ/AxjxBKSpJUrLme2nbeO1wiNoLtLiMfzVgzh7y4OfOSqMGq9QM wbG8PKCQBoJsMg4vs7qJFpOPI49vPRWIMJJAAE2BkDOvadqN3dxG5W1c0lWh1u3wvYhe L/Jw== X-Gm-Message-State: AOJu0Yx2ufONt4jjqTnQK3s5Ww375EGmDHGqBETzHYCYHjsGBixQedxp +NzyiLLk6GyLEkEsTaYEsIuOknmEV87H8AMjMSsgQg== X-Google-Smtp-Source: AGHT+IEh6O5HX3O6bl7YbAamdDTtMciz3awzt2ARYdDjbYU12YPU+XbGQCu2nw5h2MHEdeM5mI/xBn2w4BcOndf5v3Q= X-Received: by 2002:a67:c003:0:b0:457:e2cf:2a6 with SMTP id v3-20020a67c003000000b00457e2cf02a6mr8088241vsi.8.1698038354028; Sun, 22 Oct 2023 22:19:14 -0700 (PDT) Precedence: bulk X-Mailing-List: ksummit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <8718a8a3-1e62-0e2b-09d0-7bce3155b045@roeck-us.net> <20230906215327.18a45c89@gandalf.local.home> <4af7c904-ac36-44c9-83c4-2cb30c732672@kadam.mountain> <20230907110409.GH19790@gate.crashing.org> <20230907123016.GJ19790@gate.crashing.org> In-Reply-To: From: Eric Gallager Date: Mon, 23 Oct 2023 01:19:02 -0400 Message-ID: Subject: Re: [MAINTAINERS/KERNEL SUMMIT] Trust and maintenance of file systems To: Richard Biener Cc: Segher Boessenkool , Dan Carpenter , Steven Rostedt , Dave Chinner , Guenter Roeck , Christoph Hellwig , ksummit@lists.linux.dev, linux-fsdevel@vger.kernel.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 12, 2023 at 5:53=E2=80=AFAM Richard Biener via Gcc-patches wrote: > > On Thu, Sep 7, 2023 at 2:32=E2=80=AFPM Segher Boessenkool > wrote: > > > > On Thu, Sep 07, 2023 at 02:23:00PM +0300, Dan Carpenter wrote: > > > On Thu, Sep 07, 2023 at 06:04:09AM -0500, Segher Boessenkool wrote: > > > > On Thu, Sep 07, 2023 at 12:48:25PM +0300, Dan Carpenter via Gcc-pat= ches wrote: > > > > > I started to hunt > > > > > down all the Makefile which add a -Werror but there are a lot and > > > > > eventually I got bored and gave up. > > > > > > > > I have a patch stack for that, since 2014 or so. I build Linux wit= h > > > > unreleased GCC versions all the time, so pretty much any new warnin= g is > > > > fatal if you unwisely use -Werror. > > > > > > > > > Someone should patch GCC so there it checks an environment variab= le to > > > > > ignore -Werror. Somethine like this? > > > > > > > > No. You should patch your program, instead. > > > > > > There are 2930 Makefiles in the kernel source. > > > > Yes. And you need patches to about thirty. Or a bit more, if you want > > to do it more cleanly. This isn't a guess. > > > > > > One easy way is to add a > > > > -Wno-error at the end of your command lines. Or even just -w if yo= u > > > > want or need a bigger hammer. > > > > > > I tried that. Some of the Makefiles check an environemnt variable as > > > well if you want to turn off -Werror. It's not a complete solution a= t > > > all. I have no idea what a complete solution looks like because I ga= ve > > > up. > > > > A solution can not involve changing the compiler. That is just saying > > the kernel doesn't know how to fix its own problems, so let's give the > > compiler some more unnecessary problems. > > You can change the compiler by replacing it with a script that appends > -Wno-error > for example. I personally would find the original proposal of an IGNORE_WERROR environment variable much simpler than any of the alternative proposed solutions, especially for complicated build systems where I can't tell where the "-Werror" is getting inserted from. Often times I'm not actually the developer of the package I'm trying to compile, so saying "fix your code" in such a case doesn't make sense, since it's not actually my code to fix in the first place. It would be much easier for end-users in such a situation to just set an environment variable, rather than asking them to try to become developers themselves, which is what some of these alternative proposals (such as "write your own script!") seem to be asking. > > > > > Or nicer, put it all in Kconfig, like powerpc already has for examp= le. > > > > There is a CONFIG_WERROR as well, so maybe use that in all places? > > > > > > That's a good idea but I'm trying to compile old kernels and not the > > > current kernel. > > > > You can patch older kernels, too, you know :-) > > > > If you need to not make any changes to your source code for some crazy > > reason (political perhaps?), just use a shell script or shell function > > instead of invoking the compiler driver directly? > > > > > > Segher > > > > Segher