From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTP id E1E8CACC for ; Mon, 12 May 2014 16:16:34 +0000 (UTC) Received: from mail-ve0-f171.google.com (mail-ve0-f171.google.com [209.85.128.171]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 36F132027C for ; Mon, 12 May 2014 16:16:33 +0000 (UTC) Received: by mail-ve0-f171.google.com with SMTP id oz11so9005143veb.2 for ; Mon, 12 May 2014 09:16:32 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1399552623.17118.22.camel@i7.infradead.org> <3908561D78D1C84285E8C5FCA982C28F328000EE@ORSMSX114.amr.corp.intel.com> <1399666748.2166.68.camel@dabdike.int.hansenpartnership.com> <4433093.MSzoqdJDMf@avalon> <20140512150722.GO12376@8bytes.org> From: Andy Lutomirski Date: Mon, 12 May 2014 09:16:11 -0700 Message-ID: To: Daniel Vetter Content-Type: text/plain; charset=UTF-8 Cc: James Bottomley , "ksummit-discuss@lists.linuxfoundation.org" Subject: Re: [Ksummit-discuss] [CORE TOPIC] Device error handling / reporting / isolation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, May 12, 2014 at 8:35 AM, Daniel Vetter wrote: > On Mon, May 12, 2014 at 5:07 PM, Joerg Roedel wrote: >> On Mon, May 12, 2014 at 12:43:09AM +0200, Daniel Vetter wrote: >>> So I think having some iommu storm handling (like we have for >>> interrupts in general and a lot of other things) would go a long way >>> towards the goal of enabling iommus everywhere. >> >> Right, the developer use-case needs also be taken into account. We could >> easily ignore a device after it did something wrong to get rid of >> io-page-fault or interupt storms. But we also need a way to tell the >> kernel to unignore the device later :) > > A disable/enable cycle of the pci bus master setting should be a good > enough signal? Presuming you can say for sure which devices is doing > the offending dma transactions ofc ... Or maybe we should just be > optimists and re-enable the IOMMU if _any_ child device gets > re-enabled (or bus master re-enabled for pci) in the hopes that the > developers just reloaded the driver. Worst case the storm handling > will kick in again shortly. Just to check: are you talking about disabling the IOMMU if there's a fault storm or disabling reporting of IOMMU faults? --Andy > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > _______________________________________________ > Ksummit-discuss mailing list > Ksummit-discuss@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss -- Andy Lutomirski AMA Capital Management, LLC