From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: ksummit-discuss@lists.linuxfoundation.org,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [Ksummit-discuss] [PATCH 2/2] kconfig: new command line kernel configuration tool
Date: Fri, 7 Jul 2017 07:55:27 +0200 [thread overview]
Message-ID: <CAJKOXPfE+ffRWq_1JB_1LSpg4gDne5pWNN2fKd-3t1hwX7amFA@mail.gmail.com> (raw)
In-Reply-To: <20170706144208.6hlgxwo37gntk6qm@mwanda>
On Thu, Jul 6, 2017 at 4:42 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This tool barely works, it's just a rough draft.
>
> Sometimes I want to search for a config so I have to load menuconfig,
> then search for the config entry, then exit. With this script I
> simply run:
>
> ./scripts/kconfig/kconfig search COMEDI
>
> Quite often I find myself trying to enable a feature by doing this:
>
> echo CONFIG_FEATURE=y >> .config
>
> But when I try to boot the new kernel, I find that the feature isn't
> there because the kernel runs `make oldconfig` and I didn't have all
> the depends selected so it silently removed it. With this feature
> what you can do is:
>
> ./scripts/kconfig/kconfig set FEATURE=y
Sounds useful. I need to enable few options from scripts and if
dependencies change they could be silently skipped.
Probably it would be nice to print what was effectively enabled to get
your feature in. However why not extending existing scripts/config? It
already has the feature for setting kconfig options (without looking
at dependencies - so like >> of yours).
Best regards,
Krzysztof
>
> It helps you enable the dependencies or it at least prints an error
> if it can't enable the feature.
>
> But this code isn't all implemented. 1) It doesn't calculate the
> dependencies well. See expr_parse() for more details. 2) It
> doesn't work well for things like:
>
> ./scripts/kconfig/kconfig set BT_INTEL=m
>
> because those aren't visible, they can only be using depend
> statements. Or say you try to set FEATURE=m when something else
> depends on it be set =y then the error message is wrong. The
> other problem is that I don't know how to print the help text.
> Again, this is just a rough draft.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> scripts/kconfig/Makefile | 6 +-
> scripts/kconfig/kconfig | 33 +++++
> scripts/kconfig/lconf.c | 332 +++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 370 insertions(+), 1 deletion(-)
> create mode 100755 scripts/kconfig/kconfig
> create mode 100644 scripts/kconfig/lconf.c
>
next prev parent reply other threads:[~2017-07-07 5:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 13:58 [Ksummit-discuss] [TECH TOPIC] is Kconfig a bit hard sometimes? Sergey Senozhatsky
2017-06-27 17:18 ` Linus Torvalds
2017-06-27 18:44 ` Luis R. Rodriguez
2017-06-27 19:27 ` Linus Torvalds
2017-06-27 20:53 ` Kees Cook
2017-06-27 21:16 ` Olof Johansson
2017-06-27 21:36 ` Linus Torvalds
2017-06-27 23:10 ` Serge E. Hallyn
2017-06-28 0:09 ` Luis R. Rodriguez
2017-06-28 0:14 ` Linus Torvalds
2017-06-28 0:26 ` Luis R. Rodriguez
2017-06-28 3:54 ` Stephen Hemminger
[not found] ` <CAFhKne-o0S8fMo_XD_aUk2Rf7VbDhgO+PT_bjnM-9WpKfnWBvw@mail.gmail.com>
[not found] ` <CAFhKne8FE=17wNdp=Svf2Z2tADok6htfYqTABEiZUrCOyeMaYg@mail.gmail.com>
2017-06-28 13:35 ` Matthew Wilcox
2017-06-28 17:56 ` Geert Uytterhoeven
2017-06-29 10:02 ` Mauro Carvalho Chehab
2017-06-28 0:11 ` Linus Torvalds
2017-06-29 10:23 ` Mauro Carvalho Chehab
2017-06-28 12:58 ` Dan Carpenter
2017-06-30 17:11 ` Steven Rostedt
2017-06-30 17:52 ` Darren Hart
2017-06-30 17:58 ` Darren Hart
2017-07-01 17:24 ` Hannes Reinecke
2017-06-27 20:41 ` Kees Cook
2017-07-06 14:40 ` Dan Carpenter
2017-07-06 14:41 ` [Ksummit-discuss] [PATCH 1/2] kconfig: add a silent option to conf_write() Dan Carpenter
2017-07-06 15:08 ` Steven Rostedt
2017-07-06 14:42 ` [Ksummit-discuss] [PATCH 2/2] kconfig: new command line kernel configuration tool Dan Carpenter
2017-07-07 5:55 ` Krzysztof Kozlowski [this message]
2017-07-07 9:02 ` Dan Carpenter
2017-07-09 3:56 ` Linus Walleij
2017-07-09 8:31 ` Geert Uytterhoeven
2017-07-09 17:03 ` Randy Dunlap
2017-07-09 19:43 ` Geert Uytterhoeven
2017-07-09 17:32 ` Frank Rowand
2017-07-10 9:44 ` Geert Uytterhoeven
2017-07-10 11:15 ` Dan Carpenter
2017-07-06 16:41 ` [Ksummit-discuss] [TECH TOPIC] is Kconfig a bit hard sometimes? Linus Torvalds
2017-07-06 17:11 ` Randy Dunlap
2017-07-07 11:36 ` Dan Carpenter
2017-07-10 17:15 ` Luck, Tony
2017-07-10 17:33 ` Alexandre Belloni
2017-07-10 18:28 ` Linus Torvalds
2017-07-10 19:44 ` Randy Dunlap
2017-07-11 6:21 ` Valentin Rothberg
2017-07-06 21:19 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPfE+ffRWq_1JB_1LSpg4gDne5pWNN2fKd-3t1hwX7amFA@mail.gmail.com \
--to=krzk@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox