From: Linus Torvalds <torvalds@linux-foundation.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: dan.j.williams@intel.com, Greg KH <gregkh@linuxfoundation.org>,
Doug Anderson <dianders@chromium.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
"ksummit@lists.linux.dev" <ksummit@lists.linux.dev>
Subject: Re: Replacing Link trailers
Date: Wed, 15 Oct 2025 12:15:09 -0700 [thread overview]
Message-ID: <CAHk-=wiLMH5QBF+veebJgdh=e=Q5uz7AEF0sfWPRhSAXvg8ASg@mail.gmail.com> (raw)
In-Reply-To: <20251015-versed-active-silkworm-bb87bd@lemur>
On Wed, 15 Oct 2025 at 11:37, Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
>>
> Git notes are fragile, they have important scalability problems (
Yeah, I don't think git notes are the answer - they are good for
purely *local* notes, but they just don't distribute well.
I think people would be a *lot* better off with b4 integration in
their workflow.
For example, I don't know how many people use git hooks. I personally
only do a couple: mainly I use them to do signature verification so
that I don't miss the "oh, somebody sent me pull request without a
signed tag".
I didn't always notice the lack of successful tag verification.
So I have a commit hook that makes it very obvious when I don't have a
key or when the tag was an unsigned one.
How about the people who love their link tags look at making them
*conscious*. That's what I hate about the current situation: I really
see a lot of completely useless tags because they've been added
mindlessly, and they are nothing but an annoyance.
And if people who have real workflows that use Link tags actually were
to add them consciously, I wouldn't hate them so much.
So for example, people have mentioned amending patches (although most
people have actually mentioned amending the commit *message*, which
doesn't change the patch ID), and that's where inserting - as comments
- the lore links for the original commit could be a good idea.
Look, you can have a .git/hooks/prepare-commit-msg script that looks
something like this:
#!/bin/sh
COMMIT_MSG_FILE=$1
COMMIT_SOURCE=$2
SHA1=$3
b4 dig -c "$SHA1" 2>&1 | sed 's/^/# /' >> "$COMMIT_MSG_FILE"
And lo and behold: you'll find the 'b4 dig' output at the end of your
commit message as you start editing it.
(The above script is "tested" in that I verified that yes
Ok, so the above is a really minimal hook, but I hope it gives people
ideas of how they can make things like Link tags work in a *conscious*
model, not a "mindlessly add them" model.
It's really the "add a flag to a config file and forget it, and now
every commit you do has a link tag whether you thought about it or
not" that I dislike so much.
Linus
next prev parent reply other threads:[~2025-10-15 19:15 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 11:53 James Bottomley
2025-10-13 12:25 ` Mathieu Desnoyers
2025-10-13 12:48 ` James Bottomley
2025-10-13 12:50 ` Mark Brown
2025-10-13 14:52 ` Guenter Roeck
2025-10-13 17:36 ` Steven Rostedt
2025-10-14 19:12 ` Johannes Berg
2025-10-14 19:35 ` Steven Rostedt
2025-10-15 22:01 ` Johannes Berg
2025-10-15 22:22 ` Steven Rostedt
2025-10-16 10:16 ` Simona Vetter
2025-10-16 12:18 ` Hans de Goede
2025-10-16 18:39 ` David Woodhouse
2025-10-16 7:43 ` Geert Uytterhoeven
2025-10-14 20:23 ` Doug Anderson
2025-10-16 8:08 ` Dan Carpenter
2025-10-13 15:40 ` Doug Anderson
2025-10-13 16:31 ` James Bottomley
2025-10-13 17:39 ` Steven Rostedt
2025-10-13 17:50 ` Theodore Ts'o
2025-10-13 19:07 ` H. Peter Anvin
2025-10-13 19:20 ` Linus Torvalds
2025-10-13 19:35 ` James Bottomley
2025-10-13 19:37 ` H. Peter Anvin
2025-10-13 19:36 ` H. Peter Anvin
2025-10-13 20:34 ` Doug Anderson
2025-10-13 20:36 ` H. Peter Anvin
2025-10-13 20:58 ` Laurent Pinchart
2025-10-13 20:59 ` Vlastimil Babka
2025-10-13 21:46 ` Doug Anderson
2025-10-14 14:23 ` Sasha Levin
2025-10-14 11:09 ` Mark Brown
2025-10-13 19:35 ` H. Peter Anvin
2025-10-14 16:01 ` dan.j.williams
2025-10-14 17:46 ` Greg KH
2025-10-14 17:57 ` dan.j.williams
2025-10-15 17:09 ` dan.j.williams
2025-10-15 17:55 ` James Bottomley
2025-10-15 18:04 ` Luck, Tony
2025-10-15 18:37 ` Konstantin Ryabitsev
2025-10-15 19:13 ` dan.j.williams
2025-10-15 19:15 ` Linus Torvalds [this message]
2025-10-15 19:17 ` Linus Torvalds
2025-10-15 22:51 ` Doug Anderson
2025-10-16 4:26 ` Chen-Yu Tsai
2025-10-16 6:57 ` Greg KH
2025-10-16 10:04 ` Jani Nikula
2025-10-16 11:54 ` James Bottomley
2025-10-16 12:18 ` Greg KH
2025-10-16 12:29 ` James Bottomley
2025-10-16 13:00 ` Konstantin Ryabitsev
2025-10-16 13:47 ` Steven Rostedt
2025-10-16 14:36 ` Mark Brown
2025-10-16 14:58 ` Rob Herring
2025-10-16 15:07 ` James Bottomley
2025-10-16 15:36 ` Geert Uytterhoeven
2025-10-16 15:52 ` James Bottomley
2025-10-16 15:37 ` Steven Rostedt
2025-10-16 19:29 ` H. Peter Anvin
2025-10-16 19:32 ` James Bottomley
2025-10-16 23:53 ` H. Peter Anvin
2025-10-16 19:09 ` James Bottomley
2025-10-17 2:27 ` Doug Anderson
2025-10-17 8:44 ` Vlastimil Babka
2025-10-17 9:21 ` Geert Uytterhoeven
2025-10-17 10:09 ` Rafael J. Wysocki
2025-10-16 12:34 ` Mathieu Desnoyers
2025-10-16 12:49 ` Mark Brown
2025-10-16 12:49 ` Geert Uytterhoeven
2025-10-16 12:54 ` Mathieu Desnoyers
2025-10-16 13:07 ` Geert Uytterhoeven
2025-10-16 12:51 ` Jiri Kosina
2025-10-16 12:54 ` James Bottomley
2025-10-16 13:51 ` Steven Rostedt
2025-10-16 16:21 ` Michael S. Tsirkin
2025-10-16 12:20 ` Steven Rostedt
2025-10-15 21:29 ` Kees Cook
2025-10-15 21:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiLMH5QBF+veebJgdh=e=Q5uz7AEF0sfWPRhSAXvg8ASg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dan.j.williams@intel.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=konstantin@linuxfoundation.org \
--cc=ksummit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox