From: Kees Cook <keescook@chromium.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [CORE TOPIC] kernel testing standard
Date: Fri, 30 May 2014 13:59:08 -0700 [thread overview]
Message-ID: <CAGXu5jLqm1QDH4doN5pU0+MS_mTT3mwAdfiYvwwgqkBGzz3y9g@mail.gmail.com> (raw)
In-Reply-To: <20140530143530.5816c980@gandalf.local.home>
On Fri, May 30, 2014 at 11:35 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 26 May 2014 20:33:38 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>
>> If we force to unify the test frameworks, it will neither be maintained
>> nor used. Instead, if maintainers state what test they will run and how
>> to maintain it, we are sure that each test will be done on the each
>> subsystem branch, and before release, we can avoid to run all tests which
>> requires many hardware and long time but just run a small number of tests
>> (e.g. LTP, trinity, etc.)
>
> I agree with this. Just having a single place to put tests or tell
> people where the tests are would be a huge improvement. If I wanted to
> run my own tests on ext file systems, I should be able to set up the
> same environment that Ted uses. If someone wants to run my ftrace
> tests, then they should be able to as well (which I need to make
> available to the general public). Better yet, this can open up a door
> for people to contribute to new tests for a particular subsystem. I
> would love it if people added tests for me to run on ftrace. I have a
> bunch of hacks to test various functionality (as they are hacky, that's
> the reason I haven't posted them yet).
>
> This shouldn't be about "make tests" which I think is silly. But a way
> to standardize tests, or at least have a single repository to show how
> different parts of the kernel is tested. My tests require running as
> root, other tests should not require that. This is just an example of
> how different tests have different requirements and no one size fits
> all.
I've been adding stuff in tools/testing/selftests when ever I can.
Based on the stuff living in there, I think there several things
needed for being able to hook stuff up to a framework:
common reporting/exit code handling: right now "make run_tests" mostly
requires a human to read everything and decide if something failed.
That's no good.
common "starting state" documentation: the various tests require
changes to CONFIG items, sysctls, uid, etc. Having a common format for
describing these states mean a framework would be able to, say, build
randconfig and then pick the correct subset of tests to run. Or
changing sysctls before running a test.
(And as an example of code work to be done: on my TODO list is taking
the seccomp-bpf test suite, currently living on github, and getting it
added to the selftests tree.)
-Kees
--
Kees Cook
Chrome OS Security
next prev parent reply other threads:[~2014-05-30 20:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 11:47 Masami Hiramatsu
2014-05-23 13:32 ` Jason Cooper
2014-05-23 16:24 ` Olof Johansson
2014-05-23 16:35 ` Guenter Roeck
2014-05-23 16:36 ` Jason Cooper
2014-05-23 18:10 ` Masami Hiramatsu
2014-05-23 18:36 ` Jason Cooper
2014-05-23 18:06 ` Masami Hiramatsu
2014-05-23 18:32 ` Jason Cooper
2014-05-23 14:05 ` Justin M. Forbes
2014-05-23 16:04 ` Mark Brown
2014-05-24 0:30 ` Theodore Ts'o
2014-05-24 1:15 ` Guenter Roeck
2014-05-26 11:33 ` Masami Hiramatsu
2014-05-30 18:35 ` Steven Rostedt
2014-05-30 20:59 ` Kees Cook [this message]
2014-05-30 22:53 ` Theodore Ts'o
2014-06-04 13:51 ` Masami Hiramatsu
2014-05-26 17:08 ` Daniel Vetter
2014-05-26 18:21 ` Mark Brown
2014-05-28 15:37 ` Mel Gorman
2014-05-28 18:57 ` Greg KH
2014-05-30 12:07 ` Linus Walleij
2014-06-05 0:23 ` Greg KH
2014-06-05 6:54 ` Mel Gorman
2014-06-05 8:30 ` Geert Uytterhoeven
2014-06-05 8:44 ` chrubis
2014-06-05 8:53 ` Daniel Vetter
2014-06-05 11:17 ` Masami Hiramatsu
2014-06-05 11:58 ` Daniel Vetter
2014-06-06 9:10 ` Masami Hiramatsu
2014-06-05 14:10 ` James Bottomley
2014-06-06 9:17 ` Masami Hiramatsu
2014-06-09 14:44 ` chrubis
2014-06-09 17:54 ` Michael Kerrisk (man-pages)
2014-06-05 8:39 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jLqm1QDH4doN5pU0+MS_mTT3mwAdfiYvwwgqkBGzz3y9g@mail.gmail.com \
--to=keescook@chromium.org \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox