From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTP id 15CBB6FC for ; Mon, 12 May 2014 17:42:56 +0000 (UTC) Received: from mail-ig0-f175.google.com (mail-ig0-f175.google.com [209.85.213.175]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8F55420398 for ; Mon, 12 May 2014 17:42:55 +0000 (UTC) Received: by mail-ig0-f175.google.com with SMTP id uq10so4127513igb.8 for ; Mon, 12 May 2014 10:42:55 -0700 (PDT) MIME-Version: 1.0 Sender: saharabeara@gmail.com In-Reply-To: <20140512173220.GC12708@titan.lakedaemon.net> References: <20140511041449.GP12708@titan.lakedaemon.net> <53703416.5070400@zytor.com> <20140512061332.GA10134@thin> <1399886585.879.108.camel@i7.infradead.org> <20140512162229.GY12708@titan.lakedaemon.net> <5370FAF8.7070209@zytor.com> <20140512173220.GC12708@titan.lakedaemon.net> Date: Mon, 12 May 2014 10:42:54 -0700 Message-ID: From: Sarah A Sharp To: Jason Cooper Content-Type: text/plain; charset=UTF-8 Cc: PJ Waskiewicz , Dirk Hohndel , ksummit-discuss@lists.linuxfoundation.org, Anton Arapov , Sarah A Sharp Subject: Re: [Ksummit-discuss] [TECH TOPIC] QR encoded oops for the kernel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, May 12, 2014 at 10:32 AM, Jason Cooper wrote: > On Mon, May 12, 2014 at 09:46:48AM -0700, H. Peter Anvin wrote: >> On 05/12/2014 09:22 AM, Jason Cooper wrote: >> > >> > Something like this? >> > >> > >> > - pr_warn("------------[ cut here ]------------\n"); >> > + pr_warn("------------[ cut 10 lines above here ]------------\n"); >> > pr_warn("WARNING: CPU: %d PID: %d at %s:%d %pS()\n", >> > raw_smp_processor_id(), current->pid, file, line, caller); >> > >> >> Why not just drop it? > > I think there's value in being specific. First time reporters tend to > quote too little when left to their own devices. When I was more active > in the Gentoo community, I recall many times getting only the > "make[1]:..." lines or the "emerge" bits. By the time you ask for more, > the data was lost. Wasn't the "cut here" line put in for people to know which chunk of log to feed to scripts/markup_oops.pl? Or is it smarter these days? Sarah Sharp