ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Rob Herring <robh@kernel.org>, "Bird, Tim" <Tim.Bird@sony.com>
Cc: Joe Perches <joe@perches.com>,
	"laurent.pinchart@ideasonboard.com"
	<laurent.pinchart@ideasonboard.com>, Andrew Lunn <andrew@lunn.ch>,
	Steven Rostedt <rostedt@goodmis.org>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Chris Mason <clm@meta.com>,
	"ksummit@lists.linux.dev" <ksummit@lists.linux.dev>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Alexei Starovoitov <ast@kernel.org>,
	"Knut.omang@oracle.com" <Knut.omang@oracle.com>
Subject: Re: checkpatch encouragement improvements (was RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools)
Date: Fri, 10 Oct 2025 14:33:16 -0300	[thread overview]
Message-ID: <930B1323-9587-4988-9FC7-050E8A3DA8A7@gmail.com> (raw)
In-Reply-To: <CAL_JsqLM4P+x4iE0DnuKoWfwiMEZjM2Z4D_gcU5HHk9qNUYFsg@mail.gmail.com>



On October 10, 2025 2:11:43 PM GMT-03:00, Rob Herring <robh@kernel.org> wrote:
>On Fri, Oct 10, 2025 at 11:03 AM Bird, Tim <Tim.Bird@sony.com> wrote:
>> > From: Joe Perches <joe@perches.com>
>> But my goal here is to have checkpatch issues show up like gcc errors - early in development,
>> as the errors are made, so they never make it into patch emails.
>
>Running on the source wouldn't expose things which only show up in the
>patch. Missing or other S-o-b errors, missing commit msg, using 'This
>patch/commit...', etc. I think it would be good if we ran checkpatch
>on every patch, but start with only checks with no false positives and
>ones every maintainer agrees on. Then we can add to it from there
>perhaps enabling per subsystem checks.

There are so many simple things that can be done to signal people how to prepare their contribution in a way that will increase the odds that it'll be accepted that don't include AI, just automation, but since this started as an AI review thread and this message is about tags...

Recently a member of our team showed me the review comments from a LLM, Claude iirc, and it , included: 

Submission Guidelines**: ✓ COMPLIANT
 - Has Signed-off-by
 - Has mailing list link
 - Follows kernel patch conventions

But probably that "Has mailing list link" isn't following Linus' latest fatwa, that Link tags should only be used if they add some useful info, not just the original patch. 

To check if that is in place AI may be needed, I think. 

- Arnaldo

  reply	other threads:[~2025-10-10 17:33 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 17:04 [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Chris Mason
2025-10-08 17:20 ` Konstantin Ryabitsev
2025-10-08 18:11   ` Sasha Levin
2025-10-08 18:35   ` Chris Mason
2025-10-08 17:57 ` Bart Van Assche
2025-10-08 18:04   ` Chris Mason
2025-10-08 18:14     ` Bart Van Assche
2025-10-08 18:42       ` Chris Mason
2025-10-08 21:08     ` Kees Cook
2025-10-09  1:37       ` Chris Mason
2025-10-08 18:33 ` Sasha Levin
2025-10-09  1:43   ` Chris Mason
2025-10-09 14:49     ` Paul E. McKenney
2025-10-08 19:08 ` Andrew Lunn
2025-10-08 19:28   ` Arnaldo Carvalho de Melo
2025-10-08 19:33     ` Laurent Pinchart
2025-10-08 19:39       ` Arnaldo Carvalho de Melo
2025-10-08 20:29         ` Andrew Lunn
2025-10-08 20:53           ` Mark Brown
2025-10-09  9:37         ` Laurent Pinchart
2025-10-09 12:48           ` Arnaldo Carvalho de Melo
2025-10-08 19:29   ` Laurent Pinchart
2025-10-08 19:50     ` Bird, Tim
2025-10-08 20:30       ` Sasha Levin
2025-10-09 12:32         ` Arnaldo Carvalho de Melo
2025-10-08 20:30       ` James Bottomley
2025-10-08 20:38         ` Bird, Tim
2025-10-08 22:21           ` Jiri Kosina
2025-10-09  9:14           ` Laurent Pinchart
2025-10-09 10:03             ` Chris Mason
2025-10-10  7:54               ` Laurent Pinchart
2025-10-10 11:40                 ` James Bottomley
2025-10-10 11:53                   ` Laurent Pinchart
2025-10-10 14:21                     ` Steven Rostedt
2025-10-10 14:35                   ` Bird, Tim
2025-10-09 14:30             ` Steven Rostedt
2025-10-09 14:51               ` Andrew Lunn
2025-10-09 15:05                 ` Steven Rostedt
2025-10-10  7:59                 ` Laurent Pinchart
2025-10-10 14:15                   ` Bird, Tim
2025-10-10 15:07                     ` Joe Perches
2025-10-10 16:01                       ` checkpatch encouragement improvements (was RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools) Bird, Tim
2025-10-10 17:11                         ` Rob Herring
2025-10-10 17:33                           ` Arnaldo Carvalho de Melo [this message]
2025-10-10 19:21                           ` Joe Perches
2025-10-10 16:11                       ` [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Steven Rostedt
2025-10-10 16:47                         ` Joe Perches
2025-10-10 17:42                           ` Steven Rostedt
2025-10-11 10:28                         ` Mark Brown
2025-10-09 16:31               ` Chris Mason
2025-10-09 17:19                 ` Arnaldo Carvalho de Melo
2025-10-09 17:24                   ` Arnaldo Carvalho de Melo
2025-10-09 17:31                     ` Alexei Starovoitov
2025-10-09 17:47                       ` Arnaldo Carvalho de Melo
2025-10-09 18:42                     ` Chris Mason
2025-10-09 18:56                       ` Linus Torvalds
2025-10-10 15:52                         ` Mauro Carvalho Chehab
2025-10-09 14:47             ` Bird, Tim
2025-10-09 15:11               ` Andrew Lunn
2025-10-09 17:58               ` Mark Brown
2025-10-09  1:15         ` Chris Mason
2025-10-08 20:37     ` Andrew Lunn
2025-10-09 12:40       ` Arnaldo Carvalho de Melo
2025-10-09 14:52 ` Paul E. McKenney
2025-10-10  3:08 ` Krzysztof Kozlowski
2025-10-10 14:12   ` Chris Mason
2025-10-31 16:51   ` Stephen Hemminger
2025-10-14  7:16 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=930B1323-9587-4988-9FC7-050E8A3DA8A7@gmail.com \
    --to=arnaldo.melo@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=Knut.omang@oracle.com \
    --cc=Tim.Bird@sony.com \
    --cc=andrew@lunn.ch \
    --cc=ast@kernel.org \
    --cc=clm@meta.com \
    --cc=dan.carpenter@linaro.org \
    --cc=joe@perches.com \
    --cc=ksummit@lists.linux.dev \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox