From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id ACF8610EA for ; Thu, 4 Jul 2019 12:22:06 +0000 (UTC) Received: from ozlabs.org (ozlabs.org [203.11.71.1]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9F33270D for ; Thu, 4 Jul 2019 12:22:05 +0000 (UTC) From: Michael Ellerman To: Thomas Gleixner , Takashi Iwai In-Reply-To: References: <7b73e1b7-cc34-982d-2a9c-acf62b88da16@linuxfoundation.org> <20190628205102.GA3131@agluck-desk2.amr.corp.intel.com> Date: Thu, 04 Jul 2019 22:15:18 +1000 Message-ID: <87y31eov1l.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Cc: ksummit-discuss@lists.linuxfoundation.org Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Thomas Gleixner writes: > On Sat, 29 Jun 2019, Takashi Iwai wrote: >> On Fri, 28 Jun 2019 22:51:03 +0200, >> Luck, Tony wrote: >> > That captures for posterity the useful information without >> > bulking up the commit log with the blow-by-blow deltas of >> > how the patch series evolved across 27 versions submitted >> > to the mailing list. >> >> Agreed. And I'm thinking whether we may have come consistent tag >> for following the post discussions on ML archive. Then the detailed >> descriptions can be dropped from the changelog, and readers can still >> follow easily. e.g. the patch version change can be simply a >> reference URL. > > This tag exists today: > > Link: https://lore.kernel.org/lkml/MESSAGE-ID > > my 'grab patches from list' scripts insert that tag automatically and it's > part of the commit changelog in git. That allows you to just jump to the > mail archive of the merged submission. If you've got the link back to the mailing list archive, do you also need Cc: tags in the change log? It's always seemed to me they don't really add any value, they just tell you that lots of people were Cc'ed on the patch and probably didn't have time to review it :) A couple of Cc: tags is no big deal, but sometimes they can get a bit out of hand, eg. below. cheers commit 3599fe12a125fa7118da2bcc5033d7741fb5f3a1 Author: Thomas Gleixner Date: Thu Apr 25 11:45:22 2019 +0200 x86/stacktrace: Use common infrastructure Replace the stack_trace_save*() functions with the new arch_stack_walk() interfaces. Signed-off-by: Thomas Gleixner Reviewed-by: Josh Poimboeuf Cc: Andy Lutomirski Cc: linux-arch@vger.kernel.org Cc: Steven Rostedt Cc: Alexander Potapenko Cc: Alexey Dobriyan Cc: Andrew Morton Cc: Christoph Lameter Cc: Pekka Enberg Cc: linux-mm@kvack.org Cc: David Rientjes Cc: Catalin Marinas Cc: Dmitry Vyukov Cc: Andrey Ryabinin Cc: kasan-dev@googlegroups.com Cc: Mike Rapoport Cc: Akinobu Mita Cc: Christoph Hellwig Cc: iommu@lists.linux-foundation.org Cc: Robin Murphy Cc: Marek Szyprowski Cc: Johannes Thumshirn Cc: David Sterba Cc: Chris Mason Cc: Josef Bacik Cc: linux-btrfs@vger.kernel.org Cc: dm-devel@redhat.com Cc: Mike Snitzer Cc: Alasdair Kergon Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: Joonas Lahtinen Cc: Maarten Lankhorst Cc: dri-devel@lists.freedesktop.org Cc: David Airlie Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Tom Zanussi Cc: Miroslav Benes Link: https://lkml.kernel.org/r/20190425094803.816485461@linutronix.de