From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id D37A9E3C for ; Wed, 12 Sep 2018 08:42:41 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7307113A for ; Wed, 12 Sep 2018 08:42:41 +0000 (UTC) From: Jani Nikula To: Alexandre Belloni , Daniel Vetter In-Reply-To: <20180911220047.GQ2494@piout.net> References: <8412864.7ztUKcXNNC@avalon> <2019489.6joTqyUi4Z@avalon> <20180911124423.GM2494@piout.net> <20180911220047.GQ2494@piout.net> Date: Wed, 12 Sep 2018 11:42:53 +0300 Message-ID: <87worr14z6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Cc: ksummit Subject: Re: [Ksummit-discuss] [MAINTAINER SUMMIT] community management/subsystem governance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 12 Sep 2018, Alexandre Belloni wrote: > Most of the drivers are developed by their maintainer or someone paid > by the vendor (which is basically the same because the maintainer is > actually getting paid to get his colleagues patches upstream). > > I also see that the review numbers hint at biased reviews for the big > drivers as they are not coming from outsiders. > > So what I see in DRM is exactly what you despis in other areas of the > kernel: mostly unreviewed maintainer self commits. I'll only speak for drm/i915 here as one of its maintainers, and I'll steer clear of the preceding debate, but your conclusions don't hold water wrt drm/i915. Sure, most of the contributions, both patches and review, come from paid Intel developers. It's a very busy driver. We pushed just under 8 commits per day on the average in the v4.4..v4.18 range. For reference, that's 6.6% of all of drivers/. More than sound/, a bit less than fs/ or net/ top level directories, but in the same ballpark. By our rules, *nobody* gets to push unreviewed patches, and we follow that religiously. The more complicated the patch, the more rigorous the review must be, involving domain experts or generally more sets of eyes. If we had to rely on outside reviews, either our rate of change would grind to a halt, or we'd have to loosen our rules. Instead, we trust our maintainers and committers to have the integrity to follow our documented merge criteria. And bypassing the rules would be a fast lane to losing the maintainer/committer status. Anyone contributing to drm/i915 will tell you there are no biased reviews. Some might say we are more gentle towards outside contributors than our own. I'm also pretty confident you won't find examples of unreviewed commits, let alone unreviewed maintainer self commits. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center