From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 22787723 for ; Fri, 5 Jul 2019 03:37:10 +0000 (UTC) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id AA9E887B for ; Fri, 5 Jul 2019 03:37:09 +0000 (UTC) From: Michael Ellerman To: Thomas Gleixner , Geert Uytterhoeven In-Reply-To: References: <7b73e1b7-cc34-982d-2a9c-acf62b88da16@linuxfoundation.org> <20190628205102.GA3131@agluck-desk2.amr.corp.intel.com> <87y31eov1l.fsf@concordia.ellerman.id.au> Date: Fri, 05 Jul 2019 13:37:06 +1000 Message-ID: <87wogx17a5.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Cc: ksummit Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Thomas Gleixner writes: > On Thu, 4 Jul 2019, Geert Uytterhoeven wrote: >> On Thu, Jul 4, 2019 at 2:22 PM Michael Ellerman wrote: >> > If you've got the link back to the mailing list archive, do you also >> > need Cc: tags in the change log? > > Probably not. > >> > It's always seemed to me they don't really add any value, they just tell >> > you that lots of people were Cc'ed on the patch and probably didn't have >> > time to review it :) >> >> +1 >> >> Especially if the CC list was generated by blindly copying the output >> from scripts/get_maintainer.pl, without passing through a common sense >> filter. > > And the maintainer then blindly picks it up :) Sorry to pick on you but I figure you can handle it :D This is the kind of thing we should really have a script to check for, so that maintainers don't have to think about it when committing. cheers