From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id F102F723 for ; Fri, 5 Jul 2019 04:10:32 +0000 (UTC) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id AB94E70D for ; Fri, 5 Jul 2019 04:10:31 +0000 (UTC) From: Michael Ellerman To: Thomas Gleixner , Geert Uytterhoeven In-Reply-To: <87wogx17a5.fsf@concordia.ellerman.id.au> References: <7b73e1b7-cc34-982d-2a9c-acf62b88da16@linuxfoundation.org> <20190628205102.GA3131@agluck-desk2.amr.corp.intel.com> <87y31eov1l.fsf@concordia.ellerman.id.au> <87wogx17a5.fsf@concordia.ellerman.id.au> Date: Fri, 05 Jul 2019 14:10:29 +1000 Message-ID: <87r27515qi.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Cc: ksummit Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Michael Ellerman writes: > Thomas Gleixner writes: >> On Thu, 4 Jul 2019, Geert Uytterhoeven wrote: >>> On Thu, Jul 4, 2019 at 2:22 PM Michael Ellerman wrote: >>> > If you've got the link back to the mailing list archive, do you also >>> > need Cc: tags in the change log? >> >> Probably not. >> >>> > It's always seemed to me they don't really add any value, they just tell >>> > you that lots of people were Cc'ed on the patch and probably didn't have >>> > time to review it :) >>> >>> +1 >>> >>> Especially if the CC list was generated by blindly copying the output >>> from scripts/get_maintainer.pl, without passing through a common sense >>> filter. >> >> And the maintainer then blindly picks it up :) > > Sorry to pick on you but I figure you can handle it :D > > This is the kind of thing we should really have a script to check for, > so that maintainers don't have to think about it when committing. Actually it looks like it's the tip bot adding these tags explicitly. Compare the original submission: https://lore.kernel.org/lkml/20190425094803.816485461@linutronix.de/ vs the tip-bot reply: https://lore.kernel.org/lkml/tip-3599fe12a125fa7118da2bcc5033d7741fb5f3a1@git.kernel.org/ cheers