From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 4572EA5E for ; Fri, 16 Nov 2018 12:43:35 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D42B9786 for ; Fri, 16 Nov 2018 12:43:34 +0000 (UTC) From: Jani Nikula To: Julia Lawall , Geert Uytterhoeven In-Reply-To: References: <154225759358.2499188.15268218778137905050.stgit@dwillia2-desk3.amr.corp.intel.com> <154225760492.2499188.14152986544451112930.stgit@dwillia2-desk3.amr.corp.intel.com> Date: Fri, 16 Nov 2018 14:44:07 +0200 Message-ID: <878t1tgpk8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Cc: ksummit-discuss@lists.linuxfoundation.org, "linux-nvdimm@lists.01.org" , vishal.l.verma@intel.com, Linux Kernel Mailing List , stfrench@microsoft.com, Greg KH , Mauro Carvalho Chehab , Dmitry Vyukov , "Tobin C. Harding" Subject: Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 15 Nov 2018, Julia Lawall wrote: > On Thu, 15 Nov 2018, Geert Uytterhoeven wrote: > >> Hi Julia, >> >> On Thu, Nov 15, 2018 at 6:48 AM Julia Lawall wrote: >> > How about patch subject lines? What is the formula that should be used to >> > transform the name(s) of the affected file(s) into an appropriate suject >> > line? >> >> Automating that may be difficult. >> I always use "git log --oneline", and try to derive something sane >> from its output. > > Yes, I do likewise. But there may be some subsystems for which it would > be possible to come up with a more specific policy. The advantage of what > is proposed here is that it is not necessary to come up with a single > formula that works everywhere. Even a description in English could be > helpful. I quickly cooked up this script to produce the top-5 commit prefixes for the given files over the arbitrary last 200 commits. It'll give you a pretty good idea if you're even close. --- #!/bin/sh # usage: subject-prefix FILE [...] # show top 5 subject prefixes for FILEs git log --format=%s -n 200 -- "$@" |\ grep -v "^Merge " |\ sed 's/\(.*\):.*/\1/' |\ sort | uniq -c | sort -nr | sed 's/ *[0-9]\+ //' |\ head -n 5 --- Someone who knows perl could turn that into a checkpatch check: See if the patch subject prefix is one of the top-5 for all files changed by the patch, and ask the user to double check if it isn't. Or some heuristics thereof. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center