From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 829491547E9; Tue, 22 Oct 2024 09:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729588292; cv=none; b=NrmaYZZ13FJYq8xp2eW+dzryWeyHOFjdBVNs49qQbjSwSUV8bph16ybf4zUwFY5lRx7OZrpJ3Ia6qP3Nzrxhl1ardHx8PPyq2SQSi/kOVs1/Y7xQ4BR+knNASMUzjVQQ4wwKWEygYlXpFwG4NDo/KfHudEcqJD9SpkpH3jSnnUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729588292; c=relaxed/simple; bh=SuaO2hUg8jq6+mBwcJQpwCgUafGXnnDIZEBf/nME/Ug=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HzVbP7xi5dYcqjtKdh+jIZOXobr690LtQlshpmrWWhVSOhRzWcdBTduYCSoXLmQKIu37aaJN5NdOvDV11fH36PaO4MY5fonp0IePmm5v3ptLr+ivDNTgdGi6OHx5KFtuRufrQRqeMh7ArejSyNuoK9ytnlU3/cT/Q2yZDfasaRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rl6H2+yS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rl6H2+yS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24410C4CEC3; Tue, 22 Oct 2024 09:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729588292; bh=SuaO2hUg8jq6+mBwcJQpwCgUafGXnnDIZEBf/nME/Ug=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Rl6H2+ySHY3/0sn3OU27Voh6u3pQxRwwa2G19MdNQwnU3CMfzewVIGQOJEk3jE5PJ WMW4AsKnFnIaXjcuB9WqH1KF7ifUO3JavY3/SrzAGDz+GDBj4VJ/dI/9Bla8Vz0i7C +VA5QTPM93ia0oe2a4R0Fy6CqrpgTMKcDX1H/9/pbD1nA6d45OSaahgpIu2V/axE90 f/uKXjFTYi7/n9B03D6TBQLQaRGijolonYcvPBsyAooqvb9NPicsZx9LEr7eY07rLu MjP0UmwlTCWlpqLL8WBIpxkhLLTXY3DB0TJodLXZ9zyWW04HFLJu9qk1Z1okAieQrI 5eYxb8SoSA7Dw== Message-ID: <8465de6a-3eee-492e-8d82-d1ea3a3c4c05@kernel.org> Date: Tue, 22 Oct 2024 11:11:29 +0200 Precedence: bulk X-Mailing-List: ksummit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: linus-next: improving functional testing for to-be-merged pull requests Content-Language: en-GB To: Sasha Levin Cc: ksummit@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org References: From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Sasha, Thank you for your replies! On 21/10/2024 19:36, Sasha Levin wrote: > On Mon, Oct 21, 2024 at 07:18:38PM +0200, Matthieu Baerts wrote: >> On 21/10/2024 18:07, Sasha Levin wrote: (...) >>>     4. Continuous tree (not daily tags like in linux-next), >>>     facilitating easier bisection >> >> What will happen when a pull request is rejected? > > My mental playbook is: > > 1. If a pull request is just ignored, ping it in case it was forgotten. > 2. If we have an explicit NACK, just revert the merge commit. Hopefully these reverts will be exceptional, because they can quickly be hard to manage! >> (...) >> >>> We also want to avoid altering the existing workflow. In particular: >>> >>>     1. No increase in latency. If anything, the expectation is that >>>     the cadence of merges would be improved given that Linus will >>>     need to do less builds and tests. >>> >>>     2. Require "sign up" for the tree like linux-next does. Instead, >>>     pull requests are monitored and grabbed directly from the >>>     mailing list. >> >> Out of curiosity: is it done automatically? Will it email someone when a >> conflict is found? > > So it's 80% automatic now: my scripts monitor emails using lei, parse > relevant ones and manage to extract the pull instructions out of them, > and then most of those pull requests just merge cleanly. > > There are some with conflicts, but since Linus insists on having an > explanation for merge conflicts, those pull requsts contain those > instructions within them. In those cases I manually followed the > instructions to resolve the conflicts (which were trivial so far). > > I'll likely send a mail out *only* if I see a non-trivial merge conflict > without an explanation in the body. OK, thank you! >> (...) >> >>> Current testing: >>>   - LKFT: https://qa-reports.linaro.org/lkft/sashal-linus-next/ >>>   - KernelCI: https://t.ly/KEW7F >> >> That's great to have more tests being executed! Who is going to monitor >> the results? This task can quickly take time if this person also has to >> check for false positives and flaky tests. >> >> Are the maintainers supposed to regularly monitor the results for the >> tests they are responsible for? Or will they be (automatically?) emailed >> when there is a regression? > > I'm not sure about this part. While I look at it in and will likely send > a mail out if I see something fishy, the only change in workflow that I > hope will happen here is Linus looking at a dashboard or two before he > begins his daily merge session. OK, thank you! I find these dashboards not so easy to read: there are many tests, and it is not always clear what they are doing or how important they are. Yes it is possible to find the history and check if a test is known as being unstable, but there are no indicators to show that directly, nor a global one saying "OK to pull". What I want to say is that I hope these dashboards will help, and not just to say "look, we are running tests", but nobody is actually looking at the results :) Cheers, Matt -- Sponsored by the NGI0 Core fund.