From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 85C54AC2 for ; Wed, 8 Jul 2015 09:52:47 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id E155AA8 for ; Wed, 8 Jul 2015 09:52:46 +0000 (UTC) In-Reply-To: <20150708075253.606BA4306F@saturn.retrosnub.co.uk> References: <201507080121.41463.PeterHuewe@gmx.de> <201507080905.00051.PeterHuewe@gmx.de> <20150708075253.606BA4306F@saturn.retrosnub.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable From: Peter Huewe Date: Wed, 08 Jul 2015 11:52:26 +0200 To: jic23@jic23.retrosnub.co.uk Message-ID: <816E7020-4868-4AD8-B34E-FAD5938A9B81@gmx.de> Cc: Josh Boyer , Jason Cooper , ksummit-discuss@lists.linuxfoundation.org Subject: Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hey, >I'm very luck in IIO in that I have a core set of very good reviewers >with (I think) a mix of paid and volunteers=2E As a volunteer Maintainer >I couldn't cope with the rate of patches without them!=20 > >One thing that happens fairly often is that I get a very good initial >review in then the reviewer moves on to other patches=2E I suspect this >is because they are focusing on where they can do the most productive >work=2E Sometimes I go to the effort of chasing them up for an >ack / reviewed by, but often they get no recognition at all=2E=20 > >Note I tend to do an additional review (often v3 or later by the >time I get to them) but these guys have done a lot of the leg work=2E >One of my reviewers specializes in very detailed reviews slightly after >I have applied the patches, but that's another story :)=20 > >So how to give these incredibly helpful people more recognition? >Do other maintainers add reviewed-by tags sometimes without the >reviewer >specifically giving them? The docs have always said these should >indicate that the reviewer is happy with the result=2E In this case the >reviewer may not have looked at the result, but contributed earlier >in the process=2E=20 Actually I do, at least if I have the feeling that it would be in the revi= ewers intention=2E Credit where credit is due=2E If I'm unsure I mail the reviewers and ask them (or via IRC) >Does anyone else actually get these sorts of reviews?=20 Yes happens a lot - v1-5 get a lot of reviews , v8 gets none except my own= :) But the important stuff is usually dealt with in v1-3=2E so I usually add = the reviewed-by tags if nothing fundamentally has changed So the Situation is much likr in iio (Yes in TPM we usually need v5 or more:) Peter --=20 Sent from my mobile