From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Joe Perches , Greg KH References: <20160913194520.GA8071@cloud> <20160913140322.3ccad27c@lwn.net> <4691924.fimvUkKjuv@vostro.rjw.lan> <20160914020332.GA9558@cloud> <1473819862.32273.16.camel@perches.com> <20160914115456.GB22341@kroah.com> <1473863028.32273.28.camel@perches.com> From: Guenter Roeck Message-ID: <77a6ad59-9fdc-7d2b-0186-49016e05a403@roeck-us.net> Date: Wed, 14 Sep 2016 07:45:35 -0700 MIME-Version: 1.0 In-Reply-To: <1473863028.32273.28.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: ksummit-discuss@lists.linux-foundation.org, ksummit-discuss@lists.linuxfoundation.org Subject: Re: [Ksummit-discuss] [CORE TOPIC] checkpatch/Codingstyle and trivial patch spam List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 09/14/2016 07:23 AM, Joe Perches wrote: > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote: >> On Tue, Sep 13, 2016 at 07:24:22PM -0700, Joe Perches wrote: >>> On Tue, 2016-09-13 at 19:03 -0700, Josh Triplett wrote: >>>> "Do >>>> not mass-reformat existing code, even if it doesn't follow these >>>> guidelines; doing so creates noise in version control history and makes >>>> patches fail to apply." >>> Or maybe add something like a new entry for what types of changes >>> are acceptable with a default of "none" >>> C: Whitespace and Style >> Ick, no, we have way too many things in the MAINTAINERS file as it is... > > So what would use propose instead? > Introduce .checkpatch ? Guenter > I think the primary issue is people using "scripts/checkpatch.pl -f" > > I think that shouldn't be done without an understanding of when > it is useful and when it is not useful to use that -f option. > > I have proposed adding an undocumented --force option to checkpatch > which would disallow -f unless --force is also used. > > https://lkml.org/lkml/2015/2/11/433 > > Does anyone object to this? > _______________________________________________ > Ksummit-discuss mailing list > Ksummit-discuss@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss >